You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/05 07:43:39 UTC
[GitHub] [dubbo-samples] zrlw opened a new pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
zrlw opened a new pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384
Fix #383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw commented on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952906496
> Duplicated with this pr: #382
>
> ```
> @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS)
> ```
>
> DirtiesContext will notify Junit to destroy spring context after test class, then also destroy dubbo application. Avoid using DubboBootstrap.reset() method everywhere.
if disable DubboTestChecker, then #382 works, otherwise it doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs closed pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
kylixs closed pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw edited a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952898734
#382 does not reset the static boolean variable destroyed of AbstractRegistryFactory, look at these logs which was generated today:
https://github.com/apache/dubbo/runs/4022083096?check_suite_focus=true
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.847 s - in org.apache.dubbo.samples.version.VersionService2IT
test(org.apache.dubbo.samples.version.VersionService2IT) Time elapsed: 0.29 s
<== VersionService2IT end
Running org.apache.dubbo.samples.version.VersionService1IT
<== VersionService1IT begin
...
[27/10/21 12:36:30:030 UTC] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap has started., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
[27/10/21 12:36:30:030 UTC] main WARN support.AbstractRegistryFactory: [DUBBO] All registry instances have been destroyed, failed to fetch any instance. Usually, this means no need to try to do unnecessary redundant resource clearance, all registries has been taken care of., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
<== AbstractRegistryFactory#destroyed is still true
...
[27/10/21 12:36:30:030 UTC] main ERROR context.TestContextManager: Caught exception while allowing TestExecutionListener [org.springframework.test.context.support.DependencyInjectionTestExecutionListener@75201592] to prepare test instance [org.apache.dubbo.samples.version.VersionService1IT@1162410a]
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.dubbo.samples.version.VersionService1IT': Unsatisfied dependency expressed through field 'service'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'versionService': FactoryBean threw exception on object creation; nested exception is java.lang.IllegalStateException: Add nodeCache listener for path:/dubbo/config/dubbo/org.apache.dubbo.samples.version.api.VersionService:1.0.0:.condition-router
<== still cause UnsatisfiedDependencyException
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw edited a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952898734
#382 does not reset the static boolean variable ```destroyed``` of AbstractRegistryFactory, look at these logs which was generated today (build master branch) :
https://github.com/apache/dubbo/runs/4022083096?check_suite_focus=true
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.847 s - in org.apache.dubbo.samples.version.VersionService2IT
test(org.apache.dubbo.samples.version.VersionService2IT) Time elapsed: 0.29 s
<== VersionService2IT end
Running org.apache.dubbo.samples.version.VersionService1IT
<== VersionService1IT begin
...
[27/10/21 12:36:30:030 UTC] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap has started., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
[27/10/21 12:36:30:030 UTC] main WARN support.AbstractRegistryFactory: [DUBBO] All registry instances have been destroyed, failed to fetch any instance. Usually, this means no need to try to do unnecessary redundant resource clearance, all registries has been taken care of., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
<== AbstractRegistryFactory#destroyed is still true
...
[27/10/21 12:36:30:030 UTC] main ERROR context.TestContextManager: Caught exception while allowing TestExecutionListener [org.springframework.test.context.support.DependencyInjectionTestExecutionListener@75201592] to prepare test instance [org.apache.dubbo.samples.version.VersionService1IT@1162410a]
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.dubbo.samples.version.VersionService1IT': Unsatisfied dependency expressed through field 'service'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'versionService': FactoryBean threw exception on object creation; nested exception is java.lang.IllegalStateException: Add nodeCache listener for path:/dubbo/config/dubbo/org.apache.dubbo.samples.version.api.VersionService:1.0.0:.condition-router
<== still cause UnsatisfiedDependencyException
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw removed a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw removed a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952906496
> Duplicated with this pr: #382
>
> ```
> @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS)
> ```
>
> DirtiesContext will notify Junit to destroy spring context after test class, then also destroy dubbo application. Avoid using DubboBootstrap.reset() method everywhere.
if disable DubboTestChecker, then #382 works, otherwise it doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw commented on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952898734
#382 does not reset the static boolean variable destroyed of AbstractRegistryFactory, look at these logs which was generated today:
https://github.com/apache/dubbo/runs/4022083096?check_suite_focus=true
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.847 s - in org.apache.dubbo.samples.version.VersionService2IT
test(org.apache.dubbo.samples.version.VersionService2IT) Time elapsed: 0.29 s
<== VersionService2IT end
Running org.apache.dubbo.samples.version.VersionService1IT
<== VersionService1IT begin
...
[27/10/21 12:36:30:030 UTC] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap has started., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
[27/10/21 12:36:30:030 UTC] main WARN support.AbstractRegistryFactory: [DUBBO] All registry instances have been destroyed, failed to fetch any instance. Usually, this means no need to try to do unnecessary redundant resource clearance, all registries has been taken care of., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
<== AbstractRegistryFactory#destroyed is still true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs edited a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
kylixs edited a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-951787374
Duplicated with this pr: https://github.com/apache/dubbo-samples/pull/382
```
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS)
```
DirtiesContext will notify Junit to destroy spring context after test class, then also destroy dubbo application.
Avoid using DubboBootstrap.reset() method everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-951787374
Duplicate with this pr: https://github.com/apache/dubbo-samples/pull/382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zrlw edited a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-952898734
#382 does not reset the static boolean variable ```destroyed``` of AbstractRegistryFactory, look at these logs which was generated today:
https://github.com/apache/dubbo/runs/4022083096?check_suite_focus=true
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.847 s - in org.apache.dubbo.samples.version.VersionService2IT
test(org.apache.dubbo.samples.version.VersionService2IT) Time elapsed: 0.29 s
<== VersionService2IT end
Running org.apache.dubbo.samples.version.VersionService1IT
<== VersionService1IT begin
...
[27/10/21 12:36:30:030 UTC] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap has started., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
[27/10/21 12:36:30:030 UTC] main WARN support.AbstractRegistryFactory: [DUBBO] All registry instances have been destroyed, failed to fetch any instance. Usually, this means no need to try to do unnecessary redundant resource clearance, all registries has been taken care of., dubbo version: 2.7.14-SNAPSHOT, current host: 192.168.128.5
<== AbstractRegistryFactory#destroyed is still true
...
[27/10/21 12:36:30:030 UTC] main ERROR context.TestContextManager: Caught exception while allowing TestExecutionListener [org.springframework.test.context.support.DependencyInjectionTestExecutionListener@75201592] to prepare test instance [org.apache.dubbo.samples.version.VersionService1IT@1162410a]
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.dubbo.samples.version.VersionService1IT': Unsatisfied dependency expressed through field 'service'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'versionService': FactoryBean threw exception on object creation; nested exception is java.lang.IllegalStateException: Add nodeCache listener for path:/dubbo/config/dubbo/org.apache.dubbo.samples.version.api.VersionService:1.0.0:.condition-router
<== still cause UnsatisfiedDependencyException
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs edited a comment on pull request #384: add DubboBootstrap.reset() for dubbo-samples-version
Posted by GitBox <gi...@apache.org>.
kylixs edited a comment on pull request #384:
URL: https://github.com/apache/dubbo-samples/pull/384#issuecomment-951787374
Duplicated with this pr: https://github.com/apache/dubbo-samples/pull/382
```
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS)
```
DirtiesContext will notify Junit to destroy spring context after test class.
Avoid using DubboBootstrap.reset() method everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org