You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/08 10:07:46 UTC
[GitHub] [incubator-devlake] klesh opened a new pull request, #2451: feat: add ae swagger support
klesh opened a new pull request, #2451:
URL: https://github.com/apache/incubator-devlake/pull/2451
# Summary
As title suggested
### Does this close any open issues?
Closes #2450
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #2451: feat: add ae swagger support
Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #2451:
URL: https://github.com/apache/incubator-devlake/pull/2451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2451: feat: add ae swagger support
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2451:
URL: https://github.com/apache/incubator-devlake/pull/2451#issuecomment-1181200885
> There's also a mistake in the swagger docs [here](https://github.com/apache/incubator-devlake/blob/e5830611b7b32e8b35faec32180c07a39b1291f7/api/pipelines/pipelines.go#L54). The parameter type should be models.NewPipeline, not string
Nice catch, but it is out of the scope, would you file a bug for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #2451: feat: add ae swagger support
Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #2451:
URL: https://github.com/apache/incubator-devlake/pull/2451#discussion_r916705208
##########
api/docs/stub.go:
##########
@@ -0,0 +1 @@
+package docs
Review Comment:
Missed apache header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on pull request #2451: feat: add ae swagger support
Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2451:
URL: https://github.com/apache/incubator-devlake/pull/2451#issuecomment-1180378567
There's also a mistake in the swagger docs [here](https://github.com/apache/incubator-devlake/blob/e5830611b7b32e8b35faec32180c07a39b1291f7/api/pipelines/pipelines.go#L54).
The parameter type should be models.NewPipeline, not string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org