You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:52 UTC

[Impala-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Hello Internal Jenkins, Tim Armstrong,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4220

to review the following change.

Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()
......................................................................

IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Testing:
Added a targeted unit test.

Change-Id: Iabb977014d855d6edb035bf2e9519ac8b3234767
Reviewed-on: http://gerrit.cloudera.org:8080/3878
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit e6702c67309cae4b46da6de935bcf873800a2f3c)
---
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/buffered-tuple-stream.h
3 files changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/20/4220/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabb977014d855d6edb035bf2e9519ac8b3234767
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.

Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iabb977014d855d6edb035bf2e9519ac8b3234767
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>