[GitHub] [spark] MaxGekk commented on a diff in pull request #38299: [SPARK-40756][SQL] Migrate type check failures of string expressions onto error classes

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #38299:
URL: https://github.com/apache/spark/pull/38299#discussion_r998968154


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -248,11 +248,21 @@
           "The <exprName> must not be null"
         ]
       },
+      "UNEXPECTED_NUM_PARAMS" : {

Review Comment:
   It seems it is similar to `WRONG_NUM_PARAMS`. Could you re-use the existing one or improve it.



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -248,11 +248,21 @@
           "The <exprName> must not be null"
         ]
       },
+      "UNEXPECTED_NUM_PARAMS" : {
+        "message" : [
+          "The <functionName> requires at least <num> arguments."
+        ]
+      },
       "UNEXPECTED_STATIC_METHOD" : {
         "message" : [
           "cannot find a static method <methodName> that matches the argument types in <className>"
         ]
       },
+      "UNEXPECTED_VALUE" : {

Review Comment:
   Can't you re-use `VALUE_OUT_OF_RANGE`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org