You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 12:55:42 UTC

[GitHub] [flink] wuchong commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory

wuchong commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558842


   When I writing the code, I have a feeling that maybe `DeserializationFormat` is a better name than `DeserializationSchemaProvider` , because it is created from `DeserializationFormatFactory` and is more intuitive in the `FactoryUtil#discoverXxxxFormat`. But I’m not sure what’s your opinion here @twalthr @KurtYoung , as we’re swinging in the new names again…


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org