You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "ChengJie1053 (via GitHub)" <gi...@apache.org> on 2023/05/07 06:40:27 UTC
[GitHub] [linkis] ChengJie1053 opened a new pull request, #4523: metadata-query code optimization
ChengJie1053 opened a new pull request, #4523:
URL: https://github.com/apache/linkis/pull/4523
metadata-query code optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] peacewong merged pull request #4523: metadata-query code optimization
Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong merged PR #4523:
URL: https://github.com/apache/linkis/pull/4523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] peacewong commented on a diff in pull request #4523: metadata-query code optimization
Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong commented on code in PR #4523:
URL: https://github.com/apache/linkis/pull/4523#discussion_r1187454747
##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/common/src/main/java/org/apache/linkis/metadata/query/common/cache/CacheConfiguration.java:
##########
@@ -35,4 +35,9 @@ public class CacheConfiguration {
CommonVars.apply(
"wds.linkis.server.mdq.mysql.relationship",
"mysql,oracle,kingbase,postgresql,sqlserver,db2,greenplum,dm,doris,clickhouse,tidb,starrocks,gaussdb");
+
+ public static final CommonVars<String> QUERY_DATABASE_RELATIONSHIP =
+ CommonVars.apply(
+ "wds.linkis.server.mdq.query.database.relationship",
Review Comment:
new conf should to remove wds
##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/server/src/main/java/org/apache/linkis/metadata/query/server/loader/MetaClassLoaderManager.java:
##########
@@ -128,7 +130,26 @@ public BiFunction<String, Object[], Object> getInvoker(String dsType) throws Err
}
String expectClassName = null;
if (dsType.length() > 0) {
- String prefix = dsType.substring(0, 1).toUpperCase() + dsType.substring(1);
+ String converDsType = dsType;
+ try {
+ HashMap map =
Review Comment:
Can be modified as a static variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] ChengJie1053 commented on a diff in pull request #4523: metadata-query code optimization
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on code in PR #4523:
URL: https://github.com/apache/linkis/pull/4523#discussion_r1188028249
##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/common/src/main/java/org/apache/linkis/metadata/query/common/cache/CacheConfiguration.java:
##########
@@ -35,4 +35,9 @@ public class CacheConfiguration {
CommonVars.apply(
"wds.linkis.server.mdq.mysql.relationship",
"mysql,oracle,kingbase,postgresql,sqlserver,db2,greenplum,dm,doris,clickhouse,tidb,starrocks,gaussdb");
+
+ public static final CommonVars<String> QUERY_DATABASE_RELATIONSHIP =
+ CommonVars.apply(
+ "wds.linkis.server.mdq.query.database.relationship",
Review Comment:
> new conf should to remove wds
Ok, thank you for reviewing the code
##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/common/src/main/java/org/apache/linkis/metadata/query/common/cache/CacheConfiguration.java:
##########
@@ -35,4 +35,9 @@ public class CacheConfiguration {
CommonVars.apply(
"wds.linkis.server.mdq.mysql.relationship",
"mysql,oracle,kingbase,postgresql,sqlserver,db2,greenplum,dm,doris,clickhouse,tidb,starrocks,gaussdb");
+
+ public static final CommonVars<String> QUERY_DATABASE_RELATIONSHIP =
+ CommonVars.apply(
+ "wds.linkis.server.mdq.query.database.relationship",
Review Comment:
> update docs/configuration
Ok, thank you for reviewing the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] casionone commented on a diff in pull request #4523: metadata-query code optimization
Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on code in PR #4523:
URL: https://github.com/apache/linkis/pull/4523#discussion_r1187607868
##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/common/src/main/java/org/apache/linkis/metadata/query/common/cache/CacheConfiguration.java:
##########
@@ -35,4 +35,9 @@ public class CacheConfiguration {
CommonVars.apply(
"wds.linkis.server.mdq.mysql.relationship",
"mysql,oracle,kingbase,postgresql,sqlserver,db2,greenplum,dm,doris,clickhouse,tidb,starrocks,gaussdb");
+
+ public static final CommonVars<String> QUERY_DATABASE_RELATIONSHIP =
+ CommonVars.apply(
+ "wds.linkis.server.mdq.query.database.relationship",
Review Comment:
update docs/configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org