You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2024/03/08 17:09:05 UTC
[PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
lburgazzoli opened a new pull request, #13423:
URL: https://github.com/apache/camel/pull/13423
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli merged PR #13423:
URL: https://github.com/apache/camel/pull/13423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986779728
> I dont think we need to have org.apache.camel as prefix for protocol, autoscaling etc.
At this stage it was a port 1-1 of what exists in camel-k where the `org.apache.camel` was meant as a namespace for camel specific things, opening the door to add other, non camel specific annotation, like `dev.knative, io.strimzi, software.amazon`.
Now I think we can remove the namespace since we are moving to the camel catalog, I'll do so on Monday.
> Also is there anything that is autoscaling = false. It seems its just everything that is true
This was just a marker were the absence means autoscaling=false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986869425
A bit more is still there
"metadata": { "camel.apache.org\/routes.language": "kotlin" },
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986084665
@davsclaus here a quick POC about addin arbitrary annotations to the catalog entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986878698
Did you really put
```
@Metadata(annotations = {
"autoscaling=true",
})
```
in all the components ?
I think CK should just infer that it can scale, unless a very special component has set autoscaling=false
And then only put this in the json if its false. The protocol=http and those language stuff is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986875248
> A bit more is still there
>
> "metadata": { "camel.apache.org/routes.language": "kotlin" },
done, hopefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986083278
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986775337
I dont think we need to have org.apache.camel as prefix for protocol, autoscaling etc.
Also is there anything that is autoscaling = false. It seems its just everything that is true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1986867831
@davsclaus, I've removed the `org.apache.camel` prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-16557: add a free form key value map on components, dataformats, languages, etc [camel]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #13423:
URL: https://github.com/apache/camel/pull/13423#issuecomment-1987845507
ok, `autoscaling=true` has been removed. I guess we can use the protocol as initial way ot infer the autoscaling capabilities and then add specific annotation for special components as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org