You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ji...@apache.org on 2016/07/08 17:39:17 UTC

incubator-geode git commit: GEODE-1571: fix messing test category and ignore the unsupported api tests.

Repository: incubator-geode
Updated Branches:
  refs/heads/develop f8b620c63 -> 7965bd758


GEODE-1571: fix messing test category and ignore the unsupported api tests.

* tests are ignored because server would treat them as internal message and won't bind the correct message to it.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/7965bd75
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/7965bd75
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/7965bd75

Branch: refs/heads/develop
Commit: 7965bd758bc67022d933215984d46bf1aafefaba
Parents: f8b620c
Author: Jinmei Liao <ji...@pivotal.io>
Authored: Fri Jul 8 10:38:44 2016 -0700
Committer: Jinmei Liao <ji...@pivotal.io>
Committed: Fri Jul 8 10:38:44 2016 -0700

----------------------------------------------------------------------
 .../IntegratedClientGetClientPRMetaDataAuthDistributedTest.java  | 4 ++++
 ...gratedClientGetClientPartitionAttrCmdAuthDistributedTest.java | 4 +++-
 .../com/gemstone/gemfire/security/CQPostProcessorDunitTest.java  | 4 ++++
 .../security/IntegratedClientQueryAuthDistributedTest.java       | 3 ++-
 4 files changed, 13 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7965bd75/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPRMetaDataAuthDistributedTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPRMetaDataAuthDistributedTest.java b/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPRMetaDataAuthDistributedTest.java
index dc2ecbd..2823829 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPRMetaDataAuthDistributedTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPRMetaDataAuthDistributedTest.java
@@ -16,6 +16,7 @@
  */
 package com.gemstone.gemfire.security;
 
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -34,6 +35,9 @@ public class IntegratedClientGetClientPRMetaDataAuthDistributedTest
   extends AbstractIntegratedClientAuthDistributedTest {
 
   @Test
+  @Ignore("This is not a supported client message")
+  // this would fail sporatically because ServerConnection.isInternalMessage would return true for this message,
+  // and it won't bind the correct subject on the executing thread.
   public void testGetClientPartitionAttrCmd() {
     client1.invoke("logging in stranger", () -> {
       ClientCache cache = new ClientCacheFactory(createClientProperties("stranger", "1234567")).setPoolSubscriptionEnabled(true)

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7965bd75/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest.java b/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest.java
index 84922ba..679eea6 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest.java
@@ -31,7 +31,9 @@ public class IntegratedClientGetClientPartitionAttrCmdAuthDistributedTest
   extends AbstractIntegratedClientAuthDistributedTest {
 
   @Test
-  @Ignore("failed if running until failure with anonymous user")
+  @Ignore("This is not a supported client message")
+  // this would fail sporatically because ServerConnection.isInternalMessage would return true for this message,
+  // and it won't bind the correct subject on the executing thread.
   public void testGetClientPartitionAttrCmd() {
     client1.invoke("logging in stranger", () -> {
       ClientCache cache = createClientCache("stranger", "1234567", serverPort);

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7965bd75/geode-cq/src/test/java/com/gemstone/gemfire/security/CQPostProcessorDunitTest.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/test/java/com/gemstone/gemfire/security/CQPostProcessorDunitTest.java b/geode-cq/src/test/java/com/gemstone/gemfire/security/CQPostProcessorDunitTest.java
index 54f2e1a..00b8e33 100644
--- a/geode-cq/src/test/java/com/gemstone/gemfire/security/CQPostProcessorDunitTest.java
+++ b/geode-cq/src/test/java/com/gemstone/gemfire/security/CQPostProcessorDunitTest.java
@@ -20,6 +20,7 @@ package com.gemstone.gemfire.security;
 import static org.junit.Assert.*;
 
 import org.junit.Test;
+import org.junit.experimental.categories.Category;
 
 import com.gemstone.gemfire.cache.Region;
 import com.gemstone.gemfire.cache.client.ClientCache;
@@ -33,7 +34,10 @@ import com.gemstone.gemfire.cache.query.CqResults;
 import com.gemstone.gemfire.cache.query.QueryService;
 import com.gemstone.gemfire.cache.query.internal.cq.CqListenerImpl;
 import com.gemstone.gemfire.security.templates.SamplePostProcessor;
+import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.SecurityTest;
 
+@Category({ DistributedTest.class, SecurityTest.class })
 public class CQPostProcessorDunitTest extends AbstractIntegratedClientAuthDistributedTest {
 
   public CQPostProcessorDunitTest(){

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7965bd75/geode-cq/src/test/java/com/gemstone/gemfire/security/IntegratedClientQueryAuthDistributedTest.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/test/java/com/gemstone/gemfire/security/IntegratedClientQueryAuthDistributedTest.java b/geode-cq/src/test/java/com/gemstone/gemfire/security/IntegratedClientQueryAuthDistributedTest.java
index 0b22146..d9b69b7 100644
--- a/geode-cq/src/test/java/com/gemstone/gemfire/security/IntegratedClientQueryAuthDistributedTest.java
+++ b/geode-cq/src/test/java/com/gemstone/gemfire/security/IntegratedClientQueryAuthDistributedTest.java
@@ -30,8 +30,9 @@ import com.gemstone.gemfire.cache.query.CqListener;
 import com.gemstone.gemfire.cache.query.CqQuery;
 import com.gemstone.gemfire.cache.query.QueryService;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.SecurityTest;
 
-@Category(DistributedTest.class)
+@Category({ DistributedTest.class, SecurityTest.class })
 public class IntegratedClientQueryAuthDistributedTest extends AbstractIntegratedClientAuthDistributedTest {
 
   @Test