You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/20 08:47:59 UTC

[GitHub] [airflow] potiuk opened a new pull request, #24556: Clarify that users should not use Maria DB

potiuk opened a new pull request, #24556:
URL: https://github.com/apache/airflow/pull/24556

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] github-actions[bot] commented on pull request #24556: Clarify that users should not use Maria DB

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24556:
URL: https://github.com/apache/airflow/pull/24556#issuecomment-1160196718

   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #24556: Clarify that users should not use Maria DB

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24556:
URL: https://github.com/apache/airflow/pull/24556#issuecomment-1160164749

   Following the discussions and problem raised with MariaDB https://github.com/apache/airflow/issues/24247 (amogst others) and the fact that our survey revealed that almost no-one uses MariaDB, comparing to MySQL today), I propose that we very specifically describe the kind of problems that users can have with MariaDB and strongly discourage them from using it.
   
   I think this is a bit unfair NOT being explicit about it. We know MariaDB causes problems, due to the number of users using it using it we can have at most anecdotal evidence of their problems and we make no attempt whatsoever on test and verify that any of the changes of ours will work on Maria DB.
   
   This is I think simply unfair to our users, because by not telling them explicitly "Do not use MariaDB" they can have false hopes and expectations than it will work, and when they vest into this environment, they will come back with their expectations we will help them to fix their problems - which we won't. 
   
   I am a strong believer in being explicit about such limitations we are aware of, this brings much better value to our users, as this allows them to make better informed choices when they decide about deployment of Airflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #24556: Clarify that users should not use Maria DB

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24556:
URL: https://github.com/apache/airflow/pull/24556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org