You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Pace2Car (via GitHub)" <gi...@apache.org> on 2023/03/22 11:23:34 UTC

[GitHub] [shardingsphere] Pace2Car opened a new issue, #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Pace2Car opened a new issue, #24752:
URL: https://github.com/apache/shardingsphere/issues/24752

   Hi community,
   
   This issue is one of the tasks of #24746.
   
   If not sure what to do, please refer to the example: #24742
   
   ## Aim
   - [ ] RandomReadQueryLoadBalanceAlgorithm
   - [ ] RoundRobinReadQueryLoadBalanceAlgorithm
   - [ ] WeightReadQueryLoadBalanceAlgorithm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] QiangYuan0828 commented on issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "QiangYuan0828 (via GitHub)" <gi...@apache.org>.
QiangYuan0828 commented on issue #24752:
URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1479993481

   Hi, I would like to work on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24752:
URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1480492043

   Hi @QiangYuan0828, welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang closed issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm
URL: https://github.com/apache/shardingsphere/issues/24752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] QiangYuan0828 commented on issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "QiangYuan0828 (via GitHub)" <gi...@apache.org>.
QiangYuan0828 commented on issue #24752:
URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1498455332

   @Pace2Car Got it, thanks for your clarification. I will correct it and resubmit again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] Pace2Car commented on issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24752:
URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1498426932

   > Hi, does my pull request satisfy the demand? hopes have some suggestions.
   
   Hi @QiangYuan0828, Thanks for your PR, but it seems that these checks are unnecessary in your PR, The target described in the main issue(#24746) is to improve the properties verification in the `init` method.
   
   For example, in `WeightReadQueryLoadBalanceAlgorithm.init()`, the data sources must not be empty, and the weight of data source must be configured
   
   BTW: use `ShardingSpherePreconditions.checkState` like other checks do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] QiangYuan0828 commented on issue #24752: Improve properties verification of ReadQueryLoadBalanceAlgorithm

Posted by "QiangYuan0828 (via GitHub)" <gi...@apache.org>.
QiangYuan0828 commented on issue #24752:
URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1498240100

   Hi, does my pull request satisfy the demand? hopes have some suggestions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org