[GitHub] [superset] kgabryje commented on a change in pull request #14710: feat(native-filters): add search all filter options

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #14710:
URL: https://github.com/apache/superset/pull/14710#discussion_r637929403



##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -18,31 +18,76 @@
  */
 import {
   AppSection,
+  DataMask,
   ensureIsArray,
+  ExtraFormData,
   GenericDataType,
+  JsonObject,
   smartDateDetailedFormatter,
   t,
   tn,
 } from '@superset-ui/core';
-import React, { useEffect, useState } from 'react';
+import React, { useCallback, useEffect, useReducer, useState } from 'react';
 import { Select } from 'src/common/components';
-import { FIRST_VALUE, PluginFilterSelectProps, SelectValue } from './types';
+import { debounce } from 'lodash';

Review comment:
       Apparently it's better to `import debounce from 'lodash/debounce'`, as it results in smaller bundle size (and we probably should apply that in other places in superset).
   References:
   https://stackoverflow.com/questions/35250500/correct-way-to-import-lodash
   https://www.blazemeter.com/blog/the-correct-way-to-import-lodash-libraries-a-benchmark




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org