You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/02/24 01:12:21 UTC

Review Request 43921: HIVE-13120 propagate doAs when generating ORC splits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43921/
-----------------------------------------------------------

Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 9b1d7ae 

Diff: https://reviews.apache.org/r/43921/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 43921: HIVE-13120 propagate doAs when generating ORC splits

Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43921/#review120418
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 731)
<https://reviews.apache.org/r/43921/#comment181852>

    Earlier, the FileSystem object used to handle the UGI issues - did we start passing NULL here for some reason?


- Gopal V


On Feb. 24, 2016, 12:12 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43921/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 12:12 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 9b1d7ae 
> 
> Diff: https://reviews.apache.org/r/43921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 43921: HIVE-13120 propagate doAs when generating ORC splits

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43921/#review120417
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 545)
<https://reviews.apache.org/r/43921/#comment181851>

    not needed


- Sergey Shelukhin


On Feb. 24, 2016, 12:12 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43921/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 12:12 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 9b1d7ae 
> 
> Diff: https://reviews.apache.org/r/43921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>