You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/09/28 06:44:27 UTC
[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/754
* [ios] support attributes to set scrollVertical when the scrollView contentSize smaller than the scrollview frame size
* [ios] support attributes to set scrollVertical when the scrollView contentSize smaller than the scrollview frame size
try case : http://dotwe.org/vue/7f349e0545703a3f17d7757e27c80849
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #754
----
commit f40f25f0928cb4053ae86d8c81bd6f47463471f4
Author: acton393 <zh...@gmail.com>
Date: 2017-09-28T04:00:34Z
* [ios] support attributes to set scrollVertical when the scrollView content size is smaller than the scrollview frame size
commit 5eb1cf06d1681d2d58b9d7b664c817ed2bd0a7c4
Author: acton393 <zh...@gmail.com>
Date: 2017-09-28T04:01:05Z
* [ios] cancel useless error log
----
---
[GitHub] incubator-weex issue #754: * [ios] support attributes to set scrollVertical ...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/754
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/754#discussion_r141800529
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebSocketModule.m ---
@@ -126,7 +126,7 @@ - (void)close
- (void)close:(NSString *)code reason:(NSString *)reason
{
- if(!code)
+ if([WXUtility isBlankString:code])
--- End diff --
there is a assert crash when code is empty string but not a nil value
---
[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/754
---
[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/754#discussion_r141799500
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebSocketModule.m ---
@@ -126,7 +126,7 @@ - (void)close
- (void)close:(NSString *)code reason:(NSString *)reason
{
- if(!code)
+ if([WXUtility isBlankString:code])
--- End diff --
if code = nil ,has any question?
---