You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/06 21:10:00 UTC

[jira] [Commented] (GEODE-7647) Remove unused code from GMSJoinLeave.findCoordinator

    [ https://issues.apache.org/jira/browse/GEODE-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009171#comment-17009171 ] 

ASF subversion and git services commented on GEODE-7647:
--------------------------------------------------------

Commit 13362a00bfb2718777d5238109c971e4db561be8 in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=13362a0 ]

GEODE-7647: Removing unused code from GMSJoinLeave 

Removing some code which set the coord and coordIsNoob local variables but
never used them.

> Remove unused code from GMSJoinLeave.findCoordinator
> ----------------------------------------------------
>
>                 Key: GEODE-7647
>                 URL: https://issues.apache.org/jira/browse/GEODE-7647
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is some dead code in this method that computes a couple of local variables that are never used - coord and coordIsNoob
> https://github.com/apache/geode/blob/2178ba8fefcda23d4b2d3b6ecc68b58dd8839f7f/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java#L1223



--
This message was sent by Atlassian Jira
(v8.3.4#803005)