[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load
URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301055605
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/TransactionCommitFailedException.java
 ##########
 @@ -22,6 +22,8 @@
     
     private static final long serialVersionUID = -2528170792631761535L;
 
+    public static final String NO_DATA_TO_LOAD_MSG = "all partitions have no load data";
 
 Review comment:
   You don't need to judge NO_DATA_TO_LOAD_MSG. In my option, all of exceptions need to be catch and record in old user pattern

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org