You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wangsizhu0504 (via GitHub)" <gi...@apache.org> on 2024/01/17 07:20:55 UTC

[PR] [Improve]: App view table column add drag and drop, tag width adaptive [incubator-streampark]

wangsizhu0504 opened a new pull request, #3497:
URL: https://github.com/apache/incubator-streampark/pull/3497

   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   
   1. App view table column add drag and drop
   2. The state fields in the table columns of the app view are of different lengths. We can align them according to the longest character in the list.
   
   <img width="1128" alt="Snipaste_2024-01-17_15-17-13" src="https://github.com/apache/incubator-streampark/assets/39726513/efc85711-9658-4a4d-a445-ad1bdc74f902">
   
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes / no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve]: App view table column add drag and drop, tag width adaptive [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #3497:
URL: https://github.com/apache/incubator-streampark/pull/3497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve]: App view table column add drag and drop, tag width adaptive [incubator-streampark]

Posted by "wangsizhu0504 (via GitHub)" <gi...@apache.org>.
wangsizhu0504 commented on PR #3497:
URL: https://github.com/apache/incubator-streampark/pull/3497#issuecomment-1895330247

   cc @wolfboys ,I have modified some effects in the app page. The final effect can be viewed in the description. Do you have any other suggestions for improvements?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve]: App view table column add drag and drop, tag width adaptive [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #3497:
URL: https://github.com/apache/incubator-streampark/pull/3497#issuecomment-1895390595

   > cc @wolfboys ,I have modified some effects in the app page. The final effect can be viewed in the description. Do you have any other suggestions for improvements?
   
   Great, thanks very much for your contribution. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org