You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/09/11 07:52:50 UTC
[PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Mryange opened a new pull request, #40670:
URL: https://github.com/apache/doris/pull/40670
## Proposed changes
```
mysql [test]>select count(concat(short, "123","121231","123123",'12312313')) from strings;
+-------------------------------------------------------------+
| count(concat(short, '123', '121231', '123123', '12312313')) |
+-------------------------------------------------------------+
| 10000000 |
+-------------------------------------------------------------+
1 row in set (0.52 sec)
mysql [test]>select count(concat(short, "123","121231","123123",'12312313' , short , short, short)) from strings;
+----------------------------------------------------------------------------------+
| count(concat(short, '123', '121231', '123123', '12312313', short, short, short)) |
+----------------------------------------------------------------------------------+
| 10000000 |
+----------------------------------------------------------------------------------+
1 row in set (0.98 sec)
now
mysql [test]>select count(concat(short, "123","121231","123123",'12312313')) from strings;
+-------------------------------------------------------------+
| count(concat(short, '123', '121231', '123123', '12312313')) |
+-------------------------------------------------------------+
| 10000000 |
+-------------------------------------------------------------+
1 row in set (0.19 sec)
mysql [test]>select count(concat(short, "123","121231","123123",'12312313' , short , short, short)) from strings;
+----------------------------------------------------------------------------------+
| count(concat(short, '123', '121231', '123123', '12312313', short, short, short)) |
+----------------------------------------------------------------------------------+
| 10000000 |
+----------------------------------------------------------------------------------+
1 row in set (0.71 sec)
```
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2342916463
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343116753
<details>
<summary>ClickBench: <b>Total hot run time: 31.59 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a0902f5b77867521fac3101e9622542189406a4, data reload: false
query1 0.05 0.04 0.04
query2 0.08 0.04 0.04
query3 0.24 0.05 0.04
query4 1.66 0.07 0.08
query5 0.51 0.51 0.49
query6 1.12 0.73 0.74
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.54 0.50 0.49
query10 0.54 0.56 0.54
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.61 0.58 0.58
query14 1.39 1.43 1.36
query15 0.84 0.82 0.85
query16 0.38 0.37 0.38
query17 1.00 1.08 0.98
query18 0.20 0.20 0.20
query19 1.96 1.76 1.75
query20 0.01 0.01 0.00
query21 15.39 0.67 0.66
query22 4.42 6.32 2.27
query23 18.28 1.32 1.18
query24 2.13 0.23 0.22
query25 0.15 0.09 0.08
query26 0.27 0.17 0.17
query27 0.08 0.08 0.08
query28 13.20 1.03 1.00
query29 12.59 3.38 3.34
query30 0.24 0.05 0.06
query31 2.86 0.41 0.40
query32 3.23 0.48 0.50
query33 2.93 3.00 3.05
query34 17.09 4.48 4.40
query35 4.46 4.49 4.42
query36 0.66 0.47 0.50
query37 0.19 0.16 0.15
query38 0.16 0.14 0.16
query39 0.05 0.04 0.04
query40 0.15 0.13 0.13
query41 0.09 0.05 0.04
query42 0.06 0.05 0.05
query43 0.04 0.04 0.05
Total cold run time: 110.22 s
Total hot run time: 31.59 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #40670:
URL: https://github.com/apache/doris/pull/40670#discussion_r1758093599
##########
be/src/vec/functions/function_string.h:
##########
@@ -1017,6 +1022,34 @@ class FunctionStringConcat : public IFunction {
return std::make_shared<DataTypeString>();
}
+ Status open(FunctionContext* context, FunctionContext::FunctionStateScope scope) override {
+ if (scope == FunctionContext::THREAD_LOCAL) {
+ return Status::OK();
+ }
+ std::shared_ptr<ConcatState> state = std::make_shared<ConcatState>();
+
+ context->set_function_state(scope, state);
+
+ state->use_state = true;
+
+ // Optimize function calls like this:
+ // concat(col, "123", "abc", "456") -> tail = "123abc456"
+ for (size_t i = 1; i < context->get_num_args(); i++) {
+ const auto* column_string = context->get_constant_col(i);
+ if (column_string == nullptr) {
+ state->use_state = false;
+ break;
+ }
+ auto string_vale = column_string->column_ptr->get_data_at(0);
Review Comment:
Check here is NULL const， what happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2348001317
<details>
<summary>ClickBench: <b>Total hot run time: 31.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93c38239824a693451ee9d6b5456c135274cde46, data reload: false
query1 0.05 0.05 0.04
query2 0.07 0.04 0.04
query3 0.22 0.05 0.05
query4 1.66 0.06 0.07
query5 0.53 0.50 0.51
query6 1.13 0.74 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.55 0.52 0.50
query10 0.58 0.58 0.56
query11 0.16 0.12 0.12
query12 0.15 0.13 0.12
query13 0.62 0.61 0.61
query14 1.44 1.52 1.46
query15 0.88 0.86 0.87
query16 0.36 0.36 0.36
query17 0.99 1.03 1.02
query18 0.22 0.20 0.21
query19 1.92 1.81 1.85
query20 0.01 0.02 0.01
query21 15.42 0.67 0.66
query22 3.93 7.71 1.90
query23 18.15 1.24 1.26
query24 2.26 0.24 0.22
query25 0.19 0.08 0.09
query26 0.29 0.18 0.17
query27 0.08 0.08 0.08
query28 13.19 1.15 1.10
query29 12.60 3.38 3.38
query30 0.24 0.06 0.06
query31 2.87 0.42 0.42
query32 3.22 0.49 0.50
query33 3.02 3.07 3.07
query34 15.43 4.30 4.36
query35 4.37 4.31 4.35
query36 0.68 0.49 0.49
query37 0.19 0.16 0.17
query38 0.16 0.14 0.15
query39 0.05 0.04 0.04
query40 0.17 0.13 0.14
query41 0.10 0.05 0.05
query42 0.05 0.06 0.05
query43 0.05 0.04 0.05
Total cold run time: 108.32 s
Total hot run time: 31.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343998925
<details>
<summary>TPC-DS: <b>Total hot run time: 197582 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d72b33eb210a451f4593043dca089394550409c9, data reload: false
query1 1271 869 870 869
query2 6458 1939 1893 1893
query3 10613 4098 4072 4072
query4 59387 24551 23188 23188
query5 5029 499 498 498
query6 403 166 169 166
query7 5617 291 293 291
query8 322 226 221 221
query9 7558 2523 2495 2495
query10 431 285 267 267
query11 16802 15089 15140 15089
query12 150 102 96 96
query13 1510 421 383 383
query14 10756 7387 7478 7387
query15 214 177 178 177
query16 6625 485 481 481
query17 1097 571 551 551
query18 1204 336 309 309
query19 196 162 152 152
query20 115 114 110 110
query21 216 104 103 103
query22 4670 4408 4630 4408
query23 34470 33592 33435 33435
query24 6080 2841 2831 2831
query25 506 406 409 406
query26 598 160 158 158
query27 1571 278 281 278
query28 3828 2049 2036 2036
query29 658 428 434 428
query30 235 153 155 153
query31 925 782 824 782
query32 78 54 56 54
query33 463 294 296 294
query34 887 484 464 464
query35 850 730 739 730
query36 1038 944 932 932
query37 142 91 86 86
query38 4000 3985 3931 3931
query39 1472 1400 1398 1398
query40 200 119 115 115
query41 48 50 46 46
query42 123 96 96 96
query43 520 494 482 482
query44 1091 748 747 747
query45 199 167 169 167
query46 1092 726 763 726
query47 1914 1792 1814 1792
query48 373 302 309 302
query49 784 454 456 454
query50 837 412 422 412
query51 6929 6854 6921 6854
query52 98 89 87 87
query53 253 183 177 177
query54 565 460 466 460
query55 79 78 80 78
query56 320 263 275 263
query57 1221 1094 1090 1090
query58 244 237 245 237
query59 2986 2794 3028 2794
query60 296 269 274 269
query61 109 102 99 99
query62 770 645 661 645
query63 212 190 184 184
query64 1348 687 703 687
query65 3212 3159 3169 3159
query66 657 340 343 340
query67 15844 15229 15111 15111
query68 1721 846 834 834
query69 420 320 326 320
query70 1214 1107 1197 1107
query71 350 337 339 337
query72 4621 3678 3398 3398
query73 593 568 574 568
query74 8953 9010 8907 8907
query75 3073 2946 2923 2923
query76 996 848 834 834
query77 495 408 398 398
query78 9878 9267 10078 9267
query79 904 868 897 868
query80 813 809 810 809
query81 444 264 254 254
query82 264 266 266 266
query83 192 192 191 191
query84 203 106 104 104
query85 613 402 395 395
query86 320 291 322 291
query87 4312 4395 4382 4382
query88 4344 4079 4069 4069
query89 369 362 367 362
query90 1305 308 303 303
query91 122 123 122 122
query92 76 73 74 73
query93 911 949 912 912
query94 433 360 375 360
query95 415 418 414 414
query96 468 468 469 468
query97 3069 3074 3115 3074
query98 224 231 230 230
query99 1294 1283 1267 1267
Total cold run time: 294178 ms
Total hot run time: 197582 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2347996999
<details>
<summary>TPC-DS: <b>Total hot run time: 194930 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93c38239824a693451ee9d6b5456c135274cde46, data reload: false
query1 907 388 385 385
query2 6541 1768 1742 1742
query3 6662 208 217 208
query4 26639 24057 24003 24003
query5 5168 551 541 541
query6 271 182 173 173
query7 4590 299 312 299
query8 293 222 221 221
query9 8473 2586 2577 2577
query10 464 277 276 276
query11 16309 15542 15517 15517
query12 167 104 98 98
query13 1705 399 385 385
query14 11077 7113 6687 6687
query15 208 179 172 172
query16 6879 465 446 446
query17 1525 578 574 574
query18 1817 297 292 292
query19 197 152 154 152
query20 122 113 114 113
query21 214 106 106 106
query22 4523 4226 4130 4130
query23 34283 33921 33810 33810
query24 10533 3167 3033 3033
query25 706 411 424 411
query26 1510 159 159 159
query27 2748 285 292 285
query28 6592 2088 2084 2084
query29 1000 432 445 432
query30 309 162 153 153
query31 980 756 784 756
query32 110 57 61 57
query33 754 312 304 304
query34 906 480 495 480
query35 866 749 767 749
query36 1088 900 910 900
query37 159 85 95 85
query38 4105 3997 3957 3957
query39 1444 1420 1434 1420
query40 299 119 117 117
query41 50 51 48 48
query42 122 100 99 99
query43 487 444 436 436
query44 1250 808 783 783
query45 200 171 178 171
query46 1115 845 839 839
query47 1902 1765 1808 1765
query48 374 303 293 293
query49 1209 462 452 452
query50 918 442 451 442
query51 7029 7059 6997 6997
query52 100 90 88 88
query53 261 188 186 186
query54 847 473 469 469
query55 80 78 80 78
query56 314 276 280 276
query57 1191 1094 1041 1041
query58 357 245 245 245
query59 2731 2605 2607 2605
query60 289 278 279 278
query61 121 106 106 106
query62 907 691 672 672
query63 216 190 192 190
query64 5222 697 649 649
query65 3240 3169 3149 3149
query66 1411 295 298 295
query67 15651 15272 15563 15272
query68 3441 864 876 864
query69 425 328 327 327
query70 1195 1140 1117 1117
query71 350 347 341 341
query72 5896 3466 3345 3345
query73 602 585 580 580
query74 9267 9177 9201 9177
query75 3146 2989 3019 2989
query76 1935 834 840 834
query77 443 403 399 399
query78 9372 9278 9255 9255
query79 901 884 863 863
query80 833 882 819 819
query81 459 265 272 265
query82 271 261 258 258
query83 196 193 187 187
query84 232 107 106 106
query85 660 401 429 401
query86 320 310 313 310
query87 4380 4327 4429 4327
query88 4221 4149 4133 4133
query89 374 360 372 360
query90 1342 320 317 317
query91 124 126 120 120
query92 78 75 74 74
query93 1015 1026 1017 1017
query94 581 395 361 361
query95 464 423 422 422
query96 473 473 473 473
query97 3121 3169 3146 3146
query98 227 222 221 221
query99 1550 1309 1316 1309
Total cold run time: 278631 ms
Total hot run time: 194930 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #40670:
URL: https://github.com/apache/doris/pull/40670#discussion_r1758092346
##########
be/src/vec/functions/function_string.h:
##########
@@ -1017,6 +1022,34 @@ class FunctionStringConcat : public IFunction {
return std::make_shared<DataTypeString>();
}
+ Status open(FunctionContext* context, FunctionContext::FunctionStateScope scope) override {
+ if (scope == FunctionContext::THREAD_LOCAL) {
+ return Status::OK();
+ }
+ std::shared_ptr<ConcatState> state = std::make_shared<ConcatState>();
+
+ context->set_function_state(scope, state);
+
+ state->use_state = true;
+
+ // Optimize function calls like this:
+ // concat(col, "123", "abc", "456") -> tail = "123abc456"
+ for (size_t i = 1; i < context->get_num_args(); i++) {
+ const auto* column_string = context->get_constant_col(i);
+ if (column_string == nullptr) {
+ state->use_state = false;
+ break;
+ }
+ auto string_vale = column_string->column_ptr->get_data_at(0);
Review Comment:
logic error， if here is NULL， result is ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2347982047
TeamCity be ut coverage result:
Function Coverage: 36.90% (9466/25652)
Line Coverage: 28.26% (77858/275465)
Region Coverage: 27.68% (40217/145303)
Branch Coverage: 24.28% (20429/84152)
Coverage Report: http://coverage.selectdb-in.cc/coverage/93c38239824a693451ee9d6b5456c135274cde46_93c38239824a693451ee9d6b5456c135274cde46/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2348008823
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #40670:
URL: https://github.com/apache/doris/pull/40670#discussion_r1758092346
##########
be/src/vec/functions/function_string.h:
##########
@@ -1017,6 +1022,34 @@ class FunctionStringConcat : public IFunction {
return std::make_shared<DataTypeString>();
}
+ Status open(FunctionContext* context, FunctionContext::FunctionStateScope scope) override {
+ if (scope == FunctionContext::THREAD_LOCAL) {
+ return Status::OK();
+ }
+ std::shared_ptr<ConcatState> state = std::make_shared<ConcatState>();
+
+ context->set_function_state(scope, state);
+
+ state->use_state = true;
+
+ // Optimize function calls like this:
+ // concat(col, "123", "abc", "456") -> tail = "123abc456"
+ for (size_t i = 1; i < context->get_num_args(); i++) {
+ const auto* column_string = context->get_constant_col(i);
+ if (column_string == nullptr) {
+ state->use_state = false;
+ break;
+ }
+ auto string_vale = column_string->column_ptr->get_data_at(0);
Review Comment:
logic error， if here is NULL， result is ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2350795913
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343105299
<details>
<summary>TPC-DS: <b>Total hot run time: 197429 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a0902f5b77867521fac3101e9622542189406a4, data reload: false
query1 1238 895 874 874
query2 6346 1884 1862 1862
query3 10611 4002 3986 3986
query4 59715 27251 23141 23141
query5 5040 496 503 496
query6 392 171 181 171
query7 5631 300 285 285
query8 309 216 220 216
query9 7649 2514 2495 2495
query10 404 261 259 259
query11 15679 14997 15356 14997
query12 155 107 102 102
query13 1435 392 379 379
query14 10659 7478 7353 7353
query15 213 170 172 170
query16 6741 470 471 470
query17 1059 564 560 560
query18 1491 299 315 299
query19 200 148 146 146
query20 125 109 111 109
query21 206 107 104 104
query22 4770 4819 4829 4819
query23 34511 33699 33440 33440
query24 5962 2896 2849 2849
query25 483 392 395 392
query26 600 150 151 150
query27 1606 274 271 271
query28 3792 2061 2048 2048
query29 646 411 409 409
query30 236 150 154 150
query31 923 752 793 752
query32 71 55 57 55
query33 463 310 289 289
query34 887 475 479 475
query35 839 721 712 712
query36 1085 916 942 916
query37 143 95 83 83
query38 4015 3877 3846 3846
query39 1450 1416 1397 1397
query40 201 112 112 112
query41 46 46 44 44
query42 114 94 95 94
query43 496 463 454 454
query44 1109 750 739 739
query45 196 164 166 164
query46 1090 730 736 730
query47 1934 1807 1841 1807
query48 365 289 298 289
query49 771 430 439 430
query50 827 405 416 405
query51 6977 6882 6881 6881
query52 99 86 85 85
query53 254 177 178 177
query54 565 453 447 447
query55 79 76 74 74
query56 317 251 252 251
query57 1219 1075 1085 1075
query58 218 225 226 225
query59 2956 2857 2883 2857
query60 301 271 270 270
query61 103 99 100 99
query62 750 649 666 649
query63 215 187 190 187
query64 1346 698 669 669
query65 3208 3157 3208 3157
query66 675 331 335 331
query67 15778 15368 15445 15368
query68 1458 846 835 835
query69 417 313 323 313
query70 1191 1173 1159 1159
query71 350 340 336 336
query72 4538 3661 3416 3416
query73 584 572 580 572
query74 8985 8847 8863 8847
query75 3033 2909 2927 2909
query76 899 838 842 838
query77 410 392 400 392
query78 9425 9206 9287 9206
query79 901 885 852 852
query80 788 877 781 781
query81 451 257 265 257
query82 263 254 261 254
query83 193 184 187 184
query84 194 104 107 104
query85 591 389 378 378
query86 330 310 299 299
query87 4305 4297 4342 4297
query88 4207 3997 3994 3994
query89 373 356 362 356
query90 807 306 303 303
query91 122 119 120 119
query92 77 75 77 75
query93 916 900 904 900
query94 400 356 371 356
query95 412 407 404 404
query96 463 466 463 463
query97 3114 3121 3180 3121
query98 230 230 225 225
query99 1383 1299 1287 1287
Total cold run time: 291799 ms
Total hot run time: 197429 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343916743
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343968740
<details>
<summary>TPC-H: <b>Total hot run time: 38450 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d72b33eb210a451f4593043dca089394550409c9, data reload: false
------ Round 1 ----------------------------------
q1 17961 4612 4319 4319
q2 2027 193 194 193
q3 11773 949 1176 949
q4 10511 758 691 691
q5 7762 2841 2863 2841
q6 230 141 140 140
q7 978 609 611 609
q8 9336 2090 2072 2072
q9 7182 6584 6587 6584
q10 7016 2223 2231 2223
q11 455 250 249 249
q12 406 219 227 219
q13 17761 3084 3090 3084
q14 291 240 240 240
q15 540 490 484 484
q16 540 437 429 429
q17 999 662 678 662
q18 7513 7086 6981 6981
q19 1389 1104 1075 1075
q20 666 326 355 326
q21 4062 3061 3216 3061
q22 1084 1026 1019 1019
Total cold run time: 110482 ms
Total hot run time: 38450 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4430 4426 4364 4364
q2 388 266 281 266
q3 2945 2743 2749 2743
q4 1998 1746 1691 1691
q5 5725 5814 5843 5814
q6 227 135 144 135
q7 2259 1857 1825 1825
q8 3311 3460 3517 3460
q9 8870 8856 8915 8856
q10 3607 3532 3418 3418
q11 620 516 506 506
q12 842 661 669 661
q13 14526 3313 3346 3313
q14 317 289 286 286
q15 549 493 481 481
q16 548 503 500 500
q17 1863 1566 1586 1566
q18 8325 7891 8057 7891
q19 1774 1534 1701 1534
q20 2227 1958 1954 1954
q21 5971 5672 5362 5362
q22 1126 1032 1080 1032
Total cold run time: 72448 ms
Total hot run time: 57658 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2342916513
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #40670:
URL: https://github.com/apache/doris/pull/40670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343214220
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2344011653
<details>
<summary>ClickBench: <b>Total hot run time: 31.19 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d72b33eb210a451f4593043dca089394550409c9, data reload: false
query1 0.05 0.05 0.04
query2 0.08 0.04 0.04
query3 0.23 0.06 0.05
query4 1.67 0.07 0.07
query5 0.51 0.50 0.50
query6 1.12 0.73 0.74
query7 0.02 0.01 0.01
query8 0.05 0.04 0.04
query9 0.55 0.48 0.49
query10 0.56 0.56 0.56
query11 0.15 0.11 0.12
query12 0.16 0.13 0.12
query13 0.61 0.59 0.58
query14 1.40 1.41 1.42
query15 0.85 0.81 0.86
query16 0.38 0.38 0.38
query17 1.06 0.99 1.06
query18 0.17 0.18 0.17
query19 1.84 1.81 1.74
query20 0.01 0.01 0.01
query21 15.39 0.66 0.65
query22 3.87 7.64 1.84
query23 18.30 1.41 1.22
query24 2.11 0.23 0.23
query25 0.15 0.09 0.08
query26 0.28 0.18 0.18
query27 0.07 0.08 0.07
query28 13.22 1.01 0.99
query29 12.56 3.34 3.30
query30 0.24 0.07 0.05
query31 2.84 0.38 0.40
query32 3.30 0.47 0.47
query33 2.98 3.02 2.98
query34 16.97 4.42 4.45
query35 4.57 4.49 4.43
query36 0.66 0.48 0.50
query37 0.19 0.16 0.14
query38 0.16 0.15 0.15
query39 0.04 0.03 0.04
query40 0.15 0.13 0.12
query41 0.10 0.05 0.05
query42 0.06 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.73 s
Total hot run time: 31.19 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343317497
TeamCity be ut coverage result:
Function Coverage: 36.91% (9459/25627)
Line Coverage: 28.28% (77843/275303)
Region Coverage: 27.66% (40151/145182)
Branch Coverage: 24.27% (20402/84062)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d72b33eb210a451f4593043dca089394550409c9_d72b33eb210a451f4593043dca089394550409c9/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2350795934
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343277753
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2343073973
<details>
<summary>TPC-H: <b>Total hot run time: 38259 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a0902f5b77867521fac3101e9622542189406a4, data reload: false
------ Round 1 ----------------------------------
q1 18521 4683 4392 4392
q2 2032 194 195 194
q3 11727 948 1121 948
q4 10360 746 766 746
q5 7752 2900 2818 2818
q6 226 137 135 135
q7 951 623 606 606
q8 9316 2109 2119 2109
q9 7288 6588 6543 6543
q10 7003 2282 2182 2182
q11 452 250 239 239
q12 394 222 225 222
q13 17770 3083 3065 3065
q14 278 244 247 244
q15 553 497 487 487
q16 528 428 414 414
q17 999 736 707 707
q18 7617 6925 6839 6839
q19 1396 1056 1016 1016
q20 687 335 324 324
q21 3951 3092 3013 3013
q22 1103 1016 1033 1016
Total cold run time: 110904 ms
Total hot run time: 38259 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4405 4342 4328 4328
q2 389 268 268 268
q3 2869 2662 2693 2662
q4 1968 1665 1664 1664
q5 5716 5742 5811 5742
q6 236 137 133 133
q7 2203 1868 1880 1868
q8 3319 3496 3516 3496
q9 8879 8858 8863 8858
q10 3656 3367 3416 3367
q11 596 522 507 507
q12 822 628 627 627
q13 15552 3172 3290 3172
q14 346 308 277 277
q15 566 512 493 493
q16 554 513 498 498
q17 1857 1538 1564 1538
q18 8280 7807 7962 7807
q19 1764 1649 1524 1524
q20 2164 1923 1935 1923
q21 5721 5554 5574 5554
q22 1112 1027 1031 1027
Total cold run time: 72974 ms
Total hot run time: 57333 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2347962153
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](function) Optimize the concat(col, constant, constant, constant) function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40670:
URL: https://github.com/apache/doris/pull/40670#issuecomment-2347987211
<details>
<summary>TPC-H: <b>Total hot run time: 43214 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93c38239824a693451ee9d6b5456c135274cde46, data reload: false
------ Round 1 ----------------------------------
q1 18075 7338 7274 7274
q2 2707 194 191 191
q3 11009 1424 1398 1398
q4 10303 984 1079 984
q5 7756 3244 3185 3185
q6 248 160 162 160
q7 1053 671 654 654
q8 9538 2037 2007 2007
q9 6773 6321 6285 6285
q10 7030 2526 2508 2508
q11 432 254 265 254
q12 408 228 231 228
q13 17758 3045 3041 3041
q14 295 241 256 241
q15 585 527 519 519
q16 514 422 424 422
q17 995 958 952 952
q18 7585 6872 6900 6872
q19 1370 1223 1239 1223
q20 612 331 335 331
q21 3886 3520 3555 3520
q22 1082 965 1012 965
Total cold run time: 110014 ms
Total hot run time: 43214 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7278 7187 7187 7187
q2 342 235 235 235
q3 2919 2906 2877 2877
q4 1980 1959 1992 1959
q5 5425 5418 5432 5418
q6 233 146 148 146
q7 2053 1694 1676 1676
q8 3230 3305 3355 3305
q9 8429 8412 8449 8412
q10 3401 3435 3447 3435
q11 575 464 470 464
q12 781 571 560 560
q13 4973 3033 3035 3033
q14 295 279 292 279
q15 573 533 515 515
q16 492 435 439 435
q17 1756 1705 1705 1705
q18 8115 7561 7455 7455
q19 1720 1699 1700 1699
q20 2057 1785 1823 1785
q21 5680 5425 5338 5338
q22 1119 1010 1011 1010
Total cold run time: 63426 ms
Total hot run time: 58928 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org