[GitHub] [airflow] ashb commented on a change in pull request #5868: AIRFLOW-5262 Update timeout exception

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5868: AIRFLOW-5262 Update timeout exception
URL: https://github.com/apache/airflow/pull/5868#discussion_r316166981
 
 

 ##########
 File path: airflow/sensors/base_sensor_operator.py
 ##########
 @@ -111,9 +111,13 @@ def execute(self, context):
                 # This gives the ability to set up non-blocking AND soft-fail sensors.
                 if self.soft_fail and not context['ti'].is_eligible_to_retry():
                     self._do_skip_downstream_tasks(context)
-                    raise AirflowSkipException('Snap. Time is OUT.')
+                    raise AirflowSkipException(
+                        "Snap. Time is OUT for dag: {dag}"
+                        .format(dag=self.dag.dag_id if self.dag else ""))
 
 Review comment:
   It should be impossible to run a task without a dag, so the conditional you have here isn't needed. (Or _shouldn't_ be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services