You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2017/08/21 23:24:23 UTC
[Impala-ASF-CR] Fix string format() syntax to in test scanners fuzz.py
David Knupp has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7761
Change subject: Fix string format() syntax to in test_scanners_fuzz.py
......................................................................
Fix string format() syntax to in test_scanners_fuzz.py
Make the call to format() compatible with older versions of python
(< 2.7), which expect an indices in the string being formatted,
e.g. "{0} {1} {2}".format('foo', 'bar', 'baz'). Without the numbers,
format() raises an exception.
Tested by running this test suite using python 2.6.6. Before the
patch, the tests failed. After the patch, they pass.
Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7761/2
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1113/
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
Make the call to format() compatible with older versions of python
(< 2.7), which expect an indices in the string being formatted,
e.g. "{0} {1} {2}".format('foo', 'bar', 'baz'). Without the numbers,
format() raises an exception.
Tested by running this test suite using python 2.6.6. Before the
patch, the tests failed. After the patch, they pass.
Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Reviewed-on: http://gerrit.cloudera.org:8080/7761
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
David Knupp: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 4:
I was stupid. I specifically tested my patch against the RELEASE build, which didn't need Tim's dcheck fix for IMPALA-5819. However, when this change was tested upstream, it ran against a DEBUG build, and without Tim's change, it failed.
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1113/
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has uploaded a new patch set (#3).
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
Make the call to format() compatible with older versions of python
(< 2.7), which expect an indices in the string being formatted,
e.g. "{0} {1} {2}".format('foo', 'bar', 'baz'). Without the numbers,
format() raises an exception.
Tested by running this test suite using python 2.6.6. Before the
patch, the tests failed. After the patch, they pass.
Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7761/3
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has uploaded a new patch set (#3).
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
Make the call to format() compatible with older versions of python
(< 2.7), which expect an indices in the string being formatted,
e.g. "{0} {1} {2}".format('foo', 'bar', 'baz'). Without the numbers,
format() raises an exception.
Tested by running this test suite using python 2.6.6. Before the
patch, the tests failed. After the patch, they pass.
Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7761/3
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 4: Code-Review+2
Rebase only, carrying +2.
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1118/
--
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No