[GitHub] [cassandra] dcapwell commented on pull request #704: Cassandra 15991

[GitBox <gi...@apache.org>]

dcapwell commented on pull request #704:
URL: https://github.com/apache/cassandra/pull/704#issuecomment-684009699


   Started but this patch is very large so will take a while to review.
   
   General comments are:
   * avoid using assertTrue/assertFalse as they produce bad errors (unless you control the errors)
   * prefer Assertions.assertThat as it produces useful error messages
   * when validating that the usage hasn't changed, should use the string usage rather than a hash of it, as the hash is harder to know what failed and how to resolve.
   * `WARNING: An illegal reflective access operation has occurred` is a bug, so we should fix this rather than add exclusions to the test.
   * when working with List you already have a forEach method, so no need to create a stream


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org