You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "yifan-c (via GitHub)" <gi...@apache.org> on 2025/07/30 22:38:19 UTC
[PR] CASSANALYTICS-81: Unique restoreJobId per write target [cassandra-analytics]
yifan-c opened a new pull request, #134:
URL: https://github.com/apache/cassandra-analytics/pull/134
Patch by Yifan Cai; Reviewed by TBD for CASSANALYTICS-81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-81: Unique restoreJobId per write target [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #134:
URL: https://github.com/apache/cassandra-analytics/pull/134#discussion_r2246398393
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraJobInfo.java:
##########
@@ -19,24 +19,29 @@
package org.apache.cassandra.spark.bulkwriter;
+import java.util.NoSuchElementException;
import java.util.UUID;
import org.apache.cassandra.spark.bulkwriter.cloudstorage.coordinated.CoordinatedWriteConf;
+import org.apache.cassandra.spark.bulkwriter.cloudstorage.coordinated.MultiClusterContainer;
import org.apache.cassandra.spark.bulkwriter.token.ConsistencyLevel;
import org.apache.cassandra.spark.data.QualifiedTableName;
+import org.apache.cassandra.spark.utils.Preconditions;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
public class CassandraJobInfo implements JobInfo
{
private static final long serialVersionUID = 6140098484732683759L;
protected final BulkSparkConf conf;
- protected final UUID restoreJobId;
+ // restoreJobId per cluster; it is guranteed to be non-empty
Review Comment:
```suggestion
// restoreJobId per cluster; it is guaranteed to be non-empty
```
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/cloudstorage/coordinated/MultiClusterContainerTest.java:
##########
@@ -189,6 +193,45 @@ void testForEach()
});
}
+ @Test
+ void testSerializationAndDeserializationWithSingleClusterContainer() throws IOException, ClassNotFoundException
+ {
+ UUID expectedJobId = UUID.randomUUID();
+ MultiClusterContainer<UUID> container = MultiClusterContainer.ofSingle(expectedJobId);
+
+ byte[] serailized = SerializationUtils.serialize(container);
Review Comment:
```suggestion
byte[] serialized = SerializationUtils.serialize(container);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-81: Unique restoreJobId per write target [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on PR #134:
URL: https://github.com/apache/cassandra-analytics/pull/134#issuecomment-3138029296
Used Claude to generated the unit test; reviewed and modified by me before pushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-81: Unique restoreJobId per write target [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c merged PR #134:
URL: https://github.com/apache/cassandra-analytics/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org