[GitHub] [flink] echauchot commented on a diff in pull request #19680: [FLINK-27457] Implement flush() logic in Cassandra output formats

[GitBox <gi...@apache.org>]

echauchot commented on code in PR #19680:
URL: https://github.com/apache/flink/pull/19680#discussion_r886474742


##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormatBaseTest.java:
##########
@@ -202,9 +202,12 @@ public void testReleaseOnFailure() throws Exception {
 
             assertThat(testCassandraOutputFormat.getAvailablePermits()).isEqualTo(1);
             assertThat(testCassandraOutputFormat.getAcquiredPermits()).isEqualTo(0);
+        try {
+            testCassandraOutputFormat.close();
         } catch (IOException ignored) {

Review Comment:
   I did that because the aim of the test is to assert on semaphore count and not on exception as I wrote in the comment in the code. But if you think it is not misleading to assert on the exception, then fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org