[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3671: [Enhancement] Do some code optimization[GoodbyeTask] #3462

["Alonexc (via GitHub)" <gi...@apache.org>]

Alonexc commented on code in PR #3671:
URL: https://github.com/apache/eventmesh/pull/3671#discussion_r1161367818


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/GoodbyeTask.java:
##########
@@ -58,13 +58,10 @@ public void run() {
             msg.setHeader(new Header(CLIENT_GOODBYE_RESPONSE, OPStatus.FAIL.getCode(), Arrays.toString(e.getStackTrace()),
                 pkg.getHeader().getSeq()));
         } finally {
-            this.eventMeshTCPServer.getScheduler().submit(new Runnable() {
+            this.eventMeshTCPServer.getScheduler().submit(() -> {

Review Comment:
   It should be modified like this：
   this.eventMeshTCPServer.getScheduler().submit(() -> Utils.writeAndFlush(msg, startTime, taskExecuteTime, session.getContext(), session));



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org