You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/11 04:37:28 UTC
[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #118:
Fix parallel buid errors in examples/elf
masayuki2009 opened a new pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118
### Summary
- This PR fixes build errors in examples/elf in parallel build.
- I applied the same logic in examples/posix_spawn/Makefile which adds an explicit context:: target.
- Also, I modified tests/Makefile to avoid compiling incomplete symtab.c
### Impact
- This PR affects examples/elf only.
### Testing
- I tested this PR for maix-bit:elf configuration with -j1 to -j24 options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599004057
@liuguo09
>nuttx-parallel-build-oneshot in asf setup temporarily by xiang,
>tried many times to reproduce, but it hasn't reproduced yet. You may use it to test.
Thanks, I'll try it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598619702
The above steps may be hard for you to test : (
If so, I'll see if I could get the full build log firstly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598059756
According to the PR merge time, the recent nightly build doesn't include it. So let's wait the next build result. I'll update cibuild.sh to git log the last commit anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598645542
@liuguo09
> If so, I'll see if I could get the full build log firstly.
I found that we need to change nuttx/tools/testbuild.sh so that it can save build logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600391747
Hi, @xiaoxiang781216 @liuguo09
I've just reproduced link errors with my parallel build aging script.
https://builds.apache.org/job/nuttx-parallel-build-oneshot/35/consoleText
Can I login to the build machine (H43) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #118:
Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598038736
Hi, @xiaoxiang781216
>it seems that this build break relate to this change:
Oh, really? But I thought this PR was merged after the nightly build started.
Actually, I can not see the change in the following log.
```
https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
59 files changed, 689 insertions(+), 999 deletions(-)
+ '[' -d /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps ']'
+ cd /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps
+ git pull
Already up to date.
```
Is my understanding correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600946857
@liuguo09
> You should firstly revert your 'mv symtab.c_tmp symtab.c' for example/elf
> since it would reduce the build break possibility. After revert, I reproduce it locally.
Yes, that's why I pushed the commit and finally merged.
As you can see, there still have the same link errors for maix-bit:elf in the nightly build but I can not reproduce it with my parallel build aging test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-597482002
Hi, @xiaoxiang781216,
I hope this PR fixes nightly build errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598614646
Hi, @masayuki2009 ,
You could modify the apache nuttx nightly build Configuration 'Build ->Execute shell' to test:
Just as below, update to use your own fork testing repo, and update your cibuild.sh and testlist with only the elf config built. Then save the configuration. Return back and click on the left 'Build now' button. If do not want email to nuttx devlist in your testing, you should also update the email setting in Configuration.
_if [ -d testing ]; then
rm -rf testing
fi
git clone https://github.com/apache/incubator-nuttx-testing testing
cd testing
./cibuild.sh -i -s ./testlist/full.dat_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull
request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392831232
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
@xiaoxiang781216 This change was needed to fix such as
```
riscv64-unknown-elf-ld: pthread.o: file not recognized: file truncated
Makefile:82: recipe for target 'pthread' failed
make[4]: *** [pthread] Error 1
```
Actually there was a similar error in
https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-601149071
Hi @liuguo09,
> I use the paralle-oneshot nuttx build for some test. Please know it. Thanks
No problem, thanks for letting me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599000637
You could update your testing accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #118:
Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598038736
Hi, @xiaoxiang781216
>it seems that this build break relate to this change:
Oh, really? But I thought this PR was merged after the nightly build started.
Actually, I can not see the change in the following log.
https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
59 files changed, 689 insertions(+), 999 deletions(-)
+ '[' -d /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps ']'
+ cd /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps
+ git pull
Already up to date.
Is my understanding correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392838774
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
I think this error is because:
tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
@$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV)
equals to:
tests/symtab.c:
@$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV)
tests/dirlist.h:
@$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV)
$(FSIMG_HDR):
@$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV)
And tests folder build multiple time concurrently. Is the right fix like this?
common:
@$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV)
tests/symtab.c tests/dirlist.h $(FSIMG_HDR): common
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392825862
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
@masayuki2009 why we change the target to context here? What problem can be fixed by this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599291405
@liuguo09 @xiaoxiang781216
Thanks for the comments, as I commented to #120, let's merge the PR #120.
However, we will need to find another root cause of link errors in the nightly build.
To find the root cause, I'd like to propose to remove both nuttx and apps repos as well in the nightly build configuration just like testing repo. Because we can not know previous states of the repos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-601553181
> @masayuki2009 @xiaoxiang781216 Please help to review #127. I think it is the root cause of elf/posix_spawn/module parallel build breaks. But still need verfiy. l am doing full nightly build in nuttx-oneshot-parallel build now.
Can you reproduce the same error by adding sleep in mksymtab.sh ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600733943
@masayuki2019 I guess it would be hard to login the apache build machine : (
I also repoduced locally by manually adding 'sleep 1' into mksymtab.sh in the current code base. From the build log, I think the link error is because of posix_spawn are built twice by pass1 and pass2 context build. In which the symtab.c produced by mksymtab.sh twice, so it may be rewrited and compiled at the meantime. And finally result in symtab.o not correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857
@masayuki2009 it seems that this build break relate to this change.
====================================================================================
Configuration/Tool: spresense/elf,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Refreshing...
Building NuttX...
------------------------------------------------------------------------------------
arm-none-eabi-ld: hello++2.o: file not recognized: file truncated
make[4]: *** [hello++2] Error 1
make[4]: Target 'all' not remade because of errors.
make[3]: *** [helloxx_build] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [tests/symtab.c] Error 2
make[2]: Target 'all' not remade because of errors.
make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [../apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599055983
@liuguo09
>I don't think #120 PR was effective. Because the latest nightly build still failed.
I mean that the latest nightly build still has link errors in maix-bit:elf although I applied mv operation to symtab.c. However, I still can not reproduce the same errors with nuttx-parallel-build-oneshot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull
request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392861367
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
Hi, @xiaoxiang781216
>And tests folder build multiple time concurrently. Is the right fix like this?
Hmm, I'm still not sure. Can you create another PR so that we can try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598054266
> Hi, @xiaoxiang781216
>
> > it seems that this build break relate to this change:
>
> Oh, really? But I thought this PR was merged after the nightly build started.
> Actually, I can not see the change in the following log.
>
> https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
>
> 59 files changed, 689 insertions(+), 999 deletions(-)
>
> * '[' -d /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps ']'
> * cd /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps
> * git pull
> Already up to date.
>
Not sure, we need upate cibuild.sh to print the last commit.
> Is my understanding correct?
But the similiar issue, Haitao fix before:
commit 2f23d2a60284737c61539258f07964e2e77db0ef
Author: liuguo09 <li...@xiaomi.com>
Date: Tue Feb 25 20:26:51 2020 +0800
examples/elf/tests: Correct symtab.c dependency to fix parallel build break
Correct symtab dependency from build to populate instead, or tests
subdirectory programs would be built twice which resulted in errors
as below:
arm-none-eabi-ld: hello++3.o: file not recognized: file truncated
@yamt and @liuguo09 modify examples/elf recently to fix the various parallel build issue. We need review these change again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598038736
Hi, @xiaoxiang781216
>it seems that this build break relate to this change:
Oh, really? But I thought this PR was merged after the nightly build started.
Actually, I can not see the change in the following log.
https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
Is my understanding correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-601132496
@masayuki2009 I use the paralle-oneshot nuttx build for some test. Please know it. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392884849
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
here: https://github.com/apache/incubator-nuttx-apps/pull/123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #118:
Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598558150
Umm, unfortunately it still fails.
https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText
```
Configuration/Tool: maix-bit/elf,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function `elf_main':
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599024347
@liuguo09 @xiaoxiang781216
>nuttx-parallel-build-oneshot in asf setup temporarily by xiang,
>tried many times to reproduce, but it hasn't reproduced yet. You may use it to test.
I tried both without build logs (same as nightly build) and with build logs, I can not reproduce linker errors so far. Perhaps, it depends on the machine load.
However, I noticed that @xiaoxiang781216 was able to reproduced the error at
https://builds.apache.org/job/nuttx-parallel-build-oneshot/10/consoleText
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-601153743
@masayuki2009 @xiaoxiang781216 Please help to review https://github.com/apache/incubator-nuttx-apps/pull/127. I think it is the root cause of elf/posix_spawn/module parallel build breaks. But still need verfiy. l am doing full nightly build in nuttx-oneshot-parallel build now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599000562
@masayuki2009
nuttx-parallel-build-oneshot in asf setup temporarily by xiang, tried many times to reproduce, but it hasn't reproduced yet. You may use it to test.
By the way, my testing cibuild.sh and full testlist commit here:
https://github.com/liuguo09/incubator-nuttx-testing/commit/3a2b79e24f049edb8ea656577c8288647b2cc595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #118:
Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598558150
Umm, unfortunately it still fails.
https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText
Configuration/Tool: maix-bit/elf,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function `elf_main':
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599151608
You are right. It seems the mv operation to symtab.c reduces the probability of build break(from my local build, it is easy to hit the link error without mv operation), but it doesn't root cause the link errors in the latest nightly build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull
request #118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#discussion_r392831232
##########
File path: examples/elf/Makefile
##########
@@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests
VPATH += :tests
-ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y)
- FSIMG_HDR = $(TESTS_DIR)/romfs.h
-else
- FSIMG_HDR = $(TESTS_DIR)/cromfs.h
-endif
-
-elf_main.c: tests/symtab.c
-
-tests/symtab.c tests/dirlist.h $(FSIMG_HDR):
Review comment:
@xiaoxiang781216 This change was needed to fix such as
riscv64-unknown-elf-ld: pthread.o: file not recognized: file truncated
Makefile:82: recipe for target 'pthread' failed
make[4]: *** [pthread] Error 1
Actually there was a similar error in
https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598587936
Hi, @liuguo09
>Umm, unfortunately it still fails.
>https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText
Can we get complete build logs when build errors happened?
Because I can not reproduce the same link errors.
Also, can we manually trigger the build system with a specific configuration? (e.g. maix-bit:elf or lc823450-xgevk/posix_spawn)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599053040
@masayuki2009
In the 10th build log, I think it was because of build without https://github.com/apache/incubator-nuttx-apps/pull/120 PR. while in the following builds, I add the change.
As you said, the machine load may be reasonable. I wonder if there is chance that the 'mv symtab.c_tmp symtab.c' wasn't atomic and wasn't flushed in time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598067493
Hi, @liuguo09
>According to the PR merge time, the recent nightly build doesn't include it.
>So let's wait the next build result.
>I'll update cibuild.sh to git log the last commit anyway.
Thanks for the comments. I understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600945159
You should firstly revert your 'mv symtab.c_tmp symtab.c' for example/elf since it would reduce the build break possibility. After revert, I reproduce it locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue
#118: Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857
@masayuki2009 it seems that this build break relate to this change:
```
====================================================================================
Configuration/Tool: spresense/elf,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Refreshing...
Building NuttX...
------------------------------------------------------------------------------------
arm-none-eabi-ld: hello++2.o: file not recognized: file truncated
make[4]: *** [hello++2] Error 1
make[4]: Target 'all' not remade because of errors.
make[3]: *** [helloxx_build] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [tests/symtab.c] Error 2
make[2]: Target 'all' not remade because of errors.
make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [../apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598635302
@liuguo09
>The above steps may be hard for you to test : (
Perhaps, I understand how to configure the job but should I change the configuration for the test?
Because the job is used for NuttX-Nightly-Build, so it might be not good for the test.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #118:
Fix parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598558150
Umm, unfortunately it still fails.
https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText
====================================================================================
Configuration/Tool: maix-bit/elf,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_RV64GC_TOOLCHAIN_GNU_RVGL
Enabling CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
Refreshing...
Building NuttX...
------------------------------------------------------------------------------------
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function `elf_main':
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599053403
How about merge https://github.com/apache/incubator-nuttx-apps/pull/120 PR firstly? I think your mv operation is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600904711
Hi, @liuguo09
> I guess it would be hard to login the apache build machine : (
Oh, really..
> I also repoduced locally by manually adding 'sleep 1' into mksymtab.sh in the current code base. >From the build log, I think the link error is because of posix_spawn are built twice by pass1 and >pass2 context build. In which the symtab.c produced by mksymtab.sh twice,
>so it may be rewrited and compiled at the meantime. And finally result in symtab.o not correct.
I was able to reproduce the error by adding sleep 1 to mksymtab.sh
And also confirmed that https://github.com/apache/incubator-nuttx-apps/pull/120 is effective.
However, I was not reproduced the same error for examples/elf by adding sleep 1 .
Perhaps, examples/elf generates many elf files so it's more complicated than posix_spawn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #118: Fix
parallel buid errors in examples/elf
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #118: Fix parallel buid errors in examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-599054615
@liuguo09
>In the 10th build log, I think it was because of build without #120 PR.
>while in the following builds, I add the change.
I don't think #120 PR was effective. Because the latest nightly build still failed.
Also, I've not applied #120 PR for my tests but I can not sill reproduce linker errors.
Now, I've just changed a build machine from 'ubuntu' (actually H43 was assigned) to H27 which is used for the recent nightly build but still no errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services