You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "vy (via GitHub)" <gi...@apache.org> on 2025/11/28 14:21:28 UTC
[PR] Disable commit signatures [logging-log4j-jakarta]
vy opened a new pull request, #61:
URL: https://github.com/apache/logging-log4j-jakarta/pull/61
See apache/logging-log4j2#3989.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable commit signatures [logging-log4j-jakarta]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #61:
URL: https://github.com/apache/logging-log4j-jakarta/pull/61#discussion_r2576217233
##########
.asf.yaml:
##########
Review Comment:
I've noticed that but intentionally refrained from touching it since it is out of the scope and will likely need more exploration. Nevertheless, after your nudge, removed it. I presume you will help with fixing the site if it breaks. :stuck_out_tongue:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable commit signatures [logging-log4j-jakarta]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #61:
URL: https://github.com/apache/logging-log4j-jakarta/pull/61#discussion_r2576211139
##########
.asf.yaml:
##########
@@ -55,10 +63,23 @@ github:
merge: false
rebase: false
- # Prevent force pushes to primary branches
+ # Enforce Review-then-Commit
protected_branches:
main:
- required_signatures: true
+ # All reviews must be addressed before merging
+ required_conversation_resolution: true
+ # Require checks to pass before merging
+ required_status_checks:
+ checks:
+ # The GitHub Actions app: 15368
+ - app_id: 15368
+ context: "build / build (ubuntu-latest)"
+ # The GitHub Advanced Security app: 57789
+ - app_id: 57789
+ context: "CodeQL"
+ # At least one positive review must be present
+ required_pull_request_reviews:
+ required_approving_review_count: 1
publish:
profile: ~
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable commit signatures [logging-log4j-jakarta]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #61:
URL: https://github.com/apache/logging-log4j-jakarta/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable commit signatures [logging-log4j-jakarta]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #61:
URL: https://github.com/apache/logging-log4j-jakarta/pull/61#discussion_r2572242779
##########
.asf.yaml:
##########
Review Comment:
Can you also remove the incorrect `profile: ~` key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org