You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Alexander Shraer (JIRA)" <ji...@apache.org> on 2011/07/01 01:01:28 UTC
[jira] [Created] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
QuorumMaj counts the number of ACKs but does not check who sent the ACK
-----------------------------------------------------------------------
Key: ZOOKEEPER-1113
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Reporter: Alexander Shraer
Priority: Minor
If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065104#comment-13065104 ]
Flavio Junqueira commented on ZOOKEEPER-1113:
---------------------------------------------
Hi Alex, We tried to make the computation of containsQuorum as simple as possible to be efficient, but it is right that it has the drawback you point out. Also, we haven't measured the performance impact, so in reality, we don't know if having a loop and checking every vote would make any noticeable difference.
I checked that core test failure is not due to this patch. I'll be reviewing this patch shortly.
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.0
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254419#comment-13254419 ]
Alexander Shraer commented on ZOOKEEPER-1113:
---------------------------------------------
after looking more closely on this, QuorumMajorityTest requires changes to Proposal that I didn't include in 1411. It will go into the next reconfiguration-related patch.
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1113:
----------------------------------------
Issue Type: Sub-task (was: Bug)
Parent: ZOOKEEPER-107
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1113:
----------------------------------------
Attachment: ZOOKEEPER-1113.patch
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1113:
----------------------------------------
Affects Version/s: (was: 3.5.0)
Fix Version/s: 3.5.0
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058122#comment-13058122 ]
Alexander Shraer commented on ZOOKEEPER-1113:
---------------------------------------------
I fixed this as part of ZOOKEEPER-107, which required also other changes to the quorum verifiers
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243240#comment-13243240 ]
Alexander Shraer commented on ZOOKEEPER-1113:
---------------------------------------------
thanks Flavio, this is actually subsumed by 1411. I will fix the spacing in QuorumMajorityTest and move it to 1411.
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243194#comment-13243194 ]
Flavio Junqueira commented on ZOOKEEPER-1113:
---------------------------------------------
The patch attached looks mostly good to me. It needs a couple of small fixes, though. It does not apply cleaning to trunk and the spacing is not right in QuorumMajorityTest:
{noformat}
+ //setup servers 1-3 to be followers and 4 and 5 to be observers
+ setUp(true);
+ ackSet.clear();
+
+ // 1 follower out of 3 is not a majority
{noformat}
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1113:
----------------------------------------
Affects Version/s: 3.4.0
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.0
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058177#comment-13058177 ]
Hadoop QA commented on ZOOKEEPER-1113:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484845/ZOOKEEPER-1113.patch
against trunk revision 1141746.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/364//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/364//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/364//console
This message is automatically generated.
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1113) QuorumMaj counts the number of
ACKs but does not check who sent the ACK
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1113:
----------------------------------------
Affects Version/s: (was: 3.4.0)
3.5.0
subtask of ZooKeeper-107
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira