You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/20 15:24:12 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5553: boards: Add -fno-common to ARCHCFLAGS and ARCHCXXFLAGS
xiaoxiang781216 commented on a change in pull request #5553:
URL: https://github.com/apache/incubator-nuttx/pull/5553#discussion_r810641963
##########
File path: boards/arm/stm32f7/stm32f746g-disco/scripts/Make.defs
##########
@@ -30,14 +30,14 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin
-ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS = -fno-common -fno-builtin
+ARCHCXXFLAGS = -fno-common -fno-builtin -fno-exceptions -fcheck-new -fno-rtti
ifeq ($(CONFIG_ARMV7M_TOOLCHAIN_CLANGL),y)
- ARCHCFLAGS += -nostdlib -ffreestanding
- ARCHCXXFLAGS += -nostdlib -ffreestanding
+ ARCHCFLAGS += -fno-common -nostdlib -ffreestanding
+ ARCHCXXFLAGS += -fno-common -nostdlib -ffreestanding
else
- ARCHCXXFLAGS += -fno-rtti
+ ARCHCXXFLAGS += -fno-common -fno-rtti
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org