You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/03/31 22:47:09 UTC
Review Request 45562: Edited `--work_dir` help strings and docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
Diffs
-----
docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 45562: Edited `--work_dir` help strings and docs.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126442
-----------------------------------------------------------
docs/configuration.md (line 361)
<https://reviews.apache.org/r/45562/#comment189430>
What's an "automatic garbage collection service"? Can we spell out what bad stuff might happen if `/tmp` is used for `work_dir`?
docs/configuration.md (line 1598)
<https://reviews.apache.org/r/45562/#comment189431>
Might be worth noting that the default value _is_ not consistent with this warning.
- Neil Conway
On March 31, 2016, 8:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 8:47 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
>
>
> Diffs
> -----
>
> docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
> src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
> src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
>
> Diff: https://reviews.apache.org/r/45562/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45562: Edited `--work_dir` configuration docs.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 31, 2016, 10:16 p.m., Joerg Schad wrote:
> > docs/configuration.md, line 354
> > <https://reviews.apache.org/r/45562/diff/3/?file=1321440#file1321440line354>
> >
> > Not yours but why isn't that flag in the common master/agent section above?
I decided to put the work_dir flags in the "required flags" section of the master/agent (since they're required), rather than the "shared flags" section. What do you think?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
-----------------------------------------------------------
On April 11, 2016, 4:38 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:38 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
>
>
> Diffs
> -----
>
> docs/configuration.md ba00ec563c449345effb3114111812601addcfc2
>
> Diff: https://reviews.apache.org/r/45562/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45562: Edited `--work_dir` help strings and docs.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
-----------------------------------------------------------
Fix it, then Ship it!
docs/configuration.md (line 354)
<https://reviews.apache.org/r/45562/#comment189467>
Not yours but why isn't that flag in the common master/agent section above?
docs/configuration.md (line 361)
<https://reviews.apache.org/r/45562/#comment189470>
are *only* suitable for short-term?
- Joerg Schad
On March 31, 2016, 9:22 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 9:22 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
>
>
> Diffs
> -----
>
> docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
> src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
> src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
>
> Diff: https://reviews.apache.org/r/45562/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45562: Edited `--work_dir` configuration docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
(Updated April 12, 2016, 5:52 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.
Diffs (updated)
-----
docs/configuration.md ba00ec563c449345effb3114111812601addcfc2
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 45562: Edited `--work_dir` configuration docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
(Updated April 11, 2016, 9:09 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description (updated)
-------
Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.
Diffs
-----
docs/configuration.md ba00ec563c449345effb3114111812601addcfc2
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 45562: Edited `--work_dir` configuration docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
(Updated April 11, 2016, 4:38 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Summary (updated)
-----------------
Edited `--work_dir` configuration docs.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
Diffs (updated)
-----
docs/configuration.md ba00ec563c449345effb3114111812601addcfc2
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 45562: Edited `--work_dir` help strings and docs.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review127714
-----------------------------------------------------------
How about `fetcher_cache_dir`, `appc_store_dir` and `docker_store_dir`?
- haosdent huang
On March 31, 2016, 9:22 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 9:22 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
>
>
> Diffs
> -----
>
> docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
> src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
> src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
>
> Diff: https://reviews.apache.org/r/45562/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45562: Edited `--work_dir` help strings and docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
(Updated March 31, 2016, 9:22 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Changes
-------
Addressed comment.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
Diffs (updated)
-----
docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 45562: Edited `--work_dir` help strings and docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
-----------------------------------------------------------
(Updated March 31, 2016, 9 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Changes
-------
Addressed comments.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Some users have encountered difficulty when running the Mesos agent with the `work_dir` located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings and configuration docs advising users to avoid the use of this location in production.
Diffs (updated)
-----
docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9
src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3
src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
Diff: https://reviews.apache.org/r/45562/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann