You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/07 04:15:47 UTC
[GitHub] [pulsar] geetha-rangaswamaiah opened a new pull request #7780: Fix admin-api-partitioned-topics page grammatical errors
geetha-rangaswamaiah opened a new pull request #7780:
URL: https://github.com/apache/pulsar/pull/7780
This PR fixes admin-api-partitioned-topics page grammatical errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7780: Fix admin-api-partitioned-topics page grammatical errors
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7780:
URL: https://github.com/apache/pulsar/pull/7780#discussion_r468718489
##########
File path: site2/docs/admin-api-partitioned-topics.md
##########
@@ -201,7 +201,7 @@ admin.persistentTopics().getList(namespace);
### Stats
-It shows current statistics of a given partitioned topic. Here's an example payload:
+It shows the current statistics of a given partitioned topic. Here's an example payload:
Review comment:
```suggestion
It shows the current statistics of a given partitioned topic. Here is an example payload:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7780: Fix admin-api-partitioned-topics page grammatical errors
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7780:
URL: https://github.com/apache/pulsar/pull/7780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #7780: Fix admin-api-partitioned-topics page grammatical errors
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #7780:
URL: https://github.com/apache/pulsar/pull/7780#discussion_r468319666
##########
File path: site2/docs/admin-api-partitioned-topics.md
##########
@@ -311,7 +311,7 @@ It shows detailed statistics of a topic.
|readPosition|The latest position of subscriber for reading message|
|waitingReadOp|This is true when the subscription has read the latest message published to the topic and is waiting on new messages to be published.|
|pendingReadOps|The counter for how many outstanding read requests to the BookKeepers we have in progress|
-|messagesConsumedCounter|Number of messages this cursor has acked since this broker loaded this topic|
+|messagesConsumedCounter|Number of messages this cursor has asked since this broker loaded this topic|
Review comment:
```suggestion
|messagesConsumedCounter|Number of messages this cursor has acked since this broker loaded this topic|
```
##########
File path: site2/docs/admin-api-partitioned-topics.md
##########
@@ -311,7 +311,7 @@ It shows detailed statistics of a topic.
|readPosition|The latest position of subscriber for reading message|
|waitingReadOp|This is true when the subscription has read the latest message published to the topic and is waiting on new messages to be published.|
|pendingReadOps|The counter for how many outstanding read requests to the BookKeepers we have in progress|
-|messagesConsumedCounter|Number of messages this cursor has acked since this broker loaded this topic|
+|messagesConsumedCounter|Number of messages this cursor has asked since this broker loaded this topic|
Review comment:
I don't think this is the right fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org