[GitHub] fbocse commented on a change in pull request #91: Ignore unsupported partition fields

[GitBox <gi...@apache.org>]

fbocse commented on a change in pull request #91: Ignore unsupported partition fields
URL: https://github.com/apache/incubator-iceberg/pull/91#discussion_r259538066
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/expressions/Expressions.java
 ##########
 @@ -117,6 +117,10 @@ public static Expression not(Expression child) {
     return new UnboundPredicate<>(op, ref(name));
   }
 
+  public static <T> UnboundPredicate<T> alwaysTrue(String name) {
 
 Review comment:
   I've added this method in `com.netflix.iceberg.expressions.Expressions` because `com.netflix.iceberg.expressions.UnboundPredicate` constructors are package-private so it's visible only within its own package and I needed to override method from class in different package `com.netflix.iceberg.transforms.UnknownTransform#project`. Does this answer your question? 
   Since this method is obviously taking a redundant argument would you consider this version instead? 
   ```return new UnboundPredicate<>(Operation.TRUE, null);```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org