You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/29 02:10:41 UTC

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

leslie-tsang commented on a change in pull request #5947:
URL: https://github.com/apache/apisix/pull/5947#discussion_r776126818



##########
File path: apisix/plugins/jwt-auth.lua
##########
@@ -344,8 +341,8 @@ end
 function _M.rewrite(conf, ctx)
     local jwt_token, err = fetch_jwt_token(ctx)
     if not jwt_token then
-        if err and err:sub(1, #"no cookie") ~= "no cookie" then
-            core.log.error("failed to fetch JWT token: ", err)
+        if err then

Review comment:
       Seems we don't need to check `err` as func `fetch_jwt_token` doesn't return it any more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org