You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/07/21 02:48:39 UTC

[GitHub] [singa] nudles opened a new pull request #770: Update setup.py to build wheel packages

nudles opened a new pull request #770:
URL: https://github.com/apache/singa/pull/770


   Refer to the [instructions ](http://singa.apache.org/docs/next/installation/#using-pip)on how to install the wheel package using pip.
   Need to test the existing building approaches, e.g., building from source and building from conda to see if they are affected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on a change in pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on a change in pull request #770:
URL: https://github.com/apache/singa/pull/770#discussion_r457850417



##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
 %include "config.i"
 %include "core_tensor.i"
 %include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"

Review comment:
       But even if I put the `%include "model_optimizer.i"` back, there is another error
   ```
   ======================================================================
   ERROR: test_sgd_cuda (test_optimizer.TestOptimizer)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/root/dcsysh/singa/test/python/test_optimizer.py", line 117, in test_sgd_cuda
       sgd = opt.SGD(lr)
     File "/root/dcsysh/singa/build/python/singa/optimizer.py", line 222, in __init__
       self.opt = singa.CreateOptimizer('SGD'.encode())
   TypeError: in method 'CreateOptimizer', argument 1 of type 'std::string const &'
   ```
   
   The c optimizer is very old and decreprated (not used anymore)? Our current optimizer is in python




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-661635150


   In test_tensor.py L487 and L504
   https://github.com/nudles/singa/blob/dev/test/python/test_tensor.py#L487 
   I changed both to
   `self.assertEqual(y.dtype, tensor.float32)`
   to reduce some 4 errors
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683546232


   This pull request **introduces 4 alerts** and **fixes 3** when merging 3c3b0cf51147516dcc19a4832c8fca294924e428 into 4d0672967edfe8db7188b4f0ec200620dd716bae - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-595baeecba17e55a933b1f1643a05de5fd4c735b)
   
   **new alerts:**
   
   * 3 for Missing return statement
   * 1 for Module is imported with &#39;import&#39; and &#39;import from&#39;
   
   **fixed alerts:**
   
   * 3 for Missing call to \_\_init\_\_ during object initialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-661599724


   This pull request **introduces 6 alerts** when merging 387c76ddbf229ab46d0ccf786367aedd8ea2d25b into 5f4b250c1ef4d0380769310e3884bf0c1115d2a1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-c087b885a6aba868a78fd77858a6554238d95a38)
   
   **new alerts:**
   
   * 2 for Unused local variable
   * 2 for Unused import
   * 2 for Module is imported with &#39;import&#39; and &#39;import from&#39;


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-661591991


   I will review this PR, thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-661635150


   In test_tensor.py L487 and L504
   https://github.com/nudles/singa/blob/dev/test/python/test_tensor.py#L487 
   I changed both to
   `self.assertEqual(y.dtype, 0) # 0 for core.proto.kFloat32`
   to reduce some 4 errors
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] edited a comment on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683563441


   # [Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=h1) Report
   > Merging [#770](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/4d0672967edfe8db7188b4f0ec200620dd716bae?el=desc) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/770/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #770   +/-   ##
   =======================================
     Coverage   65.15%   65.15%           
   =======================================
     Files          86       86           
     Lines        4781     4781           
   =======================================
     Hits         3115     3115           
     Misses       1666     1666           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/model/operation/convolution.cc](https://codecov.io/gh/apache/singa/pull/770/diff?src=pr&el=tree#diff-c3JjL21vZGVsL29wZXJhdGlvbi9jb252b2x1dGlvbi5jYw==) | `90.00% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=footer). Last update [4d06729...af94f5e](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-661614916


   Currently there is problem in travis-ci
   https://travis-ci.org/github/apache/singa/jobs/710229450#L2437
   `test/python/test_tensor.py:487:34: E0602: Undefined variable 'core_pb2' (undefined-variable)`
   
   I am going to test the code in the panda cluster first


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683557566


   This pull request **introduces 4 alerts** and **fixes 3** when merging af94f5e55bb36c852b5aa164b804bc3b81e88682 into 4d0672967edfe8db7188b4f0ec200620dd716bae - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-96a1929e7021fbeb389ac17b7e6357ae6589f918)
   
   **new alerts:**
   
   * 3 for Missing return statement
   * 1 for Module is imported with &#39;import&#39; and &#39;import from&#39;
   
   **fixed alerts:**
   
   * 3 for Missing call to \_\_init\_\_ during object initialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683374158


   This pull request **introduces 4 alerts** and **fixes 3** when merging d5cce78f82efd0ec03e0f2a2b725f00ca6e33f9e into a93aaee03c295113ca30dbeecb0039d1f2b8f15d - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-415ac4630bd82b9a25eb339e3fa6c492dbf27296)
   
   **new alerts:**
   
   * 3 for Missing return statement
   * 1 for Syntax error
   
   **fixed alerts:**
   
   * 3 for Missing call to \_\_init\_\_ during object initialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on a change in pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on a change in pull request #770:
URL: https://github.com/apache/singa/pull/770#discussion_r457842648



##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
 %include "config.i"
 %include "core_tensor.i"
 %include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"

Review comment:
       Without `%include "model_optimizer.i"` the old optimizer test case does not work
   
   ```
   ======================================================================
   ERROR: test_sgd (test_optimizer.TestOptimizer)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/root/dcsysh/singa/test/python/test_optimizer.py", line 77, in test_sgd
       sgd = opt.SGD(lr)
     File "/root/dcsysh/singa/build/python/singa/optimizer.py", line 222, in __init__
       self.opt = singa.CreateOptimizer('SGD'.encode())
   AttributeError: module 'singa.singa_wrap' has no attribute 'CreateOptimizer'
   ```

##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
 %include "config.i"
 %include "core_tensor.i"
 %include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"
-%include "model_loss.i"
-%include "model_metric.i"
 %include "model_operation.i"
-%include "io_snapshot.i"
-%include "dist_communicator.i"

Review comment:
       the dist_communicator.i is the interface between c and python, without `include "dist_communicator.i"` the commuicator cannot be found in python code
   
   ```
   ======================================================================
   ERROR: test_dist (unittest.loader._FailedTest)
   ----------------------------------------------------------------------
   ImportError: Failed to import test module: test_dist
   Traceback (most recent call last):
     File "/usr/lib/python3.6/unittest/loader.py", line 428, in _find_test_path
       module = self._get_module_from_name(name)
     File "/usr/lib/python3.6/unittest/loader.py", line 369, in _get_module_from_name
       __import__(name)
     File "/root/dcsysh/singa/test/python/test_dist.py", line 27, in <module>
       sgd = opt.DistOpt(sgd)
     File "/root/dcsysh/singa/build/python/singa/opt.py", line 362, in __init__
       self.communicator = singa.Communicator(buffSize)
   AttributeError: module 'singa.singa_wrap' has no attribute 'Communicator'
   
   ```

##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
 %include "config.i"
 %include "core_tensor.i"
 %include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"
-%include "model_loss.i"

Review comment:
       Without `%include "model_loss.i"` the old loss test case does not work 
   ```
   ======================================================================
   ERROR: test_softmax_cross_entropy (test_loss.TestLoss)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/root/dcsysh/singa/test/python/test_loss.py", line 62, in test_softmax_cross_entropy
       sce = loss.SoftmaxCrossEntropy()
     File "/root/dcsysh/singa/build/python/singa/loss.py", line 118, in __init__
       self.swig_loss = singa.SoftmaxCrossEntropy()
   AttributeError: module 'singa.singa_wrap' has no attribute 'SoftmaxCrossEntropy'
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683368783


   This pull request **introduces 6 alerts** and **fixes 3** when merging e5445a50a4eed19bc88f3937ad3e8f32c7f87388 into a93aaee03c295113ca30dbeecb0039d1f2b8f15d - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-e3ff8652a3a1ec638ed30628ebbdd61a02c6836b)
   
   **new alerts:**
   
   * 2 for Unused local variable
   * 2 for Unused import
   * 2 for Module is imported with &#39;import&#39; and &#39;import from&#39;
   
   **fixed alerts:**
   
   * 3 for Missing call to \_\_init\_\_ during object initialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on a change in pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on a change in pull request #770:
URL: https://github.com/apache/singa/pull/770#discussion_r457850417



##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
 %include "config.i"
 %include "core_tensor.i"
 %include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"

Review comment:
       But even if I put the `%include "model_optimizer.i"` back, there is another error
   ```
   ======================================================================
   ERROR: test_sgd_cuda (test_optimizer.TestOptimizer)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/root/dcsysh/singa/test/python/test_optimizer.py", line 117, in test_sgd_cuda
       sgd = opt.SGD(lr)
     File "/root/dcsysh/singa/build/python/singa/optimizer.py", line 222, in __init__
       self.opt = singa.CreateOptimizer('SGD'.encode())
   TypeError: in method 'CreateOptimizer', argument 1 of type 'std::string const &'
   ```
   
   The c optimizer is very old and deprecated (not used anymore)? Our current optimizer is in python




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683563441


   # [Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=h1) Report
   > Merging [#770](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/4d0672967edfe8db7188b4f0ec200620dd716bae?el=desc) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/770/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #770   +/-   ##
   =======================================
     Coverage   65.15%   65.15%           
   =======================================
     Files          86       86           
     Lines        4781     4781           
   =======================================
     Hits         3115     3115           
     Misses       1666     1666           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/model/operation/convolution.cc](https://codecov.io/gh/apache/singa/pull/770/diff?src=pr&el=tree#diff-c3JjL21vZGVsL29wZXJhdGlvbi9jb252b2x1dGlvbi5jYw==) | `90.00% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=footer). Last update [4d06729...af94f5e](https://codecov.io/gh/apache/singa/pull/770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #770:
URL: https://github.com/apache/singa/pull/770#issuecomment-683541504


   This pull request **introduces 3 alerts** and **fixes 3** when merging 6319c8ad2fb5a2e1247789f4da4747bb2a291ac3 into 4d0672967edfe8db7188b4f0ec200620dd716bae - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-3d1af83605835971d5ec1bf9058097ebe5363542)
   
   **new alerts:**
   
   * 3 for Missing return statement
   
   **fixed alerts:**
   
   * 3 for Missing call to \_\_init\_\_ during object initialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris merged pull request #770: Update setup.py to build wheel packages

Posted by GitBox <gi...@apache.org>.
chrishkchris merged pull request #770:
URL: https://github.com/apache/singa/pull/770


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org