You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/31 05:56:37 UTC

[GitHub] Hoolefu commented on a change in pull request #740: check ChannelHandlerContext whether is null

Hoolefu commented on a change in pull request #740: check ChannelHandlerContext whether is null
URL: https://github.com/apache/rocketmq/pull/740#discussion_r252543346
 
 

 ##########
 File path: namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
 ##########
 @@ -383,10 +383,12 @@ private RemotingCommand wipeWritePermOfBroker(ChannelHandlerContext ctx,
 
         int wipeTopicCnt = this.namesrvController.getRouteInfoManager().wipeWritePermOfBrokerByLock(requestHeader.getBrokerName());
 
-        log.info("wipe write perm of broker[{}], client: {}, {}",
-            requestHeader.getBrokerName(),
-            RemotingHelper.parseChannelRemoteAddr(ctx.channel()),
-            wipeTopicCnt);
+        if (ctx != null) {
 
 Review comment:
   check ChannelHandlerContext whether is null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services