You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "ILuffZhe (via GitHub)" <gi...@apache.org> on 2025/07/03 07:45:01 UTC

Re: [PR] [CALCITE-7069] Invalid unparse for INT UNSIGNED and BIGINT UNSIGNED in MysqlSqlDialect [calcite]

ILuffZhe commented on code in PR #4445:
URL: https://github.com/apache/calcite/pull/4445#discussion_r2182097154


##########
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java:
##########
@@ -196,6 +196,14 @@ public MysqlSqlDialect(Context context) {
               type.getSqlTypeName(),
               SqlParserPos.ZERO),
           SqlParserPos.ZERO);
+    case UINTEGER:

Review Comment:
   > One thing to note is that StarRocks/Doris dialect inherits from MysqlDialect, so we need to make sure they are consistent with MySQL regarding UNSIGNED types.
   
   Good point, I'll check this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org