You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lkishalmi (via GitHub)" <gi...@apache.org> on 2024/04/14 22:01:43 UTC

[PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

lkishalmi opened a new pull request, #7269:
URL: https://github.com/apache/netbeans/pull/7269

   Updated the GoLang grammar from the ANTLR4 Repo, it supports Go 1.20 which has a new `~` operator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7269:
URL: https://github.com/apache/netbeans/pull/7269#issuecomment-2408128183

   @lkishalmi dropping the milestone since it has been bumped a few times already.
   
   If you refresh this PR, feel free to add the a milestone again, there would be also still enough time to get this into NB 24 as of today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #7269:
URL: https://github.com/apache/netbeans/pull/7269#discussion_r1568741050


##########
ide/go.lang/nbproject/project.properties:
##########
@@ -16,7 +16,10 @@
 # under the License.
 javac.source=1.8
 
-# As of 2nd Jan 2023, we use the Grammar from:
-# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+# As of 14th April 2024, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang
 #
-golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
+golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92
+
+# Simple language update can result too many signature changes in the generated code.
+sigtest.skip.gen=true

Review Comment:
   Agreed!  Although I'm also curious why this is a module at all?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7269:
URL: https://github.com/apache/netbeans/pull/7269#discussion_r1566244043


##########
ide/go.lang/nbproject/project.properties:
##########
@@ -16,7 +16,10 @@
 # under the License.
 javac.source=1.8
 
-# As of 2nd Jan 2023, we use the Grammar from:
-# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+# As of 14th April 2024, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang
 #
-golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
+golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92
+
+# Simple language update can result too many signature changes in the generated code.
+sigtest.skip.gen=true

Review Comment:
   Why drop the pretense, that this is module has an API and require that users make dependencies implementation dependencies?



##########
ide/go.lang/nbproject/project.properties:
##########
@@ -16,7 +16,10 @@
 # under the License.
 javac.source=1.8
 
-# As of 2nd Jan 2023, we use the Grammar from:
-# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+# As of 14th April 2024, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang
 #
-golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
+golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92
+
+# Simple language update can result too many signature changes in the generated code.
+sigtest.skip.gen=true

Review Comment:
   Why drop the pretense that this is module has an API and require that users make dependencies implementation dependencies?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7269:
URL: https://github.com/apache/netbeans/pull/7269#issuecomment-4244062649

   lets try to get this in for NB 31 since this is a small one. adding milestone again ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Updated Go Lexer/Parser for Go Lang 1.20 [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7269:
URL: https://github.com/apache/netbeans/pull/7269#issuecomment-2233601460

   fyi: i moved the milestone to NB 24 for now. (but we could squeeze this one in too if the comments are addressed since the change is isolated to go)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists