You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/06 17:46:12 UTC
[GitHub] [trafficcontrol] dpham692 opened a new issue #5405: User can update parent tenant to have their child tenant as a new parent
dpham692 opened a new issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Portal
## Current behavior:
<!-- Describe how the bug manifests -->
User can update parent tenant to have their child tenant as a new parent and the result is it will delete all the tenant from parent to the child
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
System should not let user update parent tenant to have their child tenant as a new parent tenant.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
1. Create a tenant with few child tenant.
2. Update parent tenant to have child tenant and it will wipe out all the tenant.
## Anything else:
<!--
e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
this section)
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] TaylorCFrey commented on issue #5405: User can update parent tenant to have their child tenant as a new parent
Posted by GitBox <gi...@apache.org>.
TaylorCFrey commented on issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405#issuecomment-763896887
@mitchell852 I'll take this one. Could you assign it to me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] TaylorCFrey commented on issue #5405: User can update parent tenant to have their child tenant as a new parent
Posted by GitBox <gi...@apache.org>.
TaylorCFrey commented on issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405#issuecomment-763896887
@mitchell852 I'll take this one. Could you assign it to me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #5405: User can update parent tenant to have their child tenant as a new parent
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405#issuecomment-755457906
good catch! yeah, obviously a tenant's parent cannot be a child of that tenant. 👍 - needs a simple parent check on PUT and if child return 400 with message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #5405: User can update parent tenant to have their child tenant as a new parent
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405#issuecomment-755457906
good catch! yeah, obviously a tenant's parent cannot be a child of that tenant. 👍 - needs a simple parent check on PUT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 closed issue #5405: User can update parent tenant to have their child tenant as a new parent
Posted by GitBox <gi...@apache.org>.
mattjackson220 closed issue #5405:
URL: https://github.com/apache/trafficcontrol/issues/5405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org