You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/11/09 13:15:10 UTC

svn commit: r1032954 - in /commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp: FTP.java FTPListParseEngine.java

Author: sebb
Date: Tue Nov  9 12:15:10 2010
New Revision: 1032954

URL: http://svn.apache.org/viewvc?rev=1032954&view=rev
Log:
More efficient (Findbugs)

Modified:
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTP.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTP.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTP.java?rev=1032954&r1=1032953&r2=1032954&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTP.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTP.java Tue Nov  9 12:15:10 2010
@@ -633,7 +633,7 @@ public class FTP extends SocketClient
      ***/
     public String[] getReplyStrings()
     {
-        return _replyLines.toArray(new String[0]);
+        return _replyLines.toArray(new String[_replyLines.size()]);
     }
 
     /***

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java?rev=1032954&r1=1032953&r2=1032954&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java Tue Nov  9 12:15:10 2010
@@ -191,7 +191,7 @@ public class FTPListParseEngine {
             tmpResults.add(temp);
             count--;
         }
-        return tmpResults.toArray(new FTPFile[0]);
+        return tmpResults.toArray(new FTPFile[tmpResults.size()]);
 
     }
 
@@ -230,7 +230,7 @@ public class FTPListParseEngine {
             tmpResults.add(0,temp);
             count--;
         }
-        return tmpResults.toArray(new FTPFile[0]);
+        return tmpResults.toArray(new FTPFile[tmpResults.size()]);
     }
 
     /**