You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@commons.apache.org by DaGeRe <gi...@git.apache.org> on 2018/09/28 09:24:03 UTC
[GitHub] commons-compress pull request #70: Use Java 7 Files.createTempDirectory inst...
GitHub user DaGeRe opened a pull request:
https://github.com/apache/commons-compress/pull/70
Use Java 7 Files.createTempDirectory instead of creating file, deleti…
…ng it and create directory
The self-written mkdir deletes a temporary file with a prefix, deletes it and creates an directory with the same name. Creating a temporary file by Files.createTempDirectory so is cleaner and faster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaGeRe/commons-compress master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/70.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #70
----
commit bb6890f0fe9bc51a9e493d9ee9ab02a04a155ac5
Author: David Georg Reichelt <da...@...>
Date: 2018-09-28T09:21:43Z
Use Java 7 Files.createTempDirectory instead of creating file, deleting it and create directory
----
---
[GitHub] commons-compress pull request #70: Use Java 7 Files.createTempDirectory inst...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/70
---
[GitHub] commons-compress issue #70: Use Java 7 Files.createTempDirectory instead of ...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/70
[](https://coveralls.io/builds/19243727)
Coverage remained the same at 86.781% when pulling **bb6890f0fe9bc51a9e493d9ee9ab02a04a155ac5 on DaGeRe:master** into **ac3d73153725fa1bce721055c4ac61423570d34c on apache:master**.
---
[GitHub] commons-compress issue #70: Use Java 7 Files.createTempDirectory instead of ...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/70
I've just commited a minimal implementation of the suggested change, many thanks.
---
[GitHub] commons-compress issue #70: Use Java 7 Files.createTempDirectory instead of ...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/70
Many thanks. I agree this is cleaner, the existing method is a leftover of the time before we made Java7 our baseline.
While I don't think we consider the tests a public API of ours, the change would be smaller and keep perfect backwards compatibility if you "just" changed the implementation of `mkdir`.
---