[Bug 58431] New: AccessLogValve default values for prefix and suffix not coherent with other log files

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=58431

            Bug ID: 58431
           Summary: AccessLogValve default values for prefix and suffix
                    not coherent with other log files
           Product: Tomcat 8
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: zigarn+apache@gmail.com

Created attachment 33119
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33119&action=edit
Patch proposing to change AccessLogValve suffix and prefix

Log files are in the form '${prefix}.yyyy-mm-dd.log', but AccessLogValve
default values creates log files in the form 'access_log.yyyy-mm-dd' and
proposed configuration is 'localhost_access_log.yyyy-mm-dd.txt'.
This is not coherent, the default could be 'access.yyyy-mm-dd.log'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 58431] AccessLogValve default values for prefix and suffix not coherent with other log files

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=58431

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
1. Changing the naming in the default servlet.xml is a bad idea.

I am sure that the default naming is mentioned in many places, that will be
broken / obsoleted by this change: books, documentations, FAQs, discussions,
etc.

2. Access Log and java.util.logging logs are different beasts, serving
different purpose and having different format. It is good to keep them
separate.

I do not know whether this naming was a conscious decision 10+ years ago, or it
just happened this way, but I find this feature useful.


3. Apache HTTPD [1] uses "logs/access_log" in its examples. I think that if
that log is rotated it will grow a date suffix.

[1] http://httpd.apache.org/docs/2.4/mod/mod_log_config.html#customlog


I do not see enough reasons for making the proposed change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 58431] AccessLogValve default values for prefix and suffix not coherent with other log files

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=58431

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org