You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by mr...@apache.org on 2008/02/16 15:01:30 UTC
svn commit: r628298 -
/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Author: mrdon
Date: Sat Feb 16 06:01:29 2008
New Revision: 628298
URL: http://svn.apache.org/viewvc?rev=628298&view=rev
Log:
Commenting out tests for now
WW-2494
Modified:
struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
==============================================================================
--- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
+++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
@@ -3,7 +3,9 @@
public class Struts2PortletTest extends BasePortletTest {
private final static String PORTLET_NAME = "StrutsPortlet";
-
+
+ public void testNone() {}
+/*
public void testIndexPage() throws Exception {
beginAt("pluto/index.jsp");
assertTextPresent("Welcome to the Struts example portlet");
@@ -74,7 +76,7 @@
switchEdit();
assertTextPresent("Back to view mode");
}
-
+*/
@Override
public String getPortletName() {
return PORTLET_NAME;
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
Yes, I learned that yesterday, although the problem seems to lie
somewhere else. I will make sure to updated the uri in a later release
of the maven-jetty-pluto-embedded project.
Nils-H
> You may know this, so apologies if I'm stating the obvious...
>
> Pluto depends on 1.0.x of the standard taglib[1] - in that version sun
> used "http://java.sun.com/jstl/core" for the taglib uri (in c.tld),
> but from 1.1.x onwards they changed the uri to
> "http://java.sun.com/jsp/jstl/core" - so my guess is its a class
> loading issue and probably c.tld with the later format uri is being
> loaded from somewhere like Jetty's JSP-2.1 jar[2].
>
> Having said all that - I still couldn't get it to work - I also tried
> the surefire "childDelegation" option[3] - but that didn't seem to
> work - although it does say something about excluding javax.*
>
> [1] http://repo1.maven.org/maven2/taglibs/standard/
> [2] http://repo1.maven.org/maven2/org/mortbay/jetty/jsp-2.1/
> [3] http://maven.apache.org/plugins/maven-surefire-plugin/examples/class-loading.html
>
>
> > Nils-H
> >
> >
> > On Feb 16, 2008 3:16 PM, Don Brown <mr...@twdata.org> wrote:
> > > Yay Maven... *ducks* :)
> > >
> > >
> > > Don
> > >
> > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > > I know. I've tried locally as well. It's not very obvious what the
> > > > problem could be. This test has been running without problems for a
> > > > long time no (after some initial start up problems...), so there's no
> > > > reason it suddenly should fail.
> > > >
> > > > Nils-H
> > > >
> > > > On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> > > > > I explicitly removed the 2.4 servlet jar that was leaking in, but that
> > > > > only seemed to fix the method not found exception I was seeing. I
> > > > > even tried including jstl but that didn't seem to help.
> > > > >
> > > > > Don
> > > > >
> > > > >
> > > > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > > > > I don't know why the test have started to fail, but it appears that
> > > > > > some updated dependency version somewhere has caused a
> > > > > > dependency-classloader-clash.... The prime suspect is a conflicting
> > > > > > version of servlet-api indirectly included somewhere...
> > > > > >
> > > > > > Nils-H
> > > > > >
> > > > > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > > > > > Author: mrdon
> > > > > > > Date: Sat Feb 16 06:01:29 2008
> > > > > > > New Revision: 628298
> > > > > > >
> > > > > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > > > > > Log:
> > > > > > > Commenting out tests for now
> > > > > > > WW-2494
> > > > > > >
> > > > > > > Modified:
> > > > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > > >
> > > > > > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > > > > > ==============================================================================
> > > > > > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > > > > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > > > > > @@ -3,7 +3,9 @@
> > > > > > > public class Struts2PortletTest extends BasePortletTest {
> > > > > > >
> > > > > > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > > > > > -
> > > > > > > +
> > > > > > > + public void testNone() {}
> > > > > > > +/*
> > > > > > > public void testIndexPage() throws Exception {
> > > > > > > beginAt("pluto/index.jsp");
> > > > > > > assertTextPresent("Welcome to the Struts example portlet");
> > > > > > > @@ -74,7 +76,7 @@
> > > > > > > switchEdit();
> > > > > > > assertTextPresent("Back to view mode");
> > > > > > > }
> > > > > > > -
> > > > > > > +*/
> > > > > > > @Override
> > > > > > > public String getPortletName() {
> > > > > > > return PORTLET_NAME;
> > > > > > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Niall Pemberton <ni...@gmail.com>.
On Feb 16, 2008 4:18 PM, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> Something is really, really weird... Seems like all loading of tlds
> from jar files has stopped working. If I place the missing tlds in
> web-inf and refer to them in web.xml, I get one step furthere and then
> it fails on the next tag library... What in the world could be causing
> this? I can't rule out the maven-jetty-pluto stuff, although I don't
> see how that could be the problem considering it hasn't changed since
> it was introduced.
You may know this, so apologies if I'm stating the obvious...
Pluto depends on 1.0.x of the standard taglib[1] - in that version sun
used "http://java.sun.com/jstl/core" for the taglib uri (in c.tld),
but from 1.1.x onwards they changed the uri to
"http://java.sun.com/jsp/jstl/core" - so my guess is its a class
loading issue and probably c.tld with the later format uri is being
loaded from somewhere like Jetty's JSP-2.1 jar[2].
Having said all that - I still couldn't get it to work - I also tried
the surefire "childDelegation" option[3] - but that didn't seem to
work - although it does say something about excluding javax.*
[1] http://repo1.maven.org/maven2/taglibs/standard/
[2] http://repo1.maven.org/maven2/org/mortbay/jetty/jsp-2.1/
[3] http://maven.apache.org/plugins/maven-surefire-plugin/examples/class-loading.html
> Nils-H
>
>
> On Feb 16, 2008 3:16 PM, Don Brown <mr...@twdata.org> wrote:
> > Yay Maven... *ducks* :)
> >
> >
> > Don
> >
> > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > I know. I've tried locally as well. It's not very obvious what the
> > > problem could be. This test has been running without problems for a
> > > long time no (after some initial start up problems...), so there's no
> > > reason it suddenly should fail.
> > >
> > > Nils-H
> > >
> > > On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> > > > I explicitly removed the 2.4 servlet jar that was leaking in, but that
> > > > only seemed to fix the method not found exception I was seeing. I
> > > > even tried including jstl but that didn't seem to help.
> > > >
> > > > Don
> > > >
> > > >
> > > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > > > I don't know why the test have started to fail, but it appears that
> > > > > some updated dependency version somewhere has caused a
> > > > > dependency-classloader-clash.... The prime suspect is a conflicting
> > > > > version of servlet-api indirectly included somewhere...
> > > > >
> > > > > Nils-H
> > > > >
> > > > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > > > > Author: mrdon
> > > > > > Date: Sat Feb 16 06:01:29 2008
> > > > > > New Revision: 628298
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > > > > Log:
> > > > > > Commenting out tests for now
> > > > > > WW-2494
> > > > > >
> > > > > > Modified:
> > > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > >
> > > > > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > > > > ==============================================================================
> > > > > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > > > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > > > > @@ -3,7 +3,9 @@
> > > > > > public class Struts2PortletTest extends BasePortletTest {
> > > > > >
> > > > > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > > > > -
> > > > > > +
> > > > > > + public void testNone() {}
> > > > > > +/*
> > > > > > public void testIndexPage() throws Exception {
> > > > > > beginAt("pluto/index.jsp");
> > > > > > assertTextPresent("Welcome to the Struts example portlet");
> > > > > > @@ -74,7 +76,7 @@
> > > > > > switchEdit();
> > > > > > assertTextPresent("Back to view mode");
> > > > > > }
> > > > > > -
> > > > > > +*/
> > > > > > @Override
> > > > > > public String getPortletName() {
> > > > > > return PORTLET_NAME;
> > > > > >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
Something is really, really weird... Seems like all loading of tlds
from jar files has stopped working. If I place the missing tlds in
web-inf and refer to them in web.xml, I get one step furthere and then
it fails on the next tag library... What in the world could be causing
this? I can't rule out the maven-jetty-pluto stuff, although I don't
see how that could be the problem considering it hasn't changed since
it was introduced.
Nils-H
On Feb 16, 2008 3:16 PM, Don Brown <mr...@twdata.org> wrote:
> Yay Maven... *ducks* :)
>
>
> Don
>
> On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > I know. I've tried locally as well. It's not very obvious what the
> > problem could be. This test has been running without problems for a
> > long time no (after some initial start up problems...), so there's no
> > reason it suddenly should fail.
> >
> > Nils-H
> >
> > On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> > > I explicitly removed the 2.4 servlet jar that was leaking in, but that
> > > only seemed to fix the method not found exception I was seeing. I
> > > even tried including jstl but that didn't seem to help.
> > >
> > > Don
> > >
> > >
> > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > > I don't know why the test have started to fail, but it appears that
> > > > some updated dependency version somewhere has caused a
> > > > dependency-classloader-clash.... The prime suspect is a conflicting
> > > > version of servlet-api indirectly included somewhere...
> > > >
> > > > Nils-H
> > > >
> > > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > > > Author: mrdon
> > > > > Date: Sat Feb 16 06:01:29 2008
> > > > > New Revision: 628298
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > > > Log:
> > > > > Commenting out tests for now
> > > > > WW-2494
> > > > >
> > > > > Modified:
> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > >
> > > > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > > > ==============================================================================
> > > > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > > > @@ -3,7 +3,9 @@
> > > > > public class Struts2PortletTest extends BasePortletTest {
> > > > >
> > > > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > > > -
> > > > > +
> > > > > + public void testNone() {}
> > > > > +/*
> > > > > public void testIndexPage() throws Exception {
> > > > > beginAt("pluto/index.jsp");
> > > > > assertTextPresent("Welcome to the Struts example portlet");
> > > > > @@ -74,7 +76,7 @@
> > > > > switchEdit();
> > > > > assertTextPresent("Back to view mode");
> > > > > }
> > > > > -
> > > > > +*/
> > > > > @Override
> > > > > public String getPortletName() {
> > > > > return PORTLET_NAME;
> > > > >
> > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > > For additional commands, e-mail: dev-help@struts.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Al Sutton <al...@alsutton.com>.
If we go back to with Surefire 2.3 we have to make sure we're only using
TestNG 5.1 because there was an API change in later versions of TestNG which
causes surefire 2.3 to bomb out.
Al.
----- Original Message -----
From: "Nils-Helge Garli Hegvik" <ni...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Saturday, February 16, 2008 7:29 PM
Subject: Re: svn commit: r628298 -
/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> You're spot on, Don! I think I remember you mentioning in your blog
> (about the forked Maven initiative) the automatic plugin upgrades as a
> big drawback. Well, guess what. I've traced it down to beeing an
> upgrade of the maven-surefire-plugin which is breaking the test... If
> I set the plugin version back to the previous release (2.3) it runs
> perfectly. But with the new 2.4 version, the test breaks... 2.4.1
> doesn't work either. So what do we do? I guess hard coding the version
> to 2.3 isn't a very good option?
>
> Nils-H
>
> On Feb 16, 2008 3:16 PM, Don Brown <mr...@twdata.org> wrote:
>> Yay Maven... *ducks* :)
>>
>>
>> Don
>>
>> On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
>> > I know. I've tried locally as well. It's not very obvious what the
>> > problem could be. This test has been running without problems for a
>> > long time no (after some initial start up problems...), so there's no
>> > reason it suddenly should fail.
>> >
>> > Nils-H
>> >
>> > On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
>> > > I explicitly removed the 2.4 servlet jar that was leaking in, but
>> > > that
>> > > only seemed to fix the method not found exception I was seeing. I
>> > > even tried including jstl but that didn't seem to help.
>> > >
>> > > Don
>> > >
>> > >
>> > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
>> > > > I don't know why the test have started to fail, but it appears that
>> > > > some updated dependency version somewhere has caused a
>> > > > dependency-classloader-clash.... The prime suspect is a conflicting
>> > > > version of servlet-api indirectly included somewhere...
>> > > >
>> > > > Nils-H
>> > > >
>> > > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
>> > > > > Author: mrdon
>> > > > > Date: Sat Feb 16 06:01:29 2008
>> > > > > New Revision: 628298
>> > > > >
>> > > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
>> > > > > Log:
>> > > > > Commenting out tests for now
>> > > > > WW-2494
>> > > > >
>> > > > > Modified:
>> > > > >
>> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
>> > > > >
>> > > > > Modified:
>> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
>> > > > > URL:
>> > > > > http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
>> > > > > ==============================================================================
>> > > > > ---
>> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
>> > > > > (original)
>> > > > > +++
>> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
>> > > > > Sat Feb 16 06:01:29 2008
>> > > > > @@ -3,7 +3,9 @@
>> > > > > public class Struts2PortletTest extends BasePortletTest {
>> > > > >
>> > > > > private final static String PORTLET_NAME =
>> > > > > "StrutsPortlet";
>> > > > > -
>> > > > > +
>> > > > > + public void testNone() {}
>> > > > > +/*
>> > > > > public void testIndexPage() throws Exception {
>> > > > > beginAt("pluto/index.jsp");
>> > > > > assertTextPresent("Welcome to the Struts example
>> > > > > portlet");
>> > > > > @@ -74,7 +76,7 @@
>> > > > > switchEdit();
>> > > > > assertTextPresent("Back to view mode");
>> > > > > }
>> > > > > -
>> > > > > +*/
>> > > > > @Override
>> > > > > public String getPortletName() {
>> > > > > return PORTLET_NAME;
>> > > > >
>> > > > >
>> > > > >
>> > > >
>> > > > ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > > > For additional commands, e-mail: dev-help@struts.apache.org
>> > > >
>> > > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > > For additional commands, e-mail: dev-help@struts.apache.org
>> > >
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > For additional commands, e-mail: dev-help@struts.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
On Feb 17, 2008 8:00 PM, Wendy Smoak <ws...@gmail.com> wrote:
>
> The Maven team is voting on Surefire 2.4.2 right now. Assuming
> nothing major pops up it should be available this week.
>
Surefire 2.4.2-SNAPSHOT seems to work ok.
Nils-H
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Wendy Smoak <ws...@gmail.com>.
On Feb 16, 2008 8:54 PM, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> I agree, but as I understood from another message, the updated
> dependency to TestNG would have to be reversed if we lock the surefire
> plugin down to 2.3. If that's not a major issue, I guess that's the
> easiest way to solve the problem.
The Maven team is voting on Surefire 2.4.2 right now. Assuming
nothing major pops up it should be available this week.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
I agree, but as I understood from another message, the updated
dependency to TestNG would have to be reversed if we lock the surefire
plugin down to 2.3. If that's not a major issue, I guess that's the
easiest way to solve the problem.
Nils-H
On Feb 17, 2008 3:22 AM, Wendy Smoak <ws...@gmail.com> wrote:
> On Feb 16, 2008 12:29 PM, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > If
> > I set the plugin version back to the previous release (2.3) it runs
> > perfectly. But with the new 2.4 version, the test breaks... 2.4.1
> > doesn't work either. So what do we do? I guess hard coding the version
> > to 2.3 isn't a very good option?
>
> Actually all plugin versions should be locked down so you're not
> surprised by the auto-updates. Adding a <version> for surefire is a
> good idea.
>
> (The Maven devs have already acknowledged that auto-updating was a bad
> idea... It's likely to be removed in 2.1.)
>
> --
> Wendy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Wendy Smoak <ws...@gmail.com>.
On Feb 16, 2008 12:29 PM, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> If
> I set the plugin version back to the previous release (2.3) it runs
> perfectly. But with the new 2.4 version, the test breaks... 2.4.1
> doesn't work either. So what do we do? I guess hard coding the version
> to 2.3 isn't a very good option?
Actually all plugin versions should be locked down so you're not
surprised by the auto-updates. Adding a <version> for surefire is a
good idea.
(The Maven devs have already acknowledged that auto-updating was a bad
idea... It's likely to be removed in 2.1.)
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
You're spot on, Don! I think I remember you mentioning in your blog
(about the forked Maven initiative) the automatic plugin upgrades as a
big drawback. Well, guess what. I've traced it down to beeing an
upgrade of the maven-surefire-plugin which is breaking the test... If
I set the plugin version back to the previous release (2.3) it runs
perfectly. But with the new 2.4 version, the test breaks... 2.4.1
doesn't work either. So what do we do? I guess hard coding the version
to 2.3 isn't a very good option?
Nils-H
On Feb 16, 2008 3:16 PM, Don Brown <mr...@twdata.org> wrote:
> Yay Maven... *ducks* :)
>
>
> Don
>
> On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > I know. I've tried locally as well. It's not very obvious what the
> > problem could be. This test has been running without problems for a
> > long time no (after some initial start up problems...), so there's no
> > reason it suddenly should fail.
> >
> > Nils-H
> >
> > On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> > > I explicitly removed the 2.4 servlet jar that was leaking in, but that
> > > only seemed to fix the method not found exception I was seeing. I
> > > even tried including jstl but that didn't seem to help.
> > >
> > > Don
> > >
> > >
> > > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > > I don't know why the test have started to fail, but it appears that
> > > > some updated dependency version somewhere has caused a
> > > > dependency-classloader-clash.... The prime suspect is a conflicting
> > > > version of servlet-api indirectly included somewhere...
> > > >
> > > > Nils-H
> > > >
> > > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > > > Author: mrdon
> > > > > Date: Sat Feb 16 06:01:29 2008
> > > > > New Revision: 628298
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > > > Log:
> > > > > Commenting out tests for now
> > > > > WW-2494
> > > > >
> > > > > Modified:
> > > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > >
> > > > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > > > ==============================================================================
> > > > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > > > @@ -3,7 +3,9 @@
> > > > > public class Struts2PortletTest extends BasePortletTest {
> > > > >
> > > > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > > > -
> > > > > +
> > > > > + public void testNone() {}
> > > > > +/*
> > > > > public void testIndexPage() throws Exception {
> > > > > beginAt("pluto/index.jsp");
> > > > > assertTextPresent("Welcome to the Struts example portlet");
> > > > > @@ -74,7 +76,7 @@
> > > > > switchEdit();
> > > > > assertTextPresent("Back to view mode");
> > > > > }
> > > > > -
> > > > > +*/
> > > > > @Override
> > > > > public String getPortletName() {
> > > > > return PORTLET_NAME;
> > > > >
> > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > > For additional commands, e-mail: dev-help@struts.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Don Brown <mr...@twdata.org>.
Yay Maven... *ducks* :)
Don
On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> I know. I've tried locally as well. It's not very obvious what the
> problem could be. This test has been running without problems for a
> long time no (after some initial start up problems...), so there's no
> reason it suddenly should fail.
>
> Nils-H
>
> On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> > I explicitly removed the 2.4 servlet jar that was leaking in, but that
> > only seemed to fix the method not found exception I was seeing. I
> > even tried including jstl but that didn't seem to help.
> >
> > Don
> >
> >
> > On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > > I don't know why the test have started to fail, but it appears that
> > > some updated dependency version somewhere has caused a
> > > dependency-classloader-clash.... The prime suspect is a conflicting
> > > version of servlet-api indirectly included somewhere...
> > >
> > > Nils-H
> > >
> > > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > > Author: mrdon
> > > > Date: Sat Feb 16 06:01:29 2008
> > > > New Revision: 628298
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > > Log:
> > > > Commenting out tests for now
> > > > WW-2494
> > > >
> > > > Modified:
> > > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > >
> > > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > > ==============================================================================
> > > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > > @@ -3,7 +3,9 @@
> > > > public class Struts2PortletTest extends BasePortletTest {
> > > >
> > > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > > -
> > > > +
> > > > + public void testNone() {}
> > > > +/*
> > > > public void testIndexPage() throws Exception {
> > > > beginAt("pluto/index.jsp");
> > > > assertTextPresent("Welcome to the Struts example portlet");
> > > > @@ -74,7 +76,7 @@
> > > > switchEdit();
> > > > assertTextPresent("Back to view mode");
> > > > }
> > > > -
> > > > +*/
> > > > @Override
> > > > public String getPortletName() {
> > > > return PORTLET_NAME;
> > > >
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
I know. I've tried locally as well. It's not very obvious what the
problem could be. This test has been running without problems for a
long time no (after some initial start up problems...), so there's no
reason it suddenly should fail.
Nils-H
On Feb 16, 2008 3:08 PM, Don Brown <mr...@twdata.org> wrote:
> I explicitly removed the 2.4 servlet jar that was leaking in, but that
> only seemed to fix the method not found exception I was seeing. I
> even tried including jstl but that didn't seem to help.
>
> Don
>
>
> On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> > I don't know why the test have started to fail, but it appears that
> > some updated dependency version somewhere has caused a
> > dependency-classloader-clash.... The prime suspect is a conflicting
> > version of servlet-api indirectly included somewhere...
> >
> > Nils-H
> >
> > On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > > Author: mrdon
> > > Date: Sat Feb 16 06:01:29 2008
> > > New Revision: 628298
> > >
> > > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > > Log:
> > > Commenting out tests for now
> > > WW-2494
> > >
> > > Modified:
> > > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > >
> > > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > > ==============================================================================
> > > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > > @@ -3,7 +3,9 @@
> > > public class Struts2PortletTest extends BasePortletTest {
> > >
> > > private final static String PORTLET_NAME = "StrutsPortlet";
> > > -
> > > +
> > > + public void testNone() {}
> > > +/*
> > > public void testIndexPage() throws Exception {
> > > beginAt("pluto/index.jsp");
> > > assertTextPresent("Welcome to the Struts example portlet");
> > > @@ -74,7 +76,7 @@
> > > switchEdit();
> > > assertTextPresent("Back to view mode");
> > > }
> > > -
> > > +*/
> > > @Override
> > > public String getPortletName() {
> > > return PORTLET_NAME;
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Don Brown <mr...@twdata.org>.
I explicitly removed the 2.4 servlet jar that was leaking in, but that
only seemed to fix the method not found exception I was seeing. I
even tried including jstl but that didn't seem to help.
Don
On 2/17/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
> I don't know why the test have started to fail, but it appears that
> some updated dependency version somewhere has caused a
> dependency-classloader-clash.... The prime suspect is a conflicting
> version of servlet-api indirectly included somewhere...
>
> Nils-H
>
> On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> > Author: mrdon
> > Date: Sat Feb 16 06:01:29 2008
> > New Revision: 628298
> >
> > URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> > Log:
> > Commenting out tests for now
> > WW-2494
> >
> > Modified:
> > struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> >
> > Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> > URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> > ==============================================================================
> > --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> > +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> > @@ -3,7 +3,9 @@
> > public class Struts2PortletTest extends BasePortletTest {
> >
> > private final static String PORTLET_NAME = "StrutsPortlet";
> > -
> > +
> > + public void testNone() {}
> > +/*
> > public void testIndexPage() throws Exception {
> > beginAt("pluto/index.jsp");
> > assertTextPresent("Welcome to the Struts example portlet");
> > @@ -74,7 +76,7 @@
> > switchEdit();
> > assertTextPresent("Back to view mode");
> > }
> > -
> > +*/
> > @Override
> > public String getPortletName() {
> > return PORTLET_NAME;
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
I don't know why the test have started to fail, but it appears that
some updated dependency version somewhere has caused a
dependency-classloader-clash.... The prime suspect is a conflicting
version of servlet-api indirectly included somewhere...
Nils-H
On Feb 16, 2008 3:01 PM, <mr...@apache.org> wrote:
> Author: mrdon
> Date: Sat Feb 16 06:01:29 2008
> New Revision: 628298
>
> URL: http://svn.apache.org/viewvc?rev=628298&view=rev
> Log:
> Commenting out tests for now
> WW-2494
>
> Modified:
> struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
>
> Modified: struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java
> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java?rev=628298&r1=628297&r2=628298&view=diff
> ==============================================================================
> --- struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java (original)
> +++ struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java Sat Feb 16 06:01:29 2008
> @@ -3,7 +3,9 @@
> public class Struts2PortletTest extends BasePortletTest {
>
> private final static String PORTLET_NAME = "StrutsPortlet";
> -
> +
> + public void testNone() {}
> +/*
> public void testIndexPage() throws Exception {
> beginAt("pluto/index.jsp");
> assertTextPresent("Welcome to the Struts example portlet");
> @@ -74,7 +76,7 @@
> switchEdit();
> assertTextPresent("Back to view mode");
> }
> -
> +*/
> @Override
> public String getPortletName() {
> return PORTLET_NAME;
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org