You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/19 12:47:56 UTC

[GitHub] [camel] fvaleri opened a new pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

fvaleri opened a new pull request #3838:
URL: https://github.com/apache/camel/pull/3838


   Running JdbcAggregationRepository on a distributed environment (multiple independent
   threads or multiple JVMs) we have silently dropped exchanges. This PR aims at introducing
   a version identifier to avoid the lost update problem (overwrites when updating the
   aggregate row) as stated by the OptimisticLockingAggregationRepository SPI.
   
   Tested running 100 threads to aggregate 10k messages on MySQL 5.7 and PostgreSQL 11.5.
   
   **Do not merge yet.** I'm having some problems running [my test application](https://github.com/fvaleri/integ-examples/blob/master/standalone/distributed-aggr/src/main/java/it/fvaleri/integ/Application.java) with the new routing engine. Will look at it later and once fixed we could add it as an example or test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631261754


   Okay thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631227930


   Okay let us know when its ready for merge


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fvaleri commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631282505


   Sure, no problem. Should be rebased now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631299936


   Perfect


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fvaleri commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631260224


   Yeah. The optimistic locking is working fine and all tests are green. 
   
   The issue with the test app doesn't seem to be related to the PR. Same code is working on 2.25.x branch, instead on master it is unable to fully complete the aggregation when I raise the number of threads and hit some version conflicts that require some redeliveries (i.e. 20 threads for 100 msgs). I see all these exchanges at the end waiting for the ansync callback. Just need to find some time to figure out where is the problem.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus merged pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #3838:
URL: https://github.com/apache/camel/pull/3838


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fvaleri edited a comment on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
fvaleri edited a comment on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631260224


   Yeah. The optimistic locking is working fine and all tests are green. 
   
   The issue with my test application doesn't seem to be related to the PR. Same code is working on 2.25.x branch, instead on master it is unable to fully complete the aggregation when I raise the number of threads and hit some version conflicts that require some redeliveries (i.e. 20 threads for 100 msgs). I see all these exchanges at the end waiting for the ansync callback. Just need to find some time to figure out where is the problem.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fvaleri commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631273702


   Yep, it's already there :)
   https://github.com/apache/camel/blob/282044701e9c60b7a5c28ce3554fb230af8f5fb7/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_4.adoc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631275050


   Ah thanks that is great. Oh we changed the doc upstream, wonder if you could resolve the conflict in this PR, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #3838: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature (master)

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3838:
URL: https://github.com/apache/camel/pull/3838#issuecomment-631262052


   Do you mind adding a note to the 3.4 upgrade guide in this PR
   https://github.com/apache/camel/blob/master/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_4.adoc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org