[GitHub] [ozone] kaijchen commented on a diff in pull request #3226: HDDS-6491. Support FSO keys in getExpiredOpenKeys

[GitBox <gi...@apache.org>]

kaijchen commented on code in PR #3226:
URL: https://github.com/apache/ozone/pull/3226#discussion_r843433884


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1190,28 +1193,54 @@ private PersistedUserVolumeInfo getVolumesByUser(String userNameKey)
   }
 
   @Override
-  public List<String> getExpiredOpenKeys(Duration expireThreshold,
-      int count) throws IOException {
+  public List<OmOpenKeyInfo> getExpiredOpenKeys(Duration expireThreshold,
+      int limit) throws IOException {
+    BucketLayout first, second;
+    if (random.nextBoolean()) {

Review Comment:
   This might be changed to 2 different methods as discussion in #3235.
   If we are still using this logic, I will add javadoc to explain it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org