You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Michael Wechner <mi...@wyona.org> on 2003/06/23 00:55:03 UTC
ResourceExistsAction
I have "patched" the ResourceExistsAction in the case of the resources
sitemap pipeline (file-exists), such that
it only checks files and not directories. Therefore URLs such as
.../oscom/authoring/ are working
again, but it seems to me that this is just a quick fix and we need to
think of something better.
Thanks
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Gianugo Rabellino <gi...@apache.org>.
Michael Wechner wrote:
>>> I have "patched" the ResourceExistsAction in the case of the
>>> resources sitemap pipeline (file-exists), such that
>>> it only checks files and not directories. Therefore URLs such as
>>> .../oscom/authoring/ are working
>>> again, but it seems to me that this is just a quick fix and we need
>>> to think of something better.
>>
>>
>>
>> Would you guys please consider avoiding code duplication between Lenya
>> and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
>> with a change of package and a one liner added. This is a bit
>> unethical, technically poor and, most of all, misleading for users
>> that will find two ResourceExistsAction and won't know exactly which
>> is which. At a very least, please consider renaming it to something
>> like FileExistsAction.
>
>
> agreed. But what about enhancing the ResourceExistsAction, such that one
> can configure it only to check on files or directories or both?
>
> Would Cocoon be interested in a patch like this?
Personally I would: more features are always interesting.
Ciao,
--
Gianugo Rabellino
Pro-netics s.r.l. - http://www.pro-netics.com
Orixo, the XML business alliance - http://www.orixo.com
(Now blogging at: http://blogs.cocoondev.org/gianugo/)
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Jeff Turner wrote:
> Michael Wechner wrote:
<snip />
>>
>
> If it seems to work and you've got commit access, I'd say just add it
> to CVS. People will review the commit log and hopefully spot any big
> problems.
ok. But I think I will wait until Cocooners make a decision if
committers from subprojects should be able to commit or not to the
top-level project.
But anyway, I guess it also makes a difference because Lenya is within
the incubation process and is not a real subproject yet.
In case anyone would like to review the patch in the meantime (it's just
a couple of lines), just let me know ;-)
Thanks
Michael
>
>
>
> --Jeff
>
>>
>> Thanks
>>
>> Michael
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Jeff Turner wrote:
> Michael Wechner wrote:
<snip />
>>
>
> If it seems to work and you've got commit access, I'd say just add it
> to CVS. People will review the commit log and hopefully spot any big
> problems.
ok. But I think I will wait until Cocooners make a decision if
committers from subprojects should be able to commit or not to the
top-level project.
But anyway, I guess it also makes a difference because Lenya is within
the incubation process and is not a real subproject yet.
In case anyone would like to review the patch in the meantime (it's just
a couple of lines), just let me know ;-)
Thanks
Michael
>
>
>
> --Jeff
>
>>
>> Thanks
>>
>> Michael
>
>
>
>
Re: ResourceExistsAction
Posted by Jeff Turner <je...@apache.org>.
Michael Wechner wrote:
> Jeff Turner wrote:
>
>> On Mon, Jun 23, 2003 at 11:08:25AM +0200, Michael Wechner wrote:
>>
>
> <snip />
>
>>> Would Cocoon be interested in a patch like this?
>>
>>
>>
>> If you're using 2.1 and doing if-then-else logic, it might be better to
>> modify the ResourceExistsSelector.
>
>
>
> right I saw that within the Javadoc after I already started on the
> patch. Well, the patch of the ResourceExistsAction is ready (I tested it
> on Cocoon-2.1-M1 together with Lenya). Jeff, shall I send the patch to you?
If it seems to work and you've got commit access, I'd say just add it to
CVS. People will review the commit log and hopefully spot any big problems.
--Jeff
>
> Thanks
>
> Michael
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Jeff Turner wrote:
> On Mon, Jun 23, 2003 at 11:08:25AM +0200, Michael Wechner wrote:
>
<snip />
>>Would Cocoon be interested in a patch like this?
>
>
> If you're using 2.1 and doing if-then-else logic, it might be better to
> modify the ResourceExistsSelector.
right I saw that within the Javadoc after I already started on the
patch. Well, the patch of the ResourceExistsAction is ready (I tested it
on Cocoon-2.1-M1 together with Lenya). Jeff, shall I send the patch to you?
Thanks
Michael
Eg, comparing:
>
> <map:act type="resource-exists">
> <map:parameter name="url" value="content/xdocs/{1}{2}" />
> <map:generate src="content/xdocs/{../1}{../2}" />
> ...
> <map:serialize type="xml"/>
> </map:act>
> <!-- stuff to do if resource doesn't exist -->
>
> with:
>
> <map:select type="exists">
> <map:when test="content/xdocs/{1}{2}">
> <map:generate src="content/xdocs/{1}{2}" />
> ...
> <map:serialize type="xml"/>
> </map:when>
> <map:otherwise>
> <!-- stuff to do if resource doesn't exist -->
> </map:otherwise>
> </map:select>
>
> Making a FileExistsSelector and DirectoryExistsSelector from this
> wouldn't be hard.
>
>
> --Jeff
>
>
>>Thanks
>>
>>Michael
>>
>>
>>
>>>Ciao,
>>>
>
>
--
Michael Wechner
Wyona Ltd. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://cocoon.apache.org/lenya/
michael.wechner@wyona.com michi@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Jeff Turner wrote:
> On Mon, Jun 23, 2003 at 11:08:25AM +0200, Michael Wechner wrote:
>
<snip />
>>Would Cocoon be interested in a patch like this?
>
>
> If you're using 2.1 and doing if-then-else logic, it might be better to
> modify the ResourceExistsSelector.
right I saw that within the Javadoc after I already started on the
patch. Well, the patch of the ResourceExistsAction is ready (I tested it
on Cocoon-2.1-M1 together with Lenya). Jeff, shall I send the patch to you?
Thanks
Michael
Eg, comparing:
>
> <map:act type="resource-exists">
> <map:parameter name="url" value="content/xdocs/{1}{2}" />
> <map:generate src="content/xdocs/{../1}{../2}" />
> ...
> <map:serialize type="xml"/>
> </map:act>
> <!-- stuff to do if resource doesn't exist -->
>
> with:
>
> <map:select type="exists">
> <map:when test="content/xdocs/{1}{2}">
> <map:generate src="content/xdocs/{1}{2}" />
> ...
> <map:serialize type="xml"/>
> </map:when>
> <map:otherwise>
> <!-- stuff to do if resource doesn't exist -->
> </map:otherwise>
> </map:select>
>
> Making a FileExistsSelector and DirectoryExistsSelector from this
> wouldn't be hard.
>
>
> --Jeff
>
>
>>Thanks
>>
>>Michael
>>
>>
>>
>>>Ciao,
>>>
>
>
--
Michael Wechner
Wyona Ltd. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://cocoon.apache.org/lenya/
michael.wechner@wyona.com michi@apache.org
Re: ResourceExistsAction
Posted by Jeff Turner <je...@apache.org>.
On Mon, Jun 23, 2003 at 11:08:25AM +0200, Michael Wechner wrote:
> Gianugo Rabellino wrote:
> >Michael Wechner wrote:
> >
> >>I have "patched" the ResourceExistsAction in the case of the resources
> >>sitemap pipeline (file-exists), such that
> >>it only checks files and not directories. Therefore URLs such as
> >>.../oscom/authoring/ are working
> >>again, but it seems to me that this is just a quick fix and we need to
> >>think of something better.
> >
> >
> >Would you guys please consider avoiding code duplication between Lenya
> >and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> >with a change of package and a one liner added. This is a bit unethical,
> >technically poor and, most of all, misleading for users that will find
> >two ResourceExistsAction and won't know exactly which is which. At a
> >very least, please consider renaming it to something like FileExistsAction.
>
> agreed. But what about enhancing the ResourceExistsAction, such that one
> can configure it only to check on files or directories or both?
>
> Would Cocoon be interested in a patch like this?
If you're using 2.1 and doing if-then-else logic, it might be better to
modify the ResourceExistsSelector. Eg, comparing:
<map:act type="resource-exists">
<map:parameter name="url" value="content/xdocs/{1}{2}" />
<map:generate src="content/xdocs/{../1}{../2}" />
...
<map:serialize type="xml"/>
</map:act>
<!-- stuff to do if resource doesn't exist -->
with:
<map:select type="exists">
<map:when test="content/xdocs/{1}{2}">
<map:generate src="content/xdocs/{1}{2}" />
...
<map:serialize type="xml"/>
</map:when>
<map:otherwise>
<!-- stuff to do if resource doesn't exist -->
</map:otherwise>
</map:select>
Making a FileExistsSelector and DirectoryExistsSelector from this
wouldn't be hard.
--Jeff
> Thanks
>
> Michael
>
>
> >
> >Ciao,
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Jeff Turner <je...@apache.org>.
On Mon, Jun 23, 2003 at 11:08:25AM +0200, Michael Wechner wrote:
> Gianugo Rabellino wrote:
> >Michael Wechner wrote:
> >
> >>I have "patched" the ResourceExistsAction in the case of the resources
> >>sitemap pipeline (file-exists), such that
> >>it only checks files and not directories. Therefore URLs such as
> >>.../oscom/authoring/ are working
> >>again, but it seems to me that this is just a quick fix and we need to
> >>think of something better.
> >
> >
> >Would you guys please consider avoiding code duplication between Lenya
> >and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> >with a change of package and a one liner added. This is a bit unethical,
> >technically poor and, most of all, misleading for users that will find
> >two ResourceExistsAction and won't know exactly which is which. At a
> >very least, please consider renaming it to something like FileExistsAction.
>
> agreed. But what about enhancing the ResourceExistsAction, such that one
> can configure it only to check on files or directories or both?
>
> Would Cocoon be interested in a patch like this?
If you're using 2.1 and doing if-then-else logic, it might be better to
modify the ResourceExistsSelector. Eg, comparing:
<map:act type="resource-exists">
<map:parameter name="url" value="content/xdocs/{1}{2}" />
<map:generate src="content/xdocs/{../1}{../2}" />
...
<map:serialize type="xml"/>
</map:act>
<!-- stuff to do if resource doesn't exist -->
with:
<map:select type="exists">
<map:when test="content/xdocs/{1}{2}">
<map:generate src="content/xdocs/{1}{2}" />
...
<map:serialize type="xml"/>
</map:when>
<map:otherwise>
<!-- stuff to do if resource doesn't exist -->
</map:otherwise>
</map:select>
Making a FileExistsSelector and DirectoryExistsSelector from this
wouldn't be hard.
--Jeff
> Thanks
>
> Michael
>
>
> >
> >Ciao,
> >
Re: ResourceExistsAction
Posted by Nicola Ken Barozzi <ni...@apache.org>.
Stefano Mazzocchi wrote, On 24/06/2003 0.53:
> on 6/23/03 6:22 AM Steven Noels wrote:
>
>>>>On 23/06/2003 11:18 John Morrison wrote:
>>
>>>Sure! Patches always welcome :)
>>
>>Technically, all Lenya people have Cocoon CVS commit karma if I read the
>>avail file correctly.
>
>
> Hmmm, if this is the case, that even Forrest committers has to have this
> kind of right. but, BTW, are we sure we want to allow committers of
> projects based on cocoon to have direct access to cocoon?
Same as Avalon has done with the Avalon Components repository. In our
case it would be to the blocks dir.
> in theory, I see nothing wrong since they are all part of the family and
> they normally end up having commit access on both projects anyway, but
> making it automatic could be too much.
I'd say it's ok for me. It's a bit wierd as it's commit access without
project voting rights on the core Cocoon (IIUC) but I like it.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
Re: ResourceExistsAction
Posted by Nicola Ken Barozzi <ni...@apache.org>.
Stefano Mazzocchi wrote, On 24/06/2003 0.53:
> on 6/23/03 6:22 AM Steven Noels wrote:
>
>>>>On 23/06/2003 11:18 John Morrison wrote:
>>
>>>Sure! Patches always welcome :)
>>
>>Technically, all Lenya people have Cocoon CVS commit karma if I read the
>>avail file correctly.
>
>
> Hmmm, if this is the case, that even Forrest committers has to have this
> kind of right. but, BTW, are we sure we want to allow committers of
> projects based on cocoon to have direct access to cocoon?
Same as Avalon has done with the Avalon Components repository. In our
case it would be to the blocks dir.
> in theory, I see nothing wrong since they are all part of the family and
> they normally end up having commit access on both projects anyway, but
> making it automatic could be too much.
I'd say it's ok for me. It's a bit wierd as it's commit access without
project voting rights on the core Cocoon (IIUC) but I like it.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: commit access on Cocoon for sub project committers
Posted by Steven Noels <st...@outerthought.org>.
On 25/06/2003 22:54 Michael Wechner wrote:
> well, does that mean I should checkin the patched
> "ResourceExistsAction"? It seems to me that the whole dicussion about
> checking in the ResourceExistsAction got a bit sidetracked ;-)
Sure, go ahead. If you'd feel better by adding a [PATCH] in Bugzilla for
peer review, fine as well.
</Steven>
--
Steven Noels http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/stevenn/
stevenn at outerthought.org stevenn at apache.org
Re: commit access on Cocoon for sub project committers
Posted by Michael Wechner <mi...@apache.org>.
Steven Noels wrote:
> On 24/06/2003 10:02 Michael Wechner wrote:
<snip />
>
> avail|stefano,balld,ricardo,rubys,ben,zvia,giacomo,gears,bmclaugh,bloritsch,rossb,jeremy,greenrd,dims,ssahuc,prussell,cziegeler,mman,sylvain,vgritsenko,haul,morrijr,crossley,ovidiu,tcurdt,gianugo,froehlich,huber,dirkx,butlermh,nicolaken,ivelin,kpiroumian,shannon,proyal,stephan,coliver,crafterm,acoliver,stevenn,bdelacretaz,mlangham,michaelm,jefft,pier,bruno,asavory,ghoward,andreas,alexmcl,egli,gregor,michi,edith,felix,liyanage,memo,thorsten,joerg,upayavira|xml-site,xml-commons,cocoon-1,cocoon-2-historical,cocoon-2.0,cocoon-2.1,cocoon-lenya,cocoon-site,avalon-excalibur,avalon-sandbox
>
> So Lenya peeps have access to ours, and we have access to theirs.
>
> The fact that it has been set up that way doesn't reflect any policy,
> it was just the guy who set it up who fancied this would be a decent
> setup. I find it reasonable as well. We are supposed to review commit
> messages anyhow,
well, does that mean I should checkin the patched
"ResourceExistsAction"? It seems to me that the whole dicussion about
checking in the ResourceExistsAction got a bit sidetracked ;-)
Thanks
Michael
> and it seems like a nice way to warn people they should think twice
> before bringing on new subprojects or committers.
>
> IMHO, XML and Jakarta are impenetrable forests of projects because of
> overcompartimentalisation and putting large walls between cubicles.
>
> If anyone wants to see this changed, please speak up.
>
> </Steven>
Re: commit access on Cocoon for sub project committers
Posted by Steven Noels <st...@outerthought.org>.
On 24/06/2003 10:02 Michael Wechner wrote:
>> and here. If people are already committers for a sub project, there is
>> no problem if they (or their community) ask for committer access on
>> Cocoon. Similar like Cocoon/Excalibur.
>>
>> Cocoon committers don't have commit access on the sub projects, do they?
>
>
>
> AFAIK they do
They do. Here's our avail settings:
avail|stefano,balld,ricardo,rubys,ben,zvia,giacomo,gears,bmclaugh,bloritsch,rossb,jeremy,greenrd,dims,ssahuc,prussell,cziegeler,mman,sylvain,vgritsenko,haul,morrijr,crossley,ovidiu,tcurdt,gianugo,froehlich,huber,dirkx,butlermh,nicolaken,ivelin,kpiroumian,shannon,proyal,stephan,coliver,crafterm,acoliver,stevenn,bdelacretaz,mlangham,michaelm,jefft,pier,bruno,asavory,ghoward,andreas,alexmcl,egli,gregor,michi,edith,felix,liyanage,memo,thorsten,joerg,upayavira|xml-site,xml-commons,cocoon-1,cocoon-2-historical,cocoon-2.0,cocoon-2.1,cocoon-lenya,cocoon-site,avalon-excalibur,avalon-sandbox
So Lenya peeps have access to ours, and we have access to theirs.
The fact that it has been set up that way doesn't reflect any policy, it
was just the guy who set it up who fancied this would be a decent setup.
I find it reasonable as well. We are supposed to review commit messages
anyhow, and it seems like a nice way to warn people they should think
twice before bringing on new subprojects or committers.
IMHO, XML and Jakarta are impenetrable forests of projects because of
overcompartimentalisation and putting large walls between cubicles.
If anyone wants to see this changed, please speak up.
</Steven>
--
Steven Noels http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/stevenn/
stevenn at outerthought.org stevenn at apache.org
Re: commit access on Cocoon for sub project committers
Posted by Michael Wechner <mi...@wyona.org>.
Joerg Heinicke wrote:
<snip />
>
> and here. If people are already committers for a sub project, there is
> no problem if they (or their community) ask for committer access on
> Cocoon. Similar like Cocoon/Excalibur.
>
> Cocoon committers don't have commit access on the sub projects, do they?
AFAIK they do
Michael
>
>
> Joerg
>
>
Re: commit access on Cocoon for sub project committers
Posted by Nicola Ken Barozzi <ni...@apache.org>.
David Crossley wrote, On 24/06/2003 10.23:
> Gianugo Rabellino wrote:
>
>>Joerg Heinicke wrote:
>>
>>
>>>>Hmmm, if this is the case, that even Forrest committers has to have this
>>>>kind of right.
>>>
>>>[RT] Why Forrest is not/does not become a subproject of Cocoon while
>>>it's so heavily based on it?
>>
>>Definitely something to consider, it makes a lot of sense.
>
>
> It does make sense. The hiatus is because Forrest started before Cocoon
> even thought about sub-projects. Also Cocoon moved out of xml.apache.org
> to be a top-level project and left Forrest behind.
Actually IIRC Forresters were proposed with the opportunity but
preferred to remain at Xml.Apache. Don't know if a proposal would have
the same result now.
David, please bring this up on Forrest-dev to see what others think of this.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
Re: commit access on Cocoon for sub project committers
Posted by David Crossley <cr...@indexgeo.com.au>.
Gianugo Rabellino wrote:
> Joerg Heinicke wrote:
>
> >> Hmmm, if this is the case, that even Forrest committers has to have this
> >> kind of right.
> >
> > [RT] Why Forrest is not/does not become a subproject of Cocoon while
> > it's so heavily based on it?
>
> Definitely something to consider, it makes a lot of sense.
It does make sense. The hiatus is because Forrest started before Cocoon
even thought about sub-projects. Also Cocoon moved out of xml.apache.org
to be a top-level project and left Forrest behind.
--David
Re: commit access on Cocoon for sub project committers
Posted by Gianugo Rabellino <gi...@apache.org>.
Joerg Heinicke wrote:
>> Hmmm, if this is the case, that even Forrest committers has to have this
>> kind of right.
>
> [RT] Why Forrest is not/does not become a subproject of Cocoon while
> it's so heavily based on it?
Definitely something to consider, it makes a lot of sense.
Ciao,
--
Gianugo Rabellino
Pro-netics s.r.l. - http://www.pro-netics.com
Orixo, the XML business alliance - http://www.orixo.com
(Now blogging at: http://blogs.cocoondev.org/gianugo/)
commit access on Cocoon for sub project committers (was: ResourceExistsAction)
Posted by Joerg Heinicke <jo...@gmx.de>.
Stefano Mazzocchi wrote:
>>Technically, all Lenya people have Cocoon CVS commit karma if I read the
>>avail file correctly.
>
> Hmmm, if this is the case, that even Forrest committers has to have this
> kind of right.
[RT] Why Forrest is not/does not become a subproject of Cocoon while
it's so heavily based on it?
> but, BTW, are we sure we want to allow committers of
> projects based on cocoon to have direct access to cocoon?
We have no influence on the votes I guess? At the moment it's easy to
have a look on the sub project votes, but what if the Cocoon community
or at least the number of sub projects will grow?
> in theory, I see nothing wrong since they are all part of the family and
> they normally end up having commit access on both projects anyway,
Same opinion here
> but making it automatic could be too much.
and here. If people are already committers for a sub project, there is
no problem if they (or their community) ask for committer access on
Cocoon. Similar like Cocoon/Excalibur.
Cocoon committers don't have commit access on the sub projects, do they?
Joerg
Re: ResourceExistsAction
Posted by Vadim Gritsenko <va...@verizon.net>.
Stefano Mazzocchi wrote:
>on 6/23/03 6:22 AM Steven Noels wrote:
>
>
>
>>On 23/06/2003 11:18 John Morrison wrote:
>>
>>
>>
>>>Sure! Patches always welcome :)
>>>
>>>
>>Technically, all Lenya people have Cocoon CVS commit karma if I read the
>>avail file correctly.
>>
>>
>
>Hmmm, if this is the case, that even Forrest committers has to have this
>kind of right. but, BTW, are we sure we want to allow committers of
>projects based on cocoon to have direct access to cocoon?
>
>in theory, I see nothing wrong since they are all part of the family and
>they normally end up having commit access on both projects anyway,
>
(not necesserely...)
>but making it automatic could be too much.
>
>what you all think about this?
>
My feelings are similar.
Vadim
Re: ResourceExistsAction
Posted by Stefano Mazzocchi <st...@apache.org>.
on 6/23/03 6:22 AM Steven Noels wrote:
> On 23/06/2003 11:18 John Morrison wrote:
>
>
>>Sure! Patches always welcome :)
>
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
Hmmm, if this is the case, that even Forrest committers has to have this
kind of right. but, BTW, are we sure we want to allow committers of
projects based on cocoon to have direct access to cocoon?
in theory, I see nothing wrong since they are all part of the family and
they normally end up having commit access on both projects anyway, but
making it automatic could be too much.
what you all think about this?
--
Stefano.
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Steven Noels wrote:
> On 23/06/2003 11:18 John Morrison wrote:
>
>> Sure! Patches always welcome :)
>
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
since I haven't contributed code to Cocoon so far, I would prefer that
somebody is reviewing the code before it's being checked-in.
Thanks
Michael
>
> </Steven>
--
Michael Wechner
Wyona Ltd. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://cocoon.apache.org/lenya/
michael.wechner@wyona.com michi@apache.org
Re: ResourceExistsAction
Posted by Stefano Mazzocchi <st...@apache.org>.
on 6/23/03 6:22 AM Steven Noels wrote:
> On 23/06/2003 11:18 John Morrison wrote:
>
>
>>Sure! Patches always welcome :)
>
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
Hmmm, if this is the case, that even Forrest committers has to have this
kind of right. but, BTW, are we sure we want to allow committers of
projects based on cocoon to have direct access to cocoon?
in theory, I see nothing wrong since they are all part of the family and
they normally end up having commit access on both projects anyway, but
making it automatic could be too much.
what you all think about this?
--
Stefano.
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@wyona.org>.
Steven Noels wrote:
> On 23/06/2003 11:18 John Morrison wrote:
>
>> Sure! Patches always welcome :)
>
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
since I haven't contributed code to Cocoon so far, I would prefer that
somebody is reviewing the code before it's being checked-in.
Thanks
Michael
>
> </Steven>
--
Michael Wechner
Wyona Ltd. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://cocoon.apache.org/lenya/
michael.wechner@wyona.com michi@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
RE: ResourceExistsAction
Posted by John Morrison <jo...@ntlworld.com>.
> From: Steven Noels [mailto:stevenn@outerthought.org]
> On 23/06/2003 11:18 John Morrison wrote:
> > Sure! Patches always welcome :)
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
:) In that case it's even easier!
J.
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
RE: ResourceExistsAction
Posted by John Morrison <jo...@ntlworld.com>.
> From: Steven Noels [mailto:stevenn@outerthought.org]
> On 23/06/2003 11:18 John Morrison wrote:
> > Sure! Patches always welcome :)
>
> Technically, all Lenya people have Cocoon CVS commit karma if I read the
> avail file correctly.
:) In that case it's even easier!
J.
Re: ResourceExistsAction
Posted by Steven Noels <st...@outerthought.org>.
On 23/06/2003 11:18 John Morrison wrote:
> Sure! Patches always welcome :)
Technically, all Lenya people have Cocoon CVS commit karma if I read the
avail file correctly.
</Steven>
--
Steven Noels http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/stevenn/
stevenn at outerthought.org stevenn at apache.org
Re: ResourceExistsAction
Posted by Steven Noels <st...@outerthought.org>.
On 23/06/2003 11:18 John Morrison wrote:
> Sure! Patches always welcome :)
Technically, all Lenya people have Cocoon CVS commit karma if I read the
avail file correctly.
</Steven>
--
Steven Noels http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/stevenn/
stevenn at outerthought.org stevenn at apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
RE: ResourceExistsAction
Posted by John Morrison <jo...@ntlworld.com>.
> From: Michael Wechner [mailto:michi@apache.org]
> Gianugo Rabellino wrote:
> > Michael Wechner wrote:
> >
> >> I have "patched" the ResourceExistsAction in the case of the resources
> >> sitemap pipeline (file-exists), such that
> >> it only checks files and not directories. Therefore URLs such as
> >> .../oscom/authoring/ are working
> >> again, but it seems to me that this is just a quick fix and we need to
> >> think of something better.
> >
> >
> > Would you guys please consider avoiding code duplication between Lenya
> > and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> > with a change of package and a one liner added. This is a bit
> unethical,
> > technically poor and, most of all, misleading for users that will find
> > two ResourceExistsAction and won't know exactly which is which. At a
> > very least, please consider renaming it to something like
> FileExistsAction.
>
> agreed. But what about enhancing the ResourceExistsAction, such that one
> can configure it only to check on files or directories or both?
>
> Would Cocoon be interested in a patch like this?
Sure! Patches always welcome :)
J.
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
RE: ResourceExistsAction
Posted by John Morrison <jo...@ntlworld.com>.
> From: Michael Wechner [mailto:michi@apache.org]
> Gianugo Rabellino wrote:
> > Michael Wechner wrote:
> >
> >> I have "patched" the ResourceExistsAction in the case of the resources
> >> sitemap pipeline (file-exists), such that
> >> it only checks files and not directories. Therefore URLs such as
> >> .../oscom/authoring/ are working
> >> again, but it seems to me that this is just a quick fix and we need to
> >> think of something better.
> >
> >
> > Would you guys please consider avoiding code duplication between Lenya
> > and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> > with a change of package and a one liner added. This is a bit
> unethical,
> > technically poor and, most of all, misleading for users that will find
> > two ResourceExistsAction and won't know exactly which is which. At a
> > very least, please consider renaming it to something like
> FileExistsAction.
>
> agreed. But what about enhancing the ResourceExistsAction, such that one
> can configure it only to check on files or directories or both?
>
> Would Cocoon be interested in a patch like this?
Sure! Patches always welcome :)
J.
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@apache.org>.
Gianugo Rabellino wrote:
> Michael Wechner wrote:
>
>> I have "patched" the ResourceExistsAction in the case of the resources
>> sitemap pipeline (file-exists), such that
>> it only checks files and not directories. Therefore URLs such as
>> .../oscom/authoring/ are working
>> again, but it seems to me that this is just a quick fix and we need to
>> think of something better.
>
>
> Would you guys please consider avoiding code duplication between Lenya
> and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> with a change of package and a one liner added. This is a bit unethical,
> technically poor and, most of all, misleading for users that will find
> two ResourceExistsAction and won't know exactly which is which. At a
> very least, please consider renaming it to something like FileExistsAction.
agreed. But what about enhancing the ResourceExistsAction, such that one
can configure it only to check on files or directories or both?
Would Cocoon be interested in a patch like this?
Thanks
Michael
>
> Ciao,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: ResourceExistsAction
Posted by Michael Wechner <mi...@apache.org>.
Gianugo Rabellino wrote:
> Michael Wechner wrote:
>
>> I have "patched" the ResourceExistsAction in the case of the resources
>> sitemap pipeline (file-exists), such that
>> it only checks files and not directories. Therefore URLs such as
>> .../oscom/authoring/ are working
>> again, but it seems to me that this is just a quick fix and we need to
>> think of something better.
>
>
> Would you guys please consider avoiding code duplication between Lenya
> and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
> with a change of package and a one liner added. This is a bit unethical,
> technically poor and, most of all, misleading for users that will find
> two ResourceExistsAction and won't know exactly which is which. At a
> very least, please consider renaming it to something like FileExistsAction.
agreed. But what about enhancing the ResourceExistsAction, such that one
can configure it only to check on files or directories or both?
Would Cocoon be interested in a patch like this?
Thanks
Michael
>
> Ciao,
>
Re: ResourceExistsAction
Posted by Gianugo Rabellino <gi...@apache.org>.
Michael Wechner wrote:
> I have "patched" the ResourceExistsAction in the case of the resources
> sitemap pipeline (file-exists), such that
> it only checks files and not directories. Therefore URLs such as
> .../oscom/authoring/ are working
> again, but it seems to me that this is just a quick fix and we need to
> think of something better.
Would you guys please consider avoiding code duplication between Lenya
and Cocoon? ResourceExistsAction is pure c&p from the Cocoon codebase,
with a change of package and a one liner added. This is a bit unethical,
technically poor and, most of all, misleading for users that will find
two ResourceExistsAction and won't know exactly which is which. At a
very least, please consider renaming it to something like FileExistsAction.
Ciao,
--
Gianugo Rabellino
Pro-netics s.r.l. - http://www.pro-netics.com
Orixo, the XML business alliance - http://www.orixo.com
(Now blogging at: http://blogs.cocoondev.org/gianugo/)
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org