[jira] [Resolved] (SPARK-41905) Function `slice` should handle string in params

["Hyukjin Kwon (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-41905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-41905.
----------------------------------
    Fix Version/s: 3.4.0
       Resolution: Fixed

Issue resolved by pull request 39420
[https://github.com/apache/spark/pull/39420]

> Function `slice` should handle string in params
> -----------------------------------------------
>
>                 Key: SPARK-41905
>                 URL: https://issues.apache.org/jira/browse/SPARK-41905
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Connect
>    Affects Versions: 3.4.0
>            Reporter: Sandeep Singh
>            Assignee: Hyukjin Kwon
>            Priority: Major
>             Fix For: 3.4.0
>
>
> {code:java}
> df = self.spark.createDataFrame(
>     [
>         (
>             [1, 2, 3],
>             2,
>             2,
>         ),
>         (
>             [4, 5],
>             2,
>             2,
>         ),
>     ],
>     ["x", "index", "len"],
> )
> expected = [Row(sliced=[2, 3]), Row(sliced=[5])]
> self.assertTrue(
>     all(
>         [
>             df.select(slice(df.x, 2, 2).alias("sliced")).collect() == expected,
>             df.select(slice(df.x, lit(2), lit(2)).alias("sliced")).collect() == expected,
>             df.select(slice("x", "index", "len").alias("sliced")).collect() == expected,
>         ]
>     )
> )
> self.assertEqual(
>     df.select(slice(df.x, size(df.x) - 1, lit(1)).alias("sliced")).collect(),
>     [Row(sliced=[2]), Row(sliced=[4])],
> )
> self.assertEqual(
>     df.select(slice(df.x, lit(1), size(df.x) - 1).alias("sliced")).collect(),
>     [Row(sliced=[1, 2]), Row(sliced=[4])],
> ){code}
> {code:java}
>  Traceback (most recent call last):
>   File "/Users/s.singh/personal/spark-oss/python/pyspark/sql/tests/test_functions.py", line 596, in test_slice
>     df.select(slice("x", "index", "len").alias("sliced")).collect() == expected,
>   File "/Users/s.singh/personal/spark-oss/python/pyspark/sql/utils.py", line 332, in wrapped
>     return getattr(functions, f.__name__)(*args, **kwargs)
>   File "/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/functions.py", line 1525, in slice
>     raise TypeError(f"start should be a Column or int, but got {type(start).__name__}")
> TypeError: start should be a Column or int, but got str{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org