You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2008/08/28 15:00:24 UTC

svn commit: r689805 - in /directory/studio/trunk/ldapbrowser-ui: ./ src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/

Author: seelmann
Date: Thu Aug 28 06:00:21 2008
New Revision: 689805

URL: http://svn.apache.org/viewvc?rev=689805&view=rev
Log:
Removed unused PropertyPages, removed useless SubSchemaPropertyPage, added javadoc

Removed:
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaAttributesPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaObjectClassesPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SubSchemaPropertyPage.java
Modified:
    directory/studio/trunk/ldapbrowser-ui/plugin.properties
    directory/studio/trunk/ldapbrowser-ui/plugin.xml
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/AttributePropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/BookmarkPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/EntryPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/RootDSEPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SearchPropertyPage.java
    directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/ValuePropertyPage.java

Modified: directory/studio/trunk/ldapbrowser-ui/plugin.properties
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/plugin.properties?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/plugin.properties (original)
+++ directory/studio/trunk/ldapbrowser-ui/plugin.properties Thu Aug 28 06:00:21 2008
@@ -119,9 +119,6 @@
 PropPage_Entry_id=org.apache.directory.studio.ldapbrowser.ui.dialogs.properties.EntryPropertyPage
 PropPage_Entry_name=Entry
 
-PropPage_Subschema_id=org.apache.directory.studio.ldapbrowser.ui.dialogs.properties.SubSchemaPropertyPage
-PropPage_Subschema_name=Subschema
-
 PropPage_Attribute_id=org.apache.directory.studio.ldapbrowser.ui.dialogs.properties.AttributePropertyPage
 PropPage_Attribute_name=Attribute
 

Modified: directory/studio/trunk/ldapbrowser-ui/plugin.xml
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/plugin.xml?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/plugin.xml (original)
+++ directory/studio/trunk/ldapbrowser-ui/plugin.xml Thu Aug 28 06:00:21 2008
@@ -278,12 +278,6 @@
         name="%PropPage_Entry_name"
         objectClass="org.apache.directory.studio.ldapbrowser.core.propertypageproviders.EntryPropertyPageProvider">
   </page>            
-		<page
-        category="%PropPage_Entry_id"
-        class="org.apache.directory.studio.ldapbrowser.ui.dialogs.properties.SubSchemaPropertyPage"
-        id="%PropPage_Subschema_id"
-        name="%PropPage_Subschema_name"
-        objectClass="org.apache.directory.studio.ldapbrowser.core.propertypageproviders.EntryPropertyPageProvider"/>
 	  <page
          class="org.apache.directory.studio.ldapbrowser.ui.dialogs.properties.AttributePropertyPage"
          id="%PropPage_Attribute_id"

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/AttributePropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/AttributePropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/AttributePropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/AttributePropertyPage.java Thu Aug 28 06:00:21 2008
@@ -42,46 +42,73 @@
 import org.eclipse.ui.dialogs.PropertyPage;
 
 
+/**
+ * This page shows some info about the selected Attribute.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class AttributePropertyPage extends PropertyPage implements IWorkbenchPropertyPage
 {
 
+    /** The attribute name text. */
     private Text attributeNameText;
 
+    /** The attribute type text. */
     private Text attributeTypeText;
 
+    /** The attribute values text. */
     private Text attributeValuesText;
 
+    /** The attribute size text. */
     private Text attributeSizeText;
 
+    /** The atd oid text. */
     private Text atdOidText;
 
+    /** The atd names text. */
     private Text atdNamesText;
 
+    /** The atd desc text. */
     private Text atdDescText;
 
+    /** The atd usage text. */
     private Text atdUsageText;
 
+    /** The single valued flag. */
     private Button singleValuedFlag;
 
+    /** The collective flag. */
     private Button collectiveFlag;
 
+    /** The obsolete flag. */
     private Button obsoleteFlag;
 
+    /** The no user modification flag. */
     private Button noUserModificationFlag;
 
+    /** The equality matching rule text. */
     private Text equalityMatchingRuleText;
 
+    /** The substring matching rule text. */
     private Text substringMatchingRuleText;
 
+    /** The ordering matching rule text. */
     private Text orderingMatchingRuleText;
 
+    /** The syntax oid text. */
     private Text syntaxOidText;
 
+    /** The syntax desc text. */
     private Text syntaxDescText;
 
+    /** The syntax length text. */
     private Text syntaxLengthText;
 
 
+    /**
+     * Creates a new instance of AttributePropertyPage.
+     */
     public AttributePropertyPage()
     {
         super();
@@ -89,6 +116,9 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     protected Control createContents( Composite parent )
     {
         Composite composite = BaseWidgetUtils.createColumnContainer( parent, 1, 1 );
@@ -287,6 +317,13 @@
     }
 
 
+    /**
+     * Gets the attribute.
+     * 
+     * @param element the element
+     * 
+     * @return the attribute
+     */
     private static IAttribute getAttribute( Object element )
     {
         IAttribute attribute = null;

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/BookmarkPropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/BookmarkPropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/BookmarkPropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/BookmarkPropertyPage.java Thu Aug 28 06:00:21 2008
@@ -21,13 +21,12 @@
 package org.apache.directory.studio.ldapbrowser.ui.dialogs.properties;
 
 
+import org.apache.directory.studio.connection.core.Utils;
 import org.apache.directory.studio.connection.ui.widgets.BaseWidgetUtils;
 import org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyEvent;
 import org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyListener;
 import org.apache.directory.studio.ldapbrowser.common.widgets.search.EntryWidget;
 import org.apache.directory.studio.ldapbrowser.core.model.IBookmark;
-import org.apache.directory.studio.connection.core.Utils;
-
 import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.swt.events.ModifyEvent;
 import org.eclipse.swt.events.ModifyListener;
@@ -38,16 +37,28 @@
 import org.eclipse.ui.dialogs.PropertyPage;
 
 
+/**
+ * This page shows some info about the selected Bookmark.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class BookmarkPropertyPage extends PropertyPage implements IWorkbenchPropertyPage
 {
 
+    /** The bookmark. */
     private IBookmark bookmark;
 
+    /** The bookmark name text. */
     private Text bookmarkNameText;
 
+    /** The bookmark entry widget. */
     private EntryWidget bookmarkEntryWidget;
 
 
+    /**
+     * Creates a new instance of BookmarkPropertyPage.
+     */
     public BookmarkPropertyPage()
     {
         super();
@@ -55,32 +66,28 @@
     }
 
 
-    public void dispose()
-    {
-        super.dispose();
-    }
-
-
+    /**
+     * {@inheritDoc}
+     */
     protected Control createContents( Composite parent )
     {
 
         if ( getElement() instanceof IAdaptable )
         {
-            this.bookmark = ( IBookmark ) ( ( IAdaptable ) getElement() ).getAdapter( IBookmark.class );
+            bookmark = ( IBookmark ) ( ( IAdaptable ) getElement() ).getAdapter( IBookmark.class );
             super.setMessage( "Bookmark " + Utils.shorten( bookmark.getName(), 30 ) );
         }
         else
         {
-            this.bookmark = null;
+            bookmark = null;
         }
 
         Composite innerComposite = BaseWidgetUtils.createColumnContainer( parent, 3, 1 );
 
         BaseWidgetUtils.createLabel( innerComposite, "Bookmark Name:", 1 );
-        this.bookmarkNameText = BaseWidgetUtils.createText( innerComposite, this.bookmark != null ? this.bookmark
-            .getName() : "", 2 );
-        this.bookmarkNameText.setFocus();
-        this.bookmarkNameText.addModifyListener( new ModifyListener()
+        bookmarkNameText = BaseWidgetUtils.createText( innerComposite, bookmark != null ? bookmark.getName() : "", 2 );
+        bookmarkNameText.setFocus();
+        bookmarkNameText.addModifyListener( new ModifyListener()
         {
             public void modifyText( ModifyEvent e )
             {
@@ -89,13 +96,13 @@
         } );
 
         BaseWidgetUtils.createLabel( innerComposite, "Bookmark DN:", 1 );
-        this.bookmarkEntryWidget = new EntryWidget();
-        this.bookmarkEntryWidget.createWidget( innerComposite );
-        if ( this.bookmark != null )
+        bookmarkEntryWidget = new EntryWidget();
+        bookmarkEntryWidget.createWidget( innerComposite );
+        if ( bookmark != null )
         {
-            this.bookmarkEntryWidget.setInput( this.bookmark.getBrowserConnection(), this.bookmark.getDn() );
+            bookmarkEntryWidget.setInput( bookmark.getBrowserConnection(), bookmark.getDn() );
         }
-        this.bookmarkEntryWidget.addWidgetModifyListener( new WidgetModifyListener()
+        bookmarkEntryWidget.addWidgetModifyListener( new WidgetModifyListener()
         {
             public void widgetModified( WidgetModifyEvent event )
             {
@@ -107,38 +114,43 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean performOk()
     {
-        if ( this.bookmark != null )
+        if ( bookmark != null )
         {
-            this.bookmark.setName( this.bookmarkNameText.getText() );
-            this.bookmark.setDn( this.bookmarkEntryWidget.getDn() );
-            this.bookmarkEntryWidget.saveDialogSettings();
+            bookmark.setName( bookmarkNameText.getText() );
+            bookmark.setDn( bookmarkEntryWidget.getDn() );
+            bookmarkEntryWidget.saveDialogSettings();
         }
 
         return true;
     }
 
 
+    /**
+     * Validates the input fields.
+     */
     private void validate()
     {
+        setValid( bookmarkEntryWidget.getDn() != null && !"".equals( bookmarkNameText.getText() ) );
 
-        setValid( this.bookmarkEntryWidget.getDn() != null && !"".equals( this.bookmarkNameText.getText() ) );
-
-        if ( this.bookmark != null )
+        if ( bookmark != null )
         {
-            if ( this.bookmarkEntryWidget.getDn() == null )
+            if ( bookmarkEntryWidget.getDn() == null )
             {
                 setValid( false );
                 setErrorMessage( "Please enter a DN." );
             }
-            else if ( "".equals( this.bookmarkNameText.getText() ) )
+            else if ( "".equals( bookmarkNameText.getText() ) )
             {
                 setValid( false );
                 setErrorMessage( "Please enter a name." );
             }
-            else if ( !bookmark.getName().equals( this.bookmarkNameText.getText() )
-                && bookmark.getBrowserConnection().getBookmarkManager().getBookmark( this.bookmarkNameText.getText() ) != null )
+            else if ( !bookmark.getName().equals( bookmarkNameText.getText() )
+                && bookmark.getBrowserConnection().getBookmarkManager().getBookmark( bookmarkNameText.getText() ) != null )
             {
                 setValid( false );
                 setErrorMessage( "A bookmark with this name already exists." );

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/EntryPropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/EntryPropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/EntryPropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/EntryPropertyPage.java Thu Aug 28 06:00:21 2008
@@ -23,7 +23,6 @@
 
 import org.apache.directory.studio.connection.ui.RunnableContextRunner;
 import org.apache.directory.studio.connection.ui.widgets.BaseWidgetUtils;
-import org.apache.directory.studio.ldapbrowser.core.events.EntryModificationEvent;
 import org.apache.directory.studio.ldapbrowser.core.jobs.InitializeAttributesRunnable;
 import org.apache.directory.studio.ldapbrowser.core.jobs.InitializeChildrenRunnable;
 import org.apache.directory.studio.ldapbrowser.core.model.IAttribute;
@@ -44,36 +43,58 @@
 import org.eclipse.ui.dialogs.PropertyPage;
 
 
+/**
+ * This page shows some info about the selected Entry.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryPropertyPage extends PropertyPage implements IWorkbenchPropertyPage
 {
 
+    /** The dn text. */
     private Text dnText;
 
+    /** The url text. */
     private Text urlText;
 
+    /** The ct text. */
     private Text ctText;
 
+    /** The cn text. */
     private Text cnText;
 
+    /** The mt text. */
     private Text mtText;
 
+    /** The mn text. */
     private Text mnText;
 
+    /** The reload cmi button. */
     private Button reloadCmiButton;
 
+    /** The size text. */
     private Text sizeText;
 
+    /** The children text. */
     private Text childrenText;
 
+    /** The attributes text. */
     private Text attributesText;
 
+    /** The values text. */
     private Text valuesText;
 
+    /** The include operational attributes button. */
     private Button includeOperationalAttributesButton;
 
+    /** The reload entry button. */
     private Button reloadEntryButton;
 
 
+    /**
+     * Creates a new instance of EntryPropertyPage.
+     */
     public EntryPropertyPage()
     {
         super();
@@ -81,9 +102,11 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     protected Control createContents( Composite parent )
     {
-
         Composite composite = BaseWidgetUtils.createColumnContainer( parent, 1, 1 );
 
         Composite mainGroup = BaseWidgetUtils.createColumnContainer( BaseWidgetUtils.createColumnContainer( composite,
@@ -207,23 +230,28 @@
             }
         } );
 
-        this.entryUpdated( getEntry( getElement() ) );
+        entryUpdated( getEntry( getElement() ) );
 
         return composite;
     }
 
 
+    /**
+     * Reload operational attributes.
+     */
     private void reloadOperationalAttributes()
     {
         IEntry entry = EntryPropertyPage.getEntry( getElement() );
         InitializeAttributesRunnable runnable = new InitializeAttributesRunnable( new IEntry[]
             { entry }, true );
         RunnableContextRunner.execute( runnable, null, true );
-
-        this.entryUpdated( entry );
+        entryUpdated( entry );
     }
 
 
+    /**
+     * Reload entry.
+     */
     private void reloadEntry()
     {
         IEntry entry = EntryPropertyPage.getEntry( getElement() );
@@ -233,10 +261,17 @@
             { entry }, true );
         RunnableContextRunner.execute( runnable1, null, true );
         RunnableContextRunner.execute( runnable2, null, true );
-        this.entryUpdated( entry );
+        entryUpdated( entry );
     }
 
 
+    /**
+     * Gets the entry.
+     * 
+     * @param element the element
+     * 
+     * @return the entry
+     */
     static IEntry getEntry( Object element )
     {
         IEntry entry = null;
@@ -248,18 +283,24 @@
     }
 
 
+    /**
+     * Checks if is disposed.
+     * 
+     * @return true, if is disposed
+     */
     public boolean isDisposed()
     {
         return this.dnText.isDisposed();
     }
 
 
-    public void entryUpdated( EntryModificationEvent event )
-    {
-        this.entryUpdated( event.getModifiedEntry() );
-    }
-
-
+    /**
+     * Gets the non-null string value.
+     * 
+     * @param att the attribute
+     * 
+     * @return the non-null string value
+     */
     private String getNonNullStringValue( IAttribute att )
     {
         String value = null;
@@ -271,25 +312,29 @@
     }
 
 
+    /**
+     * Updates the text widgets if the entry was updated.
+     * 
+     * @param entry the entry
+     */
     private void entryUpdated( IEntry entry )
     {
 
         if ( !this.dnText.isDisposed() )
         {
+            setMessage( "Entry " + entry.getDn().getUpName() );
 
-            this.setMessage( "Entry " + entry.getDn().getUpName() );
-
-            this.dnText.setText( entry.getDn().getUpName() );
-            this.urlText.setText( entry.getUrl().toString() );
-            this.ctText.setText( getNonNullStringValue( entry
+            dnText.setText( entry.getDn().getUpName() );
+            urlText.setText( entry.getUrl().toString() );
+            ctText.setText( getNonNullStringValue( entry
                 .getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_CREATE_TIMESTAMP ) ) );
-            this.cnText.setText( getNonNullStringValue( entry
-                .getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_CREATORS_NAME ) ) );
-            this.mtText.setText( getNonNullStringValue( entry
+            cnText
+                .setText( getNonNullStringValue( entry.getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_CREATORS_NAME ) ) );
+            mtText.setText( getNonNullStringValue( entry
                 .getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_MODIFY_TIMESTAMP ) ) );
-            this.mnText.setText( getNonNullStringValue( entry
-                .getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_MODIFIERS_NAME ) ) );
-            this.reloadCmiButton.setText( "Refresh" );
+            mnText
+                .setText( getNonNullStringValue( entry.getAttribute( IAttribute.OPERATIONAL_ATTRIBUTE_MODIFIERS_NAME ) ) );
+            reloadCmiButton.setText( "Refresh" );
 
             int attCount = 0;
             int valCount = 0;
@@ -301,7 +346,7 @@
                 for ( int attIndex = 0; attIndex < allAttributes.length; attIndex++ )
                 {
                     if ( !allAttributes[attIndex].isOperationalAttribute()
-                        || this.includeOperationalAttributesButton.getSelection() )
+                        || includeOperationalAttributesButton.getSelection() )
                     {
                         attCount++;
                         IValue[] allValues = allAttributes[attIndex].getValues();
@@ -317,19 +362,19 @@
                 }
             }
 
-            this.reloadEntryButton.setText( "Refresh" );
+            reloadEntryButton.setText( "Refresh" );
             if ( !entry.isChildrenInitialized() )
             {
-                this.childrenText.setText( "Not checked" );
+                childrenText.setText( "Not checked" );
             }
             else
             {
-                this.childrenText.setText( "" + entry.getChildrenCount()
+                childrenText.setText( "" + entry.getChildrenCount()
                     + ( entry.hasMoreChildren() ? " fetched, may have more" : "" ) );
             }
-            this.attributesText.setText( "" + attCount );
-            this.valuesText.setText( "" + valCount );
-            this.sizeText.setText( Utils.formatBytes( bytes ) );
+            attributesText.setText( "" + attCount );
+            valuesText.setText( "" + valCount );
+            sizeText.setText( Utils.formatBytes( bytes ) );
         }
     }
 

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/RootDSEPropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/RootDSEPropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/RootDSEPropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/RootDSEPropertyPage.java Thu Aug 28 06:00:21 2008
@@ -44,7 +44,7 @@
 
 
 /**
- * This page shows some info of the Root DSE.
+ * This page shows some info about the Root DSE.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaPropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaPropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaPropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SchemaPropertyPage.java Thu Aug 28 06:00:21 2008
@@ -46,7 +46,7 @@
 
 
 /**
- * Property page to shows some meta information of the schema an the 
+ * Property page to shows some meta information of the schema and the 
  * schema cache. 
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SearchPropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SearchPropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SearchPropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/SearchPropertyPage.java Thu Aug 28 06:00:21 2008
@@ -21,6 +21,7 @@
 package org.apache.directory.studio.ldapbrowser.ui.dialogs.properties;
 
 
+import org.apache.directory.studio.connection.core.Utils;
 import org.apache.directory.studio.connection.ui.widgets.BaseWidgetUtils;
 import org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyEvent;
 import org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyListener;
@@ -29,7 +30,6 @@
 import org.apache.directory.studio.ldapbrowser.core.events.SearchUpdateEvent;
 import org.apache.directory.studio.ldapbrowser.core.model.ISearch;
 import org.apache.directory.studio.ldapbrowser.core.model.impl.Search;
-import org.apache.directory.studio.connection.core.Utils;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.ui.IWorkbenchPropertyPage;
@@ -63,7 +63,7 @@
 
 
     /**
-     * @see org.eclipse.jface.dialogs.DialogPage#dispose()
+     * {@inheritDoc}
      */
     public void dispose()
     {
@@ -73,11 +73,10 @@
 
 
     /**
-     * @see org.eclipse.jface.preference.PreferencePage#createContents(org.eclipse.swt.widgets.Composite)
+     * {@inheritDoc}
      */
     protected Control createContents( Composite parent )
     {
-
         // declare search
         ISearch search = ( ISearch ) getElement();
         if ( search != null )
@@ -105,7 +104,7 @@
 
 
     /**
-     * @see org.eclipse.jface.preference.PreferencePage#performOk()
+     * {@inheritDoc}
      */
     public boolean performOk()
     {
@@ -124,7 +123,7 @@
 
 
     /**
-     * @see org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyListener#widgetModified(org.apache.directory.studio.ldapbrowser.common.widgets.WidgetModifyEvent)
+     * {@inheritDoc}
      */
     public void widgetModified( WidgetModifyEvent event )
     {

Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/ValuePropertyPage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/ValuePropertyPage.java?rev=689805&r1=689804&r2=689805&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/ValuePropertyPage.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/dialogs/properties/ValuePropertyPage.java Thu Aug 28 06:00:21 2008
@@ -24,7 +24,6 @@
 import org.apache.directory.studio.connection.ui.widgets.BaseWidgetUtils;
 import org.apache.directory.studio.ldapbrowser.core.model.IValue;
 import org.apache.directory.studio.ldapbrowser.core.utils.Utils;
-
 import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.jface.dialogs.IDialogConstants;
 import org.eclipse.jface.resource.JFaceResources;
@@ -37,18 +36,31 @@
 import org.eclipse.ui.dialogs.PropertyPage;
 
 
+/**
+ * This page shows some info about the selected Value.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ValuePropertyPage extends PropertyPage implements IWorkbenchPropertyPage
 {
 
+    /** The description text. */
     private Text descriptionText;
 
+    /** The value text. */
     private Text valueText;
 
+    /** The type text. */
     private Text typeText;
 
+    /** The size text. */
     private Text sizeText;
 
 
+    /**
+     * Creates a new instance of ValuePropertyPage.
+     */
     public ValuePropertyPage()
     {
         super();
@@ -56,9 +68,11 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     protected Control createContents( Composite parent )
     {
-
         IValue value = getValue( getElement() );
 
         Composite composite = BaseWidgetUtils.createColumnContainer( parent, 1, 1 );
@@ -110,6 +124,13 @@
     }
 
 
+    /**
+     * Gets the value.
+     * 
+     * @param element the element
+     * 
+     * @return the value
+     */
     private static IValue getValue( Object element )
     {
         IValue value = null;