[jira] [Commented] (CASSANDRA-14628) Clean up cache-related metrics

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573402#comment-16573402 ] 

Aleksey Yeschenko commented on CASSANDRA-14628:
-----------------------------------------------

Branch [here|https://github.com/iamaleksey/cassandra/commits/14628-4.0], CI pending [here|https://circleci.com/workflow-run/4d4f4fd1-28f4-47e0-9470-2730496c71b1].

> Clean up cache-related metrics
> ------------------------------
>
>                 Key: CASSANDRA-14628
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14628
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>              Labels: virtual-tables
>             Fix For: 4.0
>
>
> {{ChunkCache}} added {{CacheMissMetrics}} which is an almost exact duplicate of pre-existing {{CacheMetrics}}. I believe it was done initially because the authors thought there was no way to register hits with {{Caffeine}}, only misses, but that's not quite true. All we need is to provide a {{StatsCounter}} object when building the cache and update our metrics from there.
> The patch removes the redundant code and streamlines chunk cache metrics to use more idiomatic tracking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org