You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by Zheng Feng <zh...@gmail.com> on 2019/04/03 06:55:56 UTC
[DISCUSS] Require the review before merging the PR
Hi,
I just wonder if we can enable this setting [1] on servicecomb-pack [2] and
it could be helpful when reviewing the PR. I think at least one people
review the changes and approve before merging it. We have to raise a JIRA
for the infra team to do this setting. So I post this message here to see
if the others have any thought.
Regards,
Zheng Feng
[1]
https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
[2] https://github.com/apache/servicecomb-pack
回复： [DISCUSS] Require the review before merging the PR
Posted by bismy <bi...@qq.com>.
+1
We require at least one or two reviewers review for java-chassis in practice. We can make it required by adding this configuration.
------------------ 原始邮件 ------------------
发件人: "zzzwjm"<zz...@gmail.com>;
发送时间: 2019年4月3日(星期三) 晚上10:23
收件人: "dev"<de...@servicecomb.apache.org>;
主题: Re: [DISCUSS] Require the review before merging the PR
+1
zhang_lei@boco.com.cn <zh...@boco.com.cn> 于2019年4月3日周三 下午3:25写道：
> +1
>
> > 在 2019年4月3日，下午2:55，Zheng Feng <zh...@gmail.com> 写道：
> >
> > Hi,
> >
> > I just wonder if we can enable this setting [1] on servicecomb-pack [2]
> and
> > it could be helpful when reviewing the PR. I think at least one people
> > review the changes and approve before merging it. We have to raise a JIRA
> > for the infra team to do this setting. So I post this message here to see
> > if the others have any thought.
> >
> > Regards,
> > Zheng Feng
> >
> > [1]
> >
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> > [2] https://github.com/apache/servicecomb-pack
>
>
> Zhang Lei.
>
>
>
>
Re: [DISCUSS] Require the review before merging the PR
Posted by wjm wjm <zz...@gmail.com>.
+1
zhang_lei@boco.com.cn <zh...@boco.com.cn> 于2019年4月3日周三 下午3:25写道：
> +1
>
> > 在 2019年4月3日，下午2:55，Zheng Feng <zh...@gmail.com> 写道：
> >
> > Hi,
> >
> > I just wonder if we can enable this setting [1] on servicecomb-pack [2]
> and
> > it could be helpful when reviewing the PR. I think at least one people
> > review the changes and approve before merging it. We have to raise a JIRA
> > for the infra team to do this setting. So I post this message here to see
> > if the others have any thought.
> >
> > Regards,
> > Zheng Feng
> >
> > [1]
> >
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> > [2] https://github.com/apache/servicecomb-pack
>
>
> Zhang Lei.
>
>
>
>
Re: [DISCUSS] Require the review before merging the PR
Posted by "zhang_lei@boco.com.cn" <zh...@boco.com.cn>.
+1
> 在 2019年4月3日，下午2:55，Zheng Feng <zh...@gmail.com> 写道：
>
> Hi,
>
> I just wonder if we can enable this setting [1] on servicecomb-pack [2] and
> it could be helpful when reviewing the PR. I think at least one people
> review the changes and approve before merging it. We have to raise a JIRA
> for the infra team to do this setting. So I post this message here to see
> if the others have any thought.
>
> Regards,
> Zheng Feng
>
> [1]
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> [2] https://github.com/apache/servicecomb-pack
Zhang Lei.
Re: [DISCUSS] Require the review before merging the PR
Posted by Willem Jiang <wi...@gmail.com>.
+1 for it.
We could start from servicecomb-pack project first. We could enable
this feature for the other sub projects if it goes well.
Any thoughts?
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Wed, Apr 3, 2019 at 2:56 PM Zheng Feng <zh...@gmail.com> wrote:
>
> Hi,
>
> I just wonder if we can enable this setting [1] on servicecomb-pack [2] and
> it could be helpful when reviewing the PR. I think at least one people
> review the changes and approve before merging it. We have to raise a JIRA
> for the infra team to do this setting. So I post this message here to see
> if the others have any thought.
>
> Regards,
> Zheng Feng
>
> [1]
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> [2] https://github.com/apache/servicecomb-pack