You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/13 05:10:18 UTC

[GitHub] [incubator-druid] clintropolis opened a new issue #7646: web-console lookup editor doesn't correctly allow creating new lookups

clintropolis opened a new issue #7646: web-console lookup editor doesn't correctly allow creating new lookups
URL: https://github.com/apache/incubator-druid/issues/7646
 
 
   The web-console lookup editor view uses a dropdown that is populated with [historical tiers from `/druid/coordinator/v1/tiers`](https://github.com/apache/incubator-druid/blob/master/web-console/src/views/lookups-view.tsx#L92) instead of lookup tiers which are unfortunately for the editor a totally different thing. It would be less painful if the [default lookup tier](https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/query/lookup/LookupListeningAnnouncerConfig.java#L33) config was the same value as the [default historical tier](https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/client/DruidServer.java#L52) but it is not unfortunately. 
   
   This information can be fetched from a combination of the API calls `/druid/coordinator/v1/lookups/config` and `/druid/coordinator/v1/lookups/config?discover=true` which either returns a list of configured tiers _or_ discovered tiers, the latter of which is [incorrectly listed in the documentation as `/druid/coordinator/v1/lookups?discover=true`](http://druid.io/docs/latest/querying/lookups.html#list-tier-names). 
   
   This dropdowns value should be sourced from the combination of these 2 calls to both have the tiers that have configs, and also tiers which have historical servers associated with them but no defined lookups (maybe we add an `all` query parameter that combines the output of the 2?). 
   
   The input on the editor should also maybe be free-form input to allow new tiers be defined before any historicals are provisioned in that tier, but that seems less important than using the correct set of tiers for the dropdown.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org