You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/03/11 01:37:12 UTC
Review Request 57529: Improved Stout string tests slightly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57529/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Improved Stout string tests slightly.
Diffs
-----
3rdparty/stout/tests/strings_tests.cpp b985a4742cf8c94cc317a77c7818bfb6e0cd79a7
Diff: https://reviews.apache.org/r/57529/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 57529: Improved Stout string tests slightly.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57529/#review170772
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 10, 2017, 5:37 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57529/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 5:37 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved Stout string tests slightly.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/strings_tests.cpp b985a4742cf8c94cc317a77c7818bfb6e0cd79a7
>
>
> Diff: https://reviews.apache.org/r/57529/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57529: Improved Stout string tests slightly.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57529/#review168706
-----------------------------------------------------------
Bad review!
Reviews applied: [57529, 57513, 57512, 57511, 57510, 57516, 57254, 57528, 57527, 57167, 57166, 56805, 57165, 57164]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On March 11, 2017, 1:37 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57529/
> -----------------------------------------------------------
>
> (Updated March 11, 2017, 1:37 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved Stout string tests slightly.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/strings_tests.cpp b985a4742cf8c94cc317a77c7818bfb6e0cd79a7
>
>
> Diff: https://reviews.apache.org/r/57529/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>