You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "BUAAserein (via GitHub)" <gi...@apache.org> on 2023/02/08 15:39:42 UTC

[GitHub] [iotdb] BUAAserein opened a new pull request, #9022: [IOTDB-5491] Add IoT Consumus memory control metric items

BUAAserein opened a new pull request, #9022:
URL: https://github.com/apache/iotdb/pull/9022

   ## Description
   
   
   ### Please see details in [IOTDB-5491](https://issues.apache.org/jira/browse/IOTDB-5491).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9022: [IOTDB-5491] Add IoTConsumus memory control metric items

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #9022:
URL: https://github.com/apache/iotdb/pull/9022#discussion_r1101152489


##########
consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/IoTConsensusMemoryManagerMetrics.java:
##########
@@ -42,11 +42,29 @@ public void bindTo(AbstractMetricService metricService) {
         IoTConsensusMemoryManager::getMemorySizeInByte,
         Tag.NAME.toString(),
         "IoTConsensus");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getQueueMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Queue");

Review Comment:
   Remove `-` as you have used Camel-Case naming schema.



##########
consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/IoTConsensusMemoryManagerMetrics.java:
##########
@@ -42,11 +42,29 @@ public void bindTo(AbstractMetricService metricService) {
         IoTConsensusMemoryManager::getMemorySizeInByte,
         Tag.NAME.toString(),
         "IoTConsensus");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getQueueMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Queue");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getSyncMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Sync");

Review Comment:
   same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] BUAAserein commented on pull request #9022: [IOTDB-5491] Add IoTConsumus memory control metric items

Posted by "BUAAserein (via GitHub)" <gi...@apache.org>.
BUAAserein commented on PR #9022:
URL: https://github.com/apache/iotdb/pull/9022#issuecomment-1425291172

   > Excellent Work! Just one problem, Please update the en and zh doc at same time en: docs/UserGuide/Monitor-Alert/Metric-Tool.md zh: docs/zh/UserGuide/Monitor-Alert/Metric-Tool.md
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #9022: [IOTDB-5491] Add IoTConsumus memory control metric items

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #9022:
URL: https://github.com/apache/iotdb/pull/9022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] BUAAserein commented on a diff in pull request #9022: [IOTDB-5491] Add IoTConsumus memory control metric items

Posted by "BUAAserein (via GitHub)" <gi...@apache.org>.
BUAAserein commented on code in PR #9022:
URL: https://github.com/apache/iotdb/pull/9022#discussion_r1102358509


##########
consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/IoTConsensusMemoryManagerMetrics.java:
##########
@@ -42,11 +42,29 @@ public void bindTo(AbstractMetricService metricService) {
         IoTConsensusMemoryManager::getMemorySizeInByte,
         Tag.NAME.toString(),
         "IoTConsensus");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getQueueMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Queue");

Review Comment:
   ok



##########
consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/IoTConsensusMemoryManagerMetrics.java:
##########
@@ -42,11 +42,29 @@ public void bindTo(AbstractMetricService metricService) {
         IoTConsensusMemoryManager::getMemorySizeInByte,
         Tag.NAME.toString(),
         "IoTConsensus");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getQueueMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Queue");
+    metricService.createAutoGauge(
+        Metric.MEM.toString(),
+        MetricLevel.IMPORTANT,
+        iotConsensusMemoryManager,
+        IoTConsensusMemoryManager::getSyncMemorySizeInByte,
+        Tag.NAME.toString(),
+        "IoTConsensus_Sync");

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org